From patchwork Mon Apr 29 14:07:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 793691 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 649407BAF9 for ; Mon, 29 Apr 2024 14:08:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714399706; cv=none; b=OGROmUnk0LQP9MtPTIpTwSEI3QUGs5TS62vhd7BbOuTtCJhql+nx8Yn9ZhHiFkvlZDbsMvtXgwiMsOxGnMSkLeCa2qeUuy6/rBnp6GBfxrenXw4IzBfStl6KMyzWy2hYYUWxsQoW1huIYrD0GHk1RWWU1I5SFl7dJ6EvhyNA+tU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714399706; c=relaxed/simple; bh=WrCjqqS4I8VzWNdnSjP2v41ZlCPdZRUDzsyBoXAuSUg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=D4rfPXkj8Qo/6BGEXz1cDZiju6N2MR+KBPIG055td/jfjqvoGTiZ9O+E6z0H6fxaVXF98ebuIIHdppG3PumTq2dUv/YLRzaQpIsJXjCUZzoytra1rFpRRc9bIqMV8Rke0UcVyRjXzjEqcmQ54R7t3+qOGVWXS+B90oEwN4tfGSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=LD+oAJp1; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="LD+oAJp1" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3499f1bed15so3219628f8f.1 for ; Mon, 29 Apr 2024 07:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1714399703; x=1715004503; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=rGP2iA16V5Nst5OwKNnVBbqTeg1qcPV1rwQPISYCkp0=; b=LD+oAJp1ytflpXrnrbzP4asQgsLC/HTvdpRdEuh3ls/E8OP0pTerDOaB52bS8X5YtV QlAtriUgAKOxzNFmt3yTml8dR9UjECCkBlFEokalCSATLBjvH1zV5/+5FC+9DwH0B25V aBGd72T5NoeTN1dnlN+XbK8/3nwOnFLw9STVgFSb89uy42TFEx2bqGh18KBImBhSjfdA UCCRZo2CTBNBA+LdF3C49ydS5Nlrs8gSO0s+LrRKsRju/kkZFFmpkQ+MxGrlOWIobS4G /Sz1lVesym28O66XfvgQWNC0jrvLeENjXxmqHovbuaTaMJ5DC7Ldr4cePiiT78F68+ce VmDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714399703; x=1715004503; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rGP2iA16V5Nst5OwKNnVBbqTeg1qcPV1rwQPISYCkp0=; b=ACQRdnedpa7pMI7frJKYv9rxAXuqzt6XKovof4N0nIJ2U9JA8ndv2ZO0x+rmeR5vlj yxsBDGxVhTfhtL/zEOzrCvPWkvwIczvG8fpwzKIhUTF/n2j3MpqECflNmfbojbvxc67a UKWZb39HnZiF6QTOxlOjaAK01+Np9lwLjwB4oq87xLwthTNKBtL/2O5bn8vPm5JuIHra wRhRkuNOpVh0ZfH1SU8/QpzY6tcWhAsgYcKE0UwlIIjKifjQ94g4nw6sS+yG2wD8NS2Y B5sZYxzd0sPzyedue9EJTpkgyjSzJYQUrgSUDkD0oYOZfMAO0QylH6XEpCw3y6XF55nN hBmg== X-Gm-Message-State: AOJu0YxWYjoS7Xr5ZihzlSCA5H8N4uKZ658O9pUGmg8Dl2wQ62TxZR8e HSEQIpxBuMY0nJhMjr2j+DiLIAFxPxBLBA5AAmLWCQK7BSUbQik7R+dmhpWaBTA= X-Google-Smtp-Source: AGHT+IGZQ41fU/EkV4HmK7QBpPzyho5VaflH4h8vksb+XnkyV8QbMyfG8zg8SLKLUmGItkgqlupe+A== X-Received: by 2002:adf:f3c1:0:b0:343:8bd6:97cf with SMTP id g1-20020adff3c1000000b003438bd697cfmr5372945wrp.35.1714399702664; Mon, 29 Apr 2024 07:08:22 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id h1-20020a5d6881000000b0034615862c64sm29585477wru.110.2024.04.29.07.08.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 07:08:22 -0700 (PDT) Message-ID: <0914f96e-fcfd-4088-924a-fc1991bce75f@freebox.fr> Date: Mon, 29 Apr 2024 16:07:27 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi From: Marc Gonzalez To: Kalle Valo , Jeff Johnson , ath10k Cc: wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Konrad Dybcio , Jami Kettunen , Jeffrey Hugo , Dmitry Baryshkov , Alexey Minnekhanov References: Content-Language: en-US In-Reply-To: The ath10k driver waits for an "MSA_READY" indicator to complete initialization. If the indicator is not received, then the device remains unusable. cf. ath10k_qmi_driver_event_work() Several msm8998-based devices are affected by this issue. Oddly, it seems safe to NOT wait for the indicator, and proceed immediately when QMI_EVENT_SERVER_ARRIVE. Jeff Johnson wrote: The feedback I received was "it might be ok to change all ath10k qmi to skip waiting for msa_ready", and it was pointed out that ath11k (and ath12k) do not wait for it. However with so many deployed devices, "might be ok" isn't a strong argument for changing the default behavior. cf. also https://wiki.postmarketos.org/wiki/Qualcomm_Snapdragon_835_(MSM8998)#WLAN Signed-off-by: Marc Gonzalez Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 67b8374ddf02f..4e6245095adfc 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -3234,6 +3234,7 @@ wifi: wifi@18800000 { iommus = <&anoc2_smmu 0x1900>, <&anoc2_smmu 0x1901>; qcom,snoc-host-cap-8bit-quirk; + qcom,no-msa-ready-indicator; }; }; };