From patchwork Tue Jul 9 08:38:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Fietkau X-Patchwork-Id: 812057 Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8DFF12C481 for ; Tue, 9 Jul 2024 08:38:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.4.11.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720514325; cv=none; b=twQQAbVfyD9p+b9N7/jcZR39zC3njU5AaSlJ+RMejwEQd5SKRnbeN7X0jLs7rHZMLSmuKKRABQVtvcVFY/ZZTlUsrmkmYckXyHBDflXa3tC6uq5PKLaFKGrxsmDSBVmh3f02XBcDObYlpeUc1gtvlwRykwMXMDbnl4oQ/p7BQX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720514325; c=relaxed/simple; bh=5xKnf9FMlOrb66z9zpMBitDiJ/6q6dXfRMnv2XZYZBo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nsDQURUrcrEgMpu7hUDdSTJbTSIVYd6++PRUHmZgpvwL9RKqYOD5HOEQjHxySYmMTL1aHw7XldZylQyI1u9+Kto471xzh4vHsbvVOS4URZCPgsr59JYlCHc1IFnOgCxIhCzmG8fJhkkeQZA1J4n+3CK450mqMAqa3WZk20wBRNk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name; spf=none smtp.mailfrom=nbd.name; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b=UN6gnUsz; arc=none smtp.client-ip=46.4.11.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nbd.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="UN6gnUsz" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y7waa6tblZzLkaQ3m3AohjYubeQ7lSxJ/bcC4+Sv7pM=; b=UN6gnUszq2B/nUQO5cx1GQDJcE t6WI88OMtJDntbJiw0qm8O5b0JTDAXJVriCM8c0eIZwSx04TktZOXhr4ex4fNrs71TBpinnORevo2 lc9imNIQYN66XlGRNIf83g3MD2ccHSu6WZtjqnVM+pvdsjlqCW2gO9X+pboiBYIl7EqE=; Received: from p54ae937c.dip0.t-ipconnect.de ([84.174.147.124] helo=localhost.localdomain) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 (Exim 4.96) (envelope-from ) id 1sR6Mx-004Ln4-28; Tue, 09 Jul 2024 10:38:39 +0200 From: Felix Fietkau To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, quic_adisi@quicinc.com, quic_periyasa@quicinc.com, ath12k@lists.infradead.org Subject: [PATCH v5 00/10] cfg80211/mac80211: support defining multiple radios per wiphy Date: Tue, 9 Jul 2024 10:38:28 +0200 Message-ID: X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The prerequisite for MLO support in cfg80211/mac80211 is that all the links participating in MLO must be from the same wiphy/ieee80211_hw. To meet this expectation, some drivers may need to group multiple discrete hardware each acting as a link in MLO under single wiphy. With this change, supported frequencies and interface combinations of each individual radio are reported to user space. This allows user space to figure out the limitations of what combination of channels can be used concurrently. Each mac80211 channel context is assigned to a radio based on radio specific frequency ranges and interface combinations. Even for non-MLO devices, this improves support for devices capable of running on multiple channels at the same time. This is loosely based on Karthikeyan Periyasamy's series "[PATCH 00/13] wifi: Add multi physical hardware iface combination support" with some differences: - a struct wiphy_radio is defined, which holds the frequency ranges and a full struct ieee80211_iface_combination array - a channel context is explicitly assigned to a radio when created - both global and per-radio interface combination limits are checked and enforced on channel context assignment - improve comments/docs and attributes - add cfg80211 helper for checking radio freq range Changes since PATCH v4: - fix regression in hwsim eht/mld tests Changes since PATCH v3: - add documentation note for interface combinations - fix ibss ifcomb check - drop redundant/incorrect lines in mac80211 radio ifcomb code Changes since PATCH v2: - fix locking annotation for get_radio_mask - fix related rcu access in mac80211 - fix nl80211 radio data type docs - remove __counted_by - fix unwinding on netlink attr/nest - consmetic fixes - remove WARN_ON_ONCE in hwsim Changes since PATCH v1: - add nested flag to newly added nested attributes - make per-radio attributes multi-attr - add __counted_by annotation - remove unnecessary tracing - fix hwsim attribute docs - add hwsim attribute policy - add radio index Changes since RFC v4: - report the first radio's ifcomb as main ifcomb for legacy compatibility - report the global wiphy ifcomb separately - add mac80211_hwsim support Changes since RFC v3: - fix __ieee80211_get_radio_mask to return per-vif radio mask - fix params->radio in ieee80211_check_combinations() - fix indentation - pass radio_idx in struct iface_combination_params - improve get_radio_mask callback Changes since RFC v2: - fix uninitialized variables - fix multiple radios with DFS - add support for per-radio beacon interval checking Changes since RFC: - replace static per-radio number of channels limit with full ifcomb checks - remove band bitmask in favor of only using freq ranges Felix Fietkau (10): wifi: nl80211: split helper function from nl80211_put_iface_combinations wifi: cfg80211: add support for advertising multiple radios belonging to a wiphy wifi: cfg80211: extend interface combination check for multi-radio wifi: cfg80211: add helper for checking if a chandef is valid on a radio wifi: mac80211: add support for DFS with multiple radios wifi: mac80211: add radio index to ieee80211_chanctx_conf wifi: mac80211: extend ifcomb check functions for multi-radio wifi: mac80211: move code in ieee80211_link_reserve_chanctx to a helper wifi: mac80211: add wiphy radio assignment and validation wifi: mac80211_hwsim: add support for multi-radio wiphy drivers/net/wireless/virtual/mac80211_hwsim.c | 74 +++++-- drivers/net/wireless/virtual/mac80211_hwsim.h | 4 +- include/net/cfg80211.h | 56 ++++- include/net/mac80211.h | 2 +- include/uapi/linux/nl80211.h | 65 ++++++- net/mac80211/cfg.c | 7 +- net/mac80211/chan.c | 210 +++++++++++-------- net/mac80211/ibss.c | 2 +- net/mac80211/ieee80211_i.h | 5 +- net/mac80211/iface.c | 2 +- net/mac80211/main.c | 50 +++-- net/mac80211/util.c | 147 ++++++++----- net/wireless/nl80211.c | 202 +++++++++++++----- net/wireless/rdev-ops.h | 12 +- net/wireless/util.c | 68 +++++- 15 files changed, 679 insertions(+), 227 deletions(-) base-commit: 1b431ba4ef9a760e7643d6fbc53bf522d59650f3