From patchwork Tue Nov 8 20:18:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 622902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F313C43219 for ; Tue, 8 Nov 2022 20:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbiKHUSc (ORCPT ); Tue, 8 Nov 2022 15:18:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiKHUSa (ORCPT ); Tue, 8 Nov 2022 15:18:30 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D5A14D32; Tue, 8 Nov 2022 12:18:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 32837B81C4B; Tue, 8 Nov 2022 20:18:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E718C433D7; Tue, 8 Nov 2022 20:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667938705; bh=WyEheEiq/StleYaLyY18Lb8AoLR/BnuFGuWyCblPpM0=; h=Date:From:To:Cc:Subject:From; b=OLRidf0kOhpEWgDiOV7yjBHXPJhY9INixXclz9UkmID5M9jezvI6lu6pbNuP5Pwce xQ/rrXK/4jbLOXFwOZXSblpsjVTWQeHnEohV18pr1q2Nstl7UoK50fN/im1Wbw/drD hzqJsxrvUFwwVigS8btuokqYU/dHJIhb4t1JJEfNuxt8XTTEoO2foZVL60YfzMhgXz 7Jo8U6a61wPTynDFkNBEdVOPhPTgzQTCQnmZ7qJyEuPYPfYzswbpaG7/aJ1CQOqeFa 8/ITYLygMmWChmrxQfzE20FVJjA1WbL5EnIzEK5TDp6AA5lgA+KJ7ou86ukkXr4WtM 0AxNtxcaXycTw== Date: Tue, 8 Nov 2022 14:18:05 -0600 From: "Gustavo A. R. Silva" To: Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Jouni Malinen , Stanislav Yakovlev , Johannes Berg Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH v3 0/7] Avoid clashing function prototypes Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org When built with Control Flow Integrity, function prototypes between caller and function declaration must match. These mismatches are visible at compile time with the new -Wcast-function-type-strict in Clang[1]. This series fixes a total of 424 -Wcast-function-type-strict warnings. Link: https://reviews.llvm.org/D134831 [1] Changes in v3: - Split non-related orinoco changes out of cgf80211 into a separate patch. - Mention Coccinelle in some of the patches where it was used to make some changes. - Add RB tags to a couple of patches. Changes in v2: - Squash patches 1, 2 and 3 into a single patch cfg80211. - Add a couple more patches: bna and staging. - Fix 254 (227 in bna and 27 in staging) more -Wcast-function-type-strict warnings. - Link: https://lore.kernel.org/linux-hardening/cover.1666894751.git.gustavoars@kernel.org/ v1: - Link: https://lore.kernel.org/linux-hardening/cover.1666038048.git.gustavoars@kernel.org/ Gustavo A. R. Silva (7): wifi: orinoco: Avoid clashing function prototypes cfg80211: Avoid clashing function prototypes wifi: hostap: Avoid clashing function prototypes wifi: zd1201: Avoid clashing function prototypes wifi: airo: Avoid clashing function prototypes bna: Avoid clashing function prototypes staging: ks7010: Avoid clashing function prototypes drivers/net/ethernet/brocade/bna/bfa_cs.h | 60 +++-- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 10 +- drivers/net/ethernet/brocade/bna/bfa_ioc.h | 8 +- drivers/net/ethernet/brocade/bna/bfa_msgq.h | 8 +- drivers/net/ethernet/brocade/bna/bna_enet.c | 6 +- drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 6 +- drivers/net/ethernet/brocade/bna/bna_types.h | 27 +- drivers/net/wireless/cisco/airo.c | 204 +++++++------- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- .../wireless/intersil/hostap/hostap_ioctl.c | 244 +++++++++-------- drivers/net/wireless/intersil/orinoco/wext.c | 131 +++++---- drivers/net/wireless/zydas/zd1201.c | 174 ++++++------ drivers/staging/ks7010/ks_wlan_net.c | 248 +++++++++--------- include/net/cfg80211-wext.h | 20 +- net/wireless/scan.c | 3 +- net/wireless/wext-compat.c | 180 ++++++------- net/wireless/wext-compat.h | 8 +- net/wireless/wext-sme.c | 5 +- 18 files changed, 713 insertions(+), 631 deletions(-) Reviewed-by: Kees Cook