From patchwork Fri Feb 12 23:28:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 382190 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B81C433E0 for ; Fri, 12 Feb 2021 23:29:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C214764E02 for ; Fri, 12 Feb 2021 23:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232025AbhBLX3g (ORCPT ); Fri, 12 Feb 2021 18:29:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231699AbhBLX31 (ORCPT ); Fri, 12 Feb 2021 18:29:27 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 914EFC0613D6 for ; Fri, 12 Feb 2021 15:28:47 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id f2so943195ioq.2 for ; Fri, 12 Feb 2021 15:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ly2pdmyYXxhtuoCSAgENg5OM8ycLhypf9tqgVFI+2u4=; b=Quwx0P+JxiRRGABjyX8i1pZUR+H9o5Hl34uy0BwJ7eFj4lvVU96Vykv/nM2Dydp3ML G/yDWtiOunz2xOr0YULsBP7PFBcOIt5N6bt2iOF78QXuanm0WPWyH/bvm4HAXhjJWllG nDCORLO4+L50RQF0iD9IeL2GARF74lzgtxyaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ly2pdmyYXxhtuoCSAgENg5OM8ycLhypf9tqgVFI+2u4=; b=lpltuq65BN5vdikinAXwoBez4VRc60Po7Sm8jc9sYA7HzvatsvvUw44fu6XUm28Scw GMgVQa5ku7FZwS665CF19xDttdsN9j7lx3VhI5T5EzCwxA/efldmGtOe7v/6JfvmIjlb AiVDZFi4RyPKTrRi8e4kxSC4oBD5SeIm+nrsT9aRcDC1H+pnmcL0Hnh8ueXUk5mBhjJJ wZ7rMawxLQRQAEU9QosMqONepfZ8vHOr5rSYTETAW1WrKOCN9xRRkBHNjkNI+Z7uCFCC x/HsgLIsy0mfLXsvn875PZTmqNP60O2MG/ewshDRZ9cOTfufO/+BpGaRxMYJM94DWDqV +Qmg== X-Gm-Message-State: AOAM533IikTGLAC2c3OvF3G3e1Di0gEZm1anr8zmtE8kr+dI0wxR5QsM 30DOwx0hJa4qI5iiwSXrx/fcoQ== X-Google-Smtp-Source: ABdhPJx5/tVjrSIJi6dtsF0msO8kox5c0tpNk2scRoWwMHOQysCBrTJMjAFHSVV4uHQd7THpyBdRHA== X-Received: by 2002:a02:9042:: with SMTP id y2mr4808243jaf.94.1613172526761; Fri, 12 Feb 2021 15:28:46 -0800 (PST) Received: from shuah-t480s.internal (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id i20sm5180328ilc.2.2021.02.12.15.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 15:28:46 -0800 (PST) From: Shuah Khan To: peterz@infradead.org, mingo@redhat.com, will@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: Shuah Khan , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] Add lockdep_assert_not_held() Date: Fri, 12 Feb 2021 16:28:41 -0700 Message-Id: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Some kernel functions must not be called holding a specific lock. Doing so could lead to locking problems. Currently these routines call lock_is_held() to check for lock hold followed by WARN_ON. Adding a common lockdep interface will help reduce the duplication of this logic in the rest of the kernel. Add lockdep_assert_not_held() to be used in these functions to detect incorrect calls while holding a lock. lockdep_assert_not_held() provides the opposite functionality of lockdep_assert_held() which is used to assert calls that require holding a specific lock. The need for lockdep_assert_not_held() came up in a discussion on ath10k patch. ath10k_drain_tx() and i915_vma_pin_ww() are examples of functions that can use lockdep_assert_not_held(). Link: https://lore.kernel.org/linux-wireless/871rdmu9z9.fsf@codeaurora.org/ This patch series adds lockdep_assert_not_held() and uses it in the second patch in ath10k_drain_tx() function. Shuah Khan (2): lockdep: add lockdep_assert_not_held() ath10k: detect conf_mutex held ath10k_drain_tx() calls drivers/net/wireless/ath/ath10k/mac.c | 2 ++ include/linux/lockdep.h | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) Acked-by: Kalle Valo