mbox series

[v11,00/10] wifi: ath12k: Add monitor interface support on QCN9274

Message ID 20250324062518.2752822-1-quic_periyasa@quicinc.com
Headers show
Series wifi: ath12k: Add monitor interface support on QCN9274 | expand

Message

Karthikeyan Periyasamy March 24, 2025, 6:25 a.m. UTC 
Currently, monitor interface not supported. Therefore, add the missed TLV
tags parsing in the monitor parser, configure the monitor vdev state
identifier with HTT filter setup.

v11:
 wifi: ath12k: Move to NO_VIRTUAL monitor
  - Added new patch to avoid multiple change in a patch
v10:
 wifi: ath12k: add monitor interface support on QCN9274
  - Cleanup the VIRTUAL_MONITOR handler procedures
  - Removed "Reviewed-by" tag
v9:
 wifi: ath12k: fix NULL access in assign channel context handler
  - Updated the commit message
 wifi: ath12k: add monitor interface support on QCN9274
  - Removed the mac80211 callback config handler procedure
  - Removed "Reviewed-by" tag
v8:
 wifi: ath12k: add monitor interface support on QCN9274
  - Added comment section for restricting one monitor i/f in each radio
v7:
 wifi: ath12k: Refactor the monitor channel context procedure
  - Added new patch to avoid multiple change in a patch
 wifi: ath12k: fix NULL access in assign channel context handler
  - Added fixes tag
v6:
 wifi: ath12k: fix NULL access in assign channel context handler
  - Added new patch
 wifi: ath12k: add monitor interface support on QCN9274
  - Moved to NO_VIRTUAL_MONITOR mac80211 feature for adapting single wiphy usecase
  - Removed tags
v5:
 - updated the s-o-b as a last tag
v4:
 - Rebased on ToT
 wifi: ath12k: Replace band define G with GHZ where appropriate
  - Dropped the tags due to rebase changes
v3:
 - rebased to ToT
v2:
 wifi: ath12k: add monitor interface support on QCN9274
  - remove redundant filter setting in ath12k_mac_monitor_start()
  - set the default filter when the htt monitor configuration get disable

Hari Chandrakanthan (1):
  wifi: ath12k: fix link valid field initialization in the monitor Rx

Karthikeyan Periyasamy (4):
  wifi: ath12k: Replace band define G with GHZ where appropriate
  wifi: ath12k: fix NULL access in assign channel context handler
  wifi: ath12k: Refactor the monitor channel context procedure
  wifi: ath12k: Move to NO_VIRTUAL monitor

P Praneesh (5):
  wifi: ath12k: Add extra TLV tag parsing support in monitor Rx path
  wifi: ath12k: Avoid fetch Error bitmap and decap format from Rx TLV
  wifi: ath12k: change the status update in the monitor Rx
  wifi: ath12k: Avoid packet offset and FCS length from Rx TLV
  wifi: ath12k: add monitor interface support on QCN9274

 drivers/net/wireless/ath/ath12k/core.c    |   4 +
 drivers/net/wireless/ath/ath12k/core.h    |  19 +-
 drivers/net/wireless/ath/ath12k/debugfs.c |   4 +-
 drivers/net/wireless/ath/ath12k/dp.h      |   2 +
 drivers/net/wireless/ath/ath12k/dp_mon.c  | 362 ++++++++++++++++++----
 drivers/net/wireless/ath/ath12k/dp_mon.h  |   5 +-
 drivers/net/wireless/ath/ath12k/dp_rx.c   |   6 +-
 drivers/net/wireless/ath/ath12k/dp_tx.c   |   6 +
 drivers/net/wireless/ath/ath12k/hal_rx.h  |  15 +-
 drivers/net/wireless/ath/ath12k/hw.c      |   4 +-
 drivers/net/wireless/ath/ath12k/mac.c     | 237 +++++---------
 drivers/net/wireless/ath/ath12k/wmi.c     |  36 +--
 drivers/net/wireless/ath/ath12k/wmi.h     |  16 +-
 13 files changed, 460 insertions(+), 256 deletions(-)


base-commit: b6f473c96421b8b451a8df8ccb620bcd71d4b3f4

Comments

Vasanthakumar Thiagarajan March 24, 2025, 7:21 a.m. UTC | #1 
On 3/24/2025 11:55 AM, Karthikeyan Periyasamy wrote:
> Currently, VIRTUAL monitor handling is present. In multi radio model,
> VIRTUAL monitor is not suitable since each radio needs a separate VIF and
> channel context. Therefore, switch to NO_VIRTUAL_MONITOR feature. Remove
> the monitor_conf_enabled flag and mac_op_config() handler as they are not
> need for the NO_VIRTUAL_MONITOR feature. In NO_VIRTUAL_MONITOR handling,
> each interface creation/deletion triggers the mac_op_add_interface() /
> mac_op_remove_interface() callback. Consequently, remove the monitor vdev
> create/delete/start/stop from the other vdev type handlers.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Jeff Johnson March 27, 2025, 10:58 p.m. UTC | #2 
On Mon, 24 Mar 2025 11:55:08 +0530, Karthikeyan Periyasamy wrote:
> Currently, monitor interface not supported. Therefore, add the missed TLV
> tags parsing in the monitor parser, configure the monitor vdev state
> identifier with HTT filter setup.
> 
> v11:
>  wifi: ath12k: Move to NO_VIRTUAL monitor
>   - Added new patch to avoid multiple change in a patch
> v10:
>  wifi: ath12k: add monitor interface support on QCN9274
>   - Cleanup the VIRTUAL_MONITOR handler procedures
>   - Removed "Reviewed-by" tag
> v9:
>  wifi: ath12k: fix NULL access in assign channel context handler
>   - Updated the commit message
>  wifi: ath12k: add monitor interface support on QCN9274
>   - Removed the mac80211 callback config handler procedure
>   - Removed "Reviewed-by" tag
> v8:
>  wifi: ath12k: add monitor interface support on QCN9274
>   - Added comment section for restricting one monitor i/f in each radio
> v7:
>  wifi: ath12k: Refactor the monitor channel context procedure
>   - Added new patch to avoid multiple change in a patch
>  wifi: ath12k: fix NULL access in assign channel context handler
>   - Added fixes tag
> v6:
>  wifi: ath12k: fix NULL access in assign channel context handler
>   - Added new patch
>  wifi: ath12k: add monitor interface support on QCN9274
>   - Moved to NO_VIRTUAL_MONITOR mac80211 feature for adapting single wiphy usecase
>   - Removed tags
> v5:
>  - updated the s-o-b as a last tag
> v4:
>  - Rebased on ToT
>  wifi: ath12k: Replace band define G with GHZ where appropriate
>   - Dropped the tags due to rebase changes
> v3:
>  - rebased to ToT
> v2:
>  wifi: ath12k: add monitor interface support on QCN9274
>   - remove redundant filter setting in ath12k_mac_monitor_start()
>   - set the default filter when the htt monitor configuration get disable
> 
> [...]

Applied, thanks!

[01/10] wifi: ath12k: fix link valid field initialization in the monitor Rx
        commit: 2826139f9295821fe2b049318a1cc057ec003131
[02/10] wifi: ath12k: Add extra TLV tag parsing support in monitor Rx path
        commit: 3973cda5ef496fd412fdec2c7c3403ac90e391b8
[03/10] wifi: ath12k: Avoid fetch Error bitmap and decap format from Rx TLV
        commit: a6621bf6397ae6981b5041ba0a127e7dbeade746
[04/10] wifi: ath12k: Replace band define G with GHZ where appropriate
        commit: 6a88093f79ea0b131e5feab9cdc045a007fad26e
[05/10] wifi: ath12k: change the status update in the monitor Rx
        commit: 5393dcb4520911f2b4a980e7e3c2c0de2bbf9ec7
[06/10] wifi: ath12k: Avoid packet offset and FCS length from Rx TLV
        commit: fc1771b9c59e284e72b4fd2e9e405cd220898c1a
[07/10] wifi: ath12k: fix NULL access in assign channel context handler
        commit: ea24531d00f782f4e659e8c74578b7ac144720ca
[08/10] wifi: ath12k: Refactor the monitor channel context procedure
        commit: 1dfa44db967c5c4f73ba5c9177aeaf2dddaff574
[09/10] wifi: ath12k: Move to NO_VIRTUAL monitor
        commit: 7423b64191e325681e0198f4a8ccfe66f282b95a
[10/10] wifi: ath12k: add monitor interface support on QCN9274
        commit: 2c4c3aff7362b09ec356bd9f3b7cf4a718307264

Best regards,