mbox series

[wireless-next,v5,00/10] mwifiex: cleanups

Message ID 20250324-mwifiex-cleanup-1-v5-0-1128a2be02af@pengutronix.de
Headers show
Series mwifiex: cleanups | expand

Message

Sascha Hauer March 24, 2025, 1:24 p.m. UTC 
This contains several cleanup patches for the mwifiex driver. I dropped
the MAC address fixing patch this time as it needs more discussion, but
the remaining patches sent here are nearly unchanged from v1 and should
be good to go.

Sascha

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Changes in v5:
- rebase on wireless-next
- Link to v4: https://lore.kernel.org/r/20250321-mwifiex-cleanup-1-v4-0-4a32b21e2553@pengutronix.de

Changes in v4:
- rebase and test on v6.14-rc7
- drop "wifi: mwifiex: fix MAC address handling" because needs more
  discussion
- Link to v3: https://lore.kernel.org/r/20241202-mwifiex-cleanup-1-v3-0-317a6ce0dd5b@pengutronix.de

Changes in v3:
- Remove Cc: stable tag from 02/12 wifi: mwifiex: fix MAC address handling
- Add better reasons for setting the locally admistered bit in 02/12
  wifi: mwifiex: fix MAC address handling
- Link to v2: https://lore.kernel.org/r/20240918-mwifiex-cleanup-1-v2-0-2d0597187d3c@pengutronix.de

Changes in v2:
- Add refence to 7bff9c974e1a in commit message of "wifi: mwifiex: drop
  asynchronous init waiting code"
- Add extra sentence about bss_started in "wifi: mwifiex: move common
  settings out of switch/case"
- Kill now unused MWIFIEX_BSS_TYPE_ANY
- Collect reviewed-by tags from Francesco Dolcini
- Link to v1: https://lore.kernel.org/r/20240826-mwifiex-cleanup-1-v1-0-56e6f8e056ec@pengutronix.de

---
Sascha Hauer (10):
      wifi: mwifiex: deduplicate code in mwifiex_cmd_tx_rate_cfg()
      wifi: mwifiex: use adapter as context pointer for mwifiex_hs_activated_event()
      wifi: mwifiex: drop unnecessary initialization
      wifi: mwifiex: make region_code_mapping_t const
      wifi: mwifiex: pass adapter to mwifiex_dnld_cmd_to_fw()
      wifi: mwifiex: simplify mwifiex_setup_ht_caps()
      wifi: mwifiex: fix indention
      wifi: mwifiex: make locally used function static
      wifi: mwifiex: move common settings out of switch/case
      wifi: mwifiex: drop asynchronous init waiting code

 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 34 ++++--------
 drivers/net/wireless/marvell/mwifiex/cfp.c      |  4 +-
 drivers/net/wireless/marvell/mwifiex/cmdevt.c   | 74 ++++++++-----------------
 drivers/net/wireless/marvell/mwifiex/init.c     | 18 ++----
 drivers/net/wireless/marvell/mwifiex/main.c     | 40 ++-----------
 drivers/net/wireless/marvell/mwifiex/main.h     | 11 +---
 drivers/net/wireless/marvell/mwifiex/sta_cmd.c  | 49 +++++-----------
 drivers/net/wireless/marvell/mwifiex/txrx.c     |  3 +-
 drivers/net/wireless/marvell/mwifiex/util.c     | 20 +------
 drivers/net/wireless/marvell/mwifiex/wmm.c      | 12 ++--
 10 files changed, 71 insertions(+), 194 deletions(-)
---
base-commit: 1794d7ab34d2221ac7eb921b171e75b856e10561
change-id: 20240826-mwifiex-cleanup-1-b5035c7faff6

Best regards,

Comments

Brian Norris March 25, 2025, 10:26 p.m. UTC | #1 
On Mon, Mar 24, 2025 at 02:24:01PM +0100, Sascha Hauer wrote:
> This contains several cleanup patches for the mwifiex driver. I dropped
> the MAC address fixing patch this time as it needs more discussion, but
> the remaining patches sent here are nearly unchanged from v1 and should
> be good to go.

Thanks! For patches 1-9:

Acked-by: Brian Norris <briannorris@chromium.org>

I had some issues with patch 10.

If you respin before Johannes applies any of these, feel free to carry
my Acked-by.

Brian