| Message ID | 20250321-ath12k-ahb-v12-0-bb389ed76ae5@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: add Ath12k AHB driver support for IPQ5332 | expand |
On Fri, 21 Mar 2025 16:22:37 +0530, Raj Kumar Bhagat wrote: > Currently, Ath12k driver only supports WiFi devices that are based on > PCI bus. New Ath12k device IPQ5332 is based on AHB bus. Hence, add > Ath12k AHB support for IPQ5332. > > IPQ5332 is IEEE802.11be 2 GHz 2x2 Wifi device. To bring-up IPQ5332 > device: > - Add hardware parameters for IPQ5332. > - CE register address space in IPQ5332 is separate from WCSS register > space. Hence, add logic to remap CE register address. > - Add support for fixed QMI firmware memory for IPQ5332. > - Support userPD handling for WCSS secure PIL driver to enable ath12k > AHB support. > > [...] Applied, thanks! [01/13] dt-bindings: net: wireless: describe the ath12k AHB module for IPQ5332 commit: 94fcd39ca255758335ace05f70365f2126190ee0 [02/13] wifi: ath12k: fix incorrect CE addresses commit: 60031d9c3589c7983fd1deb4a4c0bebf0929890e [03/13] wifi: ath12k: refactor ath12k_hw_regs structure commit: 5257324583e32fd5bd6bbb6c82b4f5880b842f99 [04/13] wifi: ath12k: add ath12k_hw_params for IPQ5332 commit: 5fa2fab69f59da8eaf9cbb53fd89727c750b14cf [05/13] wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332 commit: 11794f8540043c230ec4bf57ee1227e765ab52ab [06/13] wifi: ath12k: Add hw_params to remap CE register space for IPQ5332 commit: 12070392be0b39d5305a235401d3ff9f03fdba13 [07/13] wifi: ath12k: add support for fixed QMI firmware memory commit: 6757079c5890f7168a9bc111b2345209f05ae278 [08/13] wifi: ath12k: add AHB driver support for IPQ5332 commit: 6cee30f0da751284662affaa0d7fc567cdd65f48 [09/13] wifi: ath12k: Power up root PD commit: 10a355ba6238e13d196be2f226a59f7886d7b5bd [10/13] wifi: ath12k: Register various userPD interrupts and save SMEM entries commit: f73e089745a000b6eb99457f71b47dc862ab221a [11/13] wifi: ath12k: Power up userPD commit: c01d5cc9b9fe2673885db738ec8d2e01de169b92 [12/13] wifi: ath12k: Power down userPD commit: 881edc164071c2da3504b72fdc08ca8f1b915fdb [13/13] wifi: ath12k: enable ath12k AHB support commit: c0dd3f4f70918cbcdd8da611811036a91b7dce33 Best regards,
Currently, Ath12k driver only supports WiFi devices that are based on PCI bus. New Ath12k device IPQ5332 is based on AHB bus. Hence, add Ath12k AHB support for IPQ5332. IPQ5332 is IEEE802.11be 2 GHz 2x2 Wifi device. To bring-up IPQ5332 device: - Add hardware parameters for IPQ5332. - CE register address space in IPQ5332 is separate from WCSS register space. Hence, add logic to remap CE register address. - Add support for fixed QMI firmware memory for IPQ5332. - Support userPD handling for WCSS secure PIL driver to enable ath12k AHB support. NOTE: The working upstream DTS changes for this series have been posted as a separate series. [PATCH v2] arm64: dts: qcom: add wifi node for IPQ5332 based RDP441 --- Changes in v12: - Fixed warning reported by kernel test robot "cast to smaller integer type 'enum ath12k_hw_rev' from 'const void *'" - Removed tag "Reviewed-by: Vasanthakumar Thiagarajan", in the updated patch [08/13] wifi: ath12k: add AHB driver support for IPQ5332 - Link to v11: https://lore.kernel.org/all/20250317204639.1864742-1-quic_rajkbhag@quicinc.com/ Changes in v11: - Updated Kconfig for ATH12k AHB. - Replaced the API devm_ioremap_wc() with devm_memremap to fix ath12k-check warning: "warning: cast removes address space '__iomem' of expression" - Rebased on latest ToT. - Removed tag "Reviewed-by: Vasanthakumar Thiagarajan", in the updated patch [11/13] wifi: ath12k: Power up userPD - Link to v10: https://lore.kernel.org/all/20250317154150.1361364-1-quic_rajkbhag@quicinc.com/ Changes in v10: - Removed config dependency of QCOM_Q6V5_WCSS_SEC for Ath12k AHB. - Removed tag "Reviewed-by: Vasanthakumar Thiagarajan", in the updated patch [13/13] wifi: ath12k: enable ath12k AHB support - Link to v9: https://lore.kernel.org/all/20250305185501.2400888-1-quic_rajkbhag@quicinc.com/ Changes in v9: - Fixed memory leak in ath12k_ahb_probe(). - Removed tag "Reviewed-by: Vasanthakumar Thiagarajan", in the updated patch [08/13] wifi: ath12k: add AHB driver support for IPQ5332 - Link to v8: https://lore.kernel.org/all/20250228184214.337119-1-quic_rajkbhag@quicinc.com/ Changes in v8: - Fixed format specifiers warning reported by kernel test robot in patch [PATCH v6 07/13] wifi: ath12k: add support for fixed QMI firmware memory - Link to v7: https://lore.kernel.org/all/20250227191034.1949954-1-quic_rajkbhag@quicinc.com/ Changes in v7: - DT binding: DT property 'qcom,ath12k-calibration-variant' renamed to 'qcom,calibration-variant'. - Link to v6: https://lore.kernel.org/all/20250225064834.2002499-1-quic_rajkbhag@quicinc.com/ Changes in v6: - DT binding: binding doc renamed from qcom,ath12k-ahb.yaml to qcom,ipq5332-wifi.yaml. - DT binding: rephrased memory-region description. - DT binding: dropped description for memory-region-names. - DT binding: updated maintainers in binding doc. - The API ath12k_core_get_reserved_mem_by_name() has been simplified and renamed to ath12k_core_get_reserved_mem() - Removed unnecessary NULL check in devm_clk_get() error handling. - Dropped all ath12k_ahb_clock_* wrappers for single clock. - Removed shutdown callback for the ath12k AHB driver. - Reference count leak handled for rproc and rproc phandle. - Link to v5: https://lore.kernel.org/all/20250130043508.1885026-1-quic_rajkbhag@quicinc.com/ Changes in v5: - DT binding: Added `memory-region-names` property to address undocumented ABIs. - DT binding: Added four complete items to `memory-region`, required by ath12k firmware. - All calls to `of_find_node_by_name()` are removed. Introduced helper function `ath12k_core_get_reserved_mem_by_name()` to get the reserved memory by name. - Removed unused include headers. - Removed error prints for impossible scenarios. - Used proper phandle API `of_parse_phandle()` to read `qcom,rproc`. - Used `dev_err_probe()` API for logging errors wherever applicable. - Changed hardware parameter `needs_m3_fw` to `enum ath12k_m3_fw_loaders`. - Changed hardware parameter `bdf_addr` to `bdf_addr_offset` to store the offset for BDF memory from the q6-memory as base. - Link to v4: https://lore.kernel.org/all/20241210074159.2637933-1-quic_rajkbhag@quicinc.com/ Changes in v4: - Missed to include some review list in v3. Hence sending v4 with all review list as per - scripts/get_maintainers.pl - Link to v3: https://lore.kernel.org/all/20241209165644.1680167-1-quic_rajkbhag@quicinc.com/ Changes in v3: - DT binding: clock name changed from gcc_xo_clk to xo. - DT binding: Upper constraint added for memory-region property. - DT binding: The description for "qcom,rproc" phandle updated to represent the hardware aspect. - DT binding: Added property qcom,ath12k-calibration-variant. - Squashed patch[2/22] to patch[8/22] of v2 into a single patch. - Patch reordering is done. - The hardware parameter "m3_fw_support" renamed to "needs_m3_fw". - CMEM remap and CMEM register handling are dropped. CMEM registers are accessed within WCSS register space (ab->mem). - The devm APIs are used for interrupts handling. - Logic updated in ath12k_ahb_map_service_to_pipe(). - Dependency path series from other subsystem are dropped. - Link to v2: https://lore.kernel.org/all/20241015182637.955753-1-quic_rajkbhag@quicinc.com/ Changes in v2: - "qcom,board_id" property is dropped. This is not the direct dependency for Ath12k AHB support, hence it can be taken up separately. - "qcom,bdf-addr" property is dropped in device-tree and moved to ath12k driver. - Currently we have only one compatible enum (qcom,ipq5332-wifi), hence conditional if() check for defining the binding is removed. - "reserved-memory" node is dropped from example DTS. - "status" property is dropped in wifi node of example DTS. - Integrated the “Support userPD handling for WCSS secure PIL driver” patch series with the Ath12k AHB bring-up patch. - Removed the RFC tag as all dependency patch series are now compilable. - Link to v1: https://lore.kernel.org/all/20240814094323.3927603-1-quic_rajkbhag@quicinc.com/ --- Balamurugan S (6): wifi: ath12k: fix incorrect CE addresses wifi: ath12k: add ath12k_hw_params for IPQ5332 wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332 wifi: ath12k: Add hw_params to remap CE register space for IPQ5332 wifi: ath12k: add AHB driver support for IPQ5332 wifi: ath12k: enable ath12k AHB support P Praneesh (1): wifi: ath12k: refactor ath12k_hw_regs structure Raj Kumar Bhagat (2): dt-bindings: net: wireless: describe the ath12k AHB module for IPQ5332 wifi: ath12k: add support for fixed QMI firmware memory Sowmiya Sree Elavalagan (4): wifi: ath12k: Power up root PD wifi: ath12k: Register various userPD interrupts and save SMEM entries wifi: ath12k: Power up userPD wifi: ath12k: Power down userPD .../bindings/net/wireless/qcom,ipq5332-wifi.yaml | 315 ++++++ drivers/net/wireless/ath/ath12k/Kconfig | 8 + drivers/net/wireless/ath/ath12k/Makefile | 1 + drivers/net/wireless/ath/ath12k/ahb.c | 1156 ++++++++++++++++++++ drivers/net/wireless/ath/ath12k/ahb.h | 80 ++ drivers/net/wireless/ath/ath12k/ce.c | 92 +- drivers/net/wireless/ath/ath12k/ce.h | 18 +- drivers/net/wireless/ath/ath12k/core.c | 60 +- drivers/net/wireless/ath/ath12k/core.h | 14 +- drivers/net/wireless/ath/ath12k/hal.c | 84 +- drivers/net/wireless/ath/ath12k/hal.h | 68 +- drivers/net/wireless/ath/ath12k/hw.c | 479 +++++++- drivers/net/wireless/ath/ath12k/hw.h | 22 +- drivers/net/wireless/ath/ath12k/pci.c | 10 +- drivers/net/wireless/ath/ath12k/pci.h | 4 +- drivers/net/wireless/ath/ath12k/qmi.c | 210 +++- drivers/net/wireless/ath/ath12k/qmi.h | 3 +- 17 files changed, 2507 insertions(+), 117 deletions(-) --- base-commit: b6f473c96421b8b451a8df8ccb620bcd71d4b3f4 change-id: 20250321-ath12k-ahb-e5d8a4dfc742