mbox series

[0/2] dt-bindings: net: wireless: add wifi node for IPQ5332

Message ID 20250128091012.2574478-1-quic_rajkbhag@quicinc.com
Headers show
Series dt-bindings: net: wireless: add wifi node for IPQ5332 | expand

Message

Raj Kumar Bhagat Jan. 28, 2025, 9:10 a.m. UTC 
The IPQ5332 has IEEE802.11be 2 GHz 2x2 AHB bus WiFi device. This patch
series:
- Describe IPQ5332 WiFi device for device-tree binding.
- Add IPQ5332 wifi node and required reserved-memory in RDP441.

Depends-On: [PATCH V2 0/2] mailbox: tmel-qmp: Introduce QCOM TMEL QMP mailbox driver
Depends-On: [PATCH V3 0/8] Add new driver for WCSS secure PIL loading
Link: https://lore.kernel.org/lkml/20241231054900.2144961-1-quic_srichara@quicinc.com/
Link: https://lore.kernel.org/lkml/20250107101647.2087358-1-quic_gokulsri@quicinc.com/

NOTE:
The Depends-On series '[PATCH V3 0/8] Add new driver for WCSS secure PIL
loading' do not apply completely on ath/main ToT. One of the patch
(https://lore.kernel.org/lkml/20250107101647.2087358-9-quic_gokulsri@quicinc.com/)
fails to apply. This patch does changes in the file -
arch/arm64/boot/dts/qcom/ipq5424.dtsi, which is in linux-next but not in
ath/main as of now. Hence, skip this particular patch while applying
depenency on ath/main for review.

Raj Kumar Bhagat (2):
  dt-bindings: net: wireless: describe the ath12k AHB module
  arm64: dts: qcom: add wifi node for IPQ5332 based RDP441

 .../net/wireless/qcom,ath12k-ahb.yaml         | 317 ++++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts   |  56 +++-
 arch/arm64/boot/dts/qcom/ipq5332.dtsi         | 106 ++++++
 3 files changed, 478 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml


base-commit: b5aeca2e66899430827b8afcad061201f3b7861b
prerequisite-patch-id: d59a64ae7cc13f19fc6f27f8906c98ff5f97f3b2
prerequisite-patch-id: 6c4774dac182e3cc7fa830c06936e34b2c3f4e21
prerequisite-patch-id: 2ae372ac47365309e9d6a123dc9db69bd0f81cd7
prerequisite-patch-id: 4feb9dd9bfff074118dc0ee327b53a45ddb535bb
prerequisite-patch-id: efdd81a1f3309e3383ed996f3b1ebef8d2680705
prerequisite-patch-id: 2fb2bcb350efe9cb0f85aefa1849fccb5e13ebd7
prerequisite-patch-id: aea510292c2387e214523d6aaff52298f783e342
prerequisite-patch-id: 6ca17cf991617a9c5664b812007547e914f44562
prerequisite-patch-id: 74dc586eab1f42e73d53730084bc38be4677b816

Comments

Raj Kumar Bhagat Jan. 28, 2025, 5:34 p.m. UTC | #1 
On 1/28/2025 3:51 PM, Krzysztof Kozlowski wrote:
> On 28/01/2025 10:29, Raj Kumar Bhagat wrote:
>> On 1/28/2025 2:47 PM, Krzysztof Kozlowski wrote:
>>> On 28/01/2025 10:10, Raj Kumar Bhagat wrote:
>>>> Add device-tree bindings for the ATH12K module found in the IPQ5332
>>>> device.
>>>>
>>>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
>>>> ---
>>>>  .../net/wireless/qcom,ath12k-ahb.yaml         | 317 ++++++++++++++++++
>>>>  1 file changed, 317 insertions(+)
>>>>  create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-ahb.yaml
>>>
>>> It was v4, now v1? So entire previous discussion and feedback is
>>> missing? Go to previous series and implement entire feedback. Then use
>>> proper versioning, proper changelog and make it obvious/understandable
>>> to us, instead of sending v1 after v4 in entirely separate thread.
>>>
>>
>> I was asked to send DTS as a separate series, this is a new series for
>> DTS hence stated with v1.
> 
> 
> But we do not talk about DTS here, but bindings.
> 
> 
>> To address the undocumented ABIs we have changes in dt-binding and hence
> 
> That's v1 so how it could have changes in the first place? Unless this
> is v5?
> 

Sure, I understand your point now.
I shouldn't have sent dt-binding here along with DTS as v1. dt-binding should
go with wireless patch-set in v5.

Let me know your thoughts on the next steps:
1. I will send v5 for 'wifi: ath12k: add Ath12k AHB driver support for IPQ5332'
   along with dt-binding.

2. In a separate series, I will send only DTS changes as v2, considering the
   review comments in this version as v1 for DTS.