mbox series

[v3,0/2] wifi: mac80211/mac80211_hwsim: support MLO CSA test case

Message ID 20240216144621.514385-1-quic_adisi@quicinc.com
Headers show
Series wifi: mac80211/mac80211_hwsim: support MLO CSA test case | expand

Message

Aditya Kumar Singh Feb. 16, 2024, 2:46 p.m. UTC 
Recently MLO CSA is enabled on the stack. Add test infra support in
mac80211_hwsim in order to support basic MLO CSA test case.

Aditya Kumar Singh (2):
  wifi: mac80211: check beacon countdown is complete on per link basis
  wifi: mac80211_hwsim: add support for switch_vif_chanctx callback
---
v3: proper patch in [2/2].

v2: handled all mode cases of channel contexts in [2/2].
---
 drivers/net/wireless/ath/ath10k/mac.c         |  2 +-
 drivers/net/wireless/ath/ath10k/wmi.c         |  2 +-
 drivers/net/wireless/ath/ath11k/mac.c         |  2 +-
 drivers/net/wireless/ath/ath9k/beacon.c       |  2 +-
 .../net/wireless/ath/ath9k/htc_drv_beacon.c   |  2 +-
 .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c |  2 +-
 .../wireless/intel/iwlwifi/mvm/time-event.c   |  2 +-
 drivers/net/wireless/mediatek/mt76/mac80211.c |  4 +-
 .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c |  2 +-
 drivers/net/wireless/virtual/mac80211_hwsim.c | 46 ++++++++++++++++++-
 include/net/mac80211.h                        |  4 +-
 net/mac80211/tx.c                             | 14 +++++-
 12 files changed, 69 insertions(+), 15 deletions(-)


base-commit: 42ffccd0a36e099dea3d3272c5d62a0454ded1f0

Comments

Johannes Berg Feb. 21, 2024, 10:08 a.m. UTC | #1 
Hi Aditya,

> Recently MLO CSA is enabled on the stack. Add test infra support in
> mac80211_hwsim in order to support basic MLO CSA test case.
> 

Can't apply this right now as we're pushing wireless-next up to net-
next, but looks fine to me. I'll probably drop a 'return -EINVAL' on the
warning case, but no need to resend for that.

I also wanted to ask though if this needed any hostapd changes?

And I guess for real multi-link we need the CSA update things we've been
discussing, I'm guessing you're not going to want to work on that in
either hostapd or kernel since the ath12k firmware handles it all,
right?

Thanks,
johannes
Aditya Kumar Singh Feb. 21, 2024, 11:27 a.m. UTC | #2 
On 2/21/24 15:38, Johannes Berg wrote:
> Hi Aditya,
> 
>> Recently MLO CSA is enabled on the stack. Add test infra support in
>> mac80211_hwsim in order to support basic MLO CSA test case.
>>
> 
> Can't apply this right now as we're pushing wireless-next up to net-
> next, but looks fine to me. I'll probably drop a 'return -EINVAL' on the
> warning case, but no need to resend for that.
> 

Sure, thanks.

> I also wanted to ask though if this needed any hostapd changes?

Yes there is hostapd test case to validate MLO CSA. Will get those for 
review to Jouni soon.

> And I guess for real multi-link we need the CSA update things we've been
> discussing, I'm guessing you're not going to want to work on that in
> either hostapd or kernel since the ath12k firmware handles it all,
> right?
> 
Yeah at least template update for partner links, not really inclined 
there but I like the idea of controlling it via some flag as you 
suggested so that driver can choose. Currently checking with team 
internally on how to do that. We'll get back soon :) We do have some 
points to add to the discussion thread, will send that as well.
Aditya Kumar Singh March 8, 2024, 4:40 a.m. UTC | #3 
On 2/21/24 15:38, Johannes Berg wrote:
> I also wanted to ask though if this needed any hostapd changes?

Here you go - "tests: Add basic MLO CSA test case"
(https://patchwork.ozlabs.org/project/hostap/patch/20240308043508.14853-1-quic_adisi@quicinc.com/)

Sorry, got little bit delayed :)