mbox series

[0/2] wifi: cfg80211/ath12k: Add support to rx retry stats

Message ID 20240212121616.3683197-1-quic_haric@quicinc.com
Headers show
Series wifi: cfg80211/ath12k: Add support to rx retry stats | expand

Message

Hari Chandrakanthan Feb. 12, 2024, 12:16 p.m. UTC 
This patch series adds support to count station level rx retries.

wifi: cfg80211: Add support to rx retry stats
wifi: ath12k: Add support to rx retry stats

Tested-on: QCN9274 hw1.0 PCI WLAN.WBE.1.2.1-00148-QCAHKSWPL_SILICONZ-1

Hari Chandrakanthan (2):
  wifi: cfg80211: Add support to rx retry stats
  wifi: ath12k: Add support to rx retry stats

 drivers/net/wireless/ath/ath12k/core.h   | 1 +
 drivers/net/wireless/ath/ath12k/dp_mon.c | 7 +++++++
 drivers/net/wireless/ath/ath12k/hal_rx.h | 7 ++++++-
 drivers/net/wireless/ath/ath12k/mac.c    | 3 +++
 include/net/cfg80211.h                   | 2 ++
 include/uapi/linux/nl80211.h             | 3 +++
 net/wireless/nl80211.c                   | 1 +
 7 files changed, 23 insertions(+), 1 deletion(-)

Comments

Hari Chandrakanthan Feb. 25, 2024, 2:34 p.m. UTC | #1 
On 2/12/2024 6:25 PM, Johannes Berg wrote:
> On Mon, 2024-02-12 at 17:46 +0530, Hari Chandrakanthan wrote:
>> This patch series adds support to count station level rx retries.
>>
>> wifi: cfg80211: Add support to rx retry stats
>> wifi: ath12k: Add support to rx retry stats
>>
>> Tested-on: QCN9274 hw1.0 PCI WLAN.WBE.1.2.1-00148-QCAHKSWPL_SILICONZ-1
>>
>> Hari Chandrakanthan (2):
>>    wifi: cfg80211: Add support to rx retry stats
>>    wifi: ath12k: Add support to rx retry stats
> There's trivial work here to expose them from mac80211, so please do
> that. Also not entirely sure then why you need it in ath12k, but perhaps
> if it's already done header conversion?
>
> johannes

When RX_FLAG_8023 is set, the rx skb contains 802.3 header.
Also the flag member(u32) in struct ieee80211_rx_status is also completely
utilized. can we extend it to u64 and use a bit in the u64 to indicate 
that retry bit
is set in 802.11 header when rx decap is offloaded?