| Message ID | 20231122063932.10321-1-quic_tamizhr@quicinc.com |
|---|---|
| Headers | show |
| Series | wifi: ath12k: Remove unsupported and unused ring configurations | expand |
Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> writes: > Currently in driver doing memory allocation for tx_monitor, tcl_cmd_ring > and tcl_status ring. Here driver support for tx_monitor mode is not > there and memory for tcl_cmd and tcl_status rings are allocated by > firmware and it uses that memory instead of host allocated. So avoid > these unused ring setup configuration. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Tamizh Chelvam Raja (3): > wifi: ath12k: fix calling correct function for rx monitor mode > wifi: ath12k: Remove unsupported tx monitor handling > wifi: ath12k: Remove unused tcl_*_ring configuration I had several conflict, please double check: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=cfb7ae2dc5d32206d6978625bac055e1f431f450 https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=d9e193e606e87fc4da445c1aed12113d2ae72151 https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=23c88b95ce6a67eb422ab858e22c90312028b69d
Kalle Valo <kvalo@kernel.org> writes: > Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> writes: > >> Currently in driver doing memory allocation for tx_monitor, tcl_cmd_ring >> and tcl_status ring. Here driver support for tx_monitor mode is not >> there and memory for tcl_cmd and tcl_status rings are allocated by >> firmware and it uses that memory instead of host allocated. So avoid >> these unused ring setup configuration. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> >> Tamizh Chelvam Raja (3): >> wifi: ath12k: fix calling correct function for rx monitor mode >> wifi: ath12k: Remove unsupported tx monitor handling >> wifi: ath12k: Remove unused tcl_*_ring configuration > > I had several conflict, please double check: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=cfb7ae2dc5d32206d6978625bac055e1f431f450 > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=d9e193e606e87fc4da445c1aed12113d2ae72151 > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=23c88b95ce6a67eb422ab858e22c90312028b69d Actually I see a new warning with WCN7850. I don't know if I caused it while fixing the conflicts, or it was there originally, but anyway please fix this and submit v2. [ 5806.723781] INFO: trying to register non-static key. [ 5806.723837] The code is fine but needs lockdep annotation, or maybe [ 5806.723869] you didn't initialize this object before use? [ 5806.723900] turning off the locking correctness validator. [ 5806.723933] CPU: 6 PID: 4327 Comm: rmmod Not tainted 6.7.0-wt-ath+ #1232 [ 5806.723968] Hardware name: Intel(R) Client Systems NUC8i7HVK/NUC8i7HVB, BIOS HNKBLi70.86A.0067.2021.0528.1339 05/28/2021 [ 5806.724000] Call Trace: [ 5806.724030] <TASK> [ 5806.724061] dump_stack_lvl+0x5c/0xc0 [ 5806.724100] dump_stack+0x10/0x20 [ 5806.724135] register_lock_class+0x123c/0x19c0 [ 5806.724171] ? is_dynamic_key+0x230/0x230 [ 5806.724203] ? lock_contended+0x290/0x290 [ 5806.724235] __lock_acquire+0x95/0x1bb0 [ 5806.724267] ? kasan_quarantine_put+0x106/0x240 [ 5806.724299] lock_acquire+0x1bc/0x530 [ 5806.724330] ? ath12k_dp_rxdma_mon_buf_ring_free.isra.0+0x8e/0x2d0 [ath12k] [ 5806.724382] ? lock_sync+0x1a0/0x1a0 [ 5806.724412] ? reacquire_held_locks+0x4d0/0x4d0 [ 5806.724443] ? __local_bh_enable_ip+0xa5/0x120 [ 5806.724473] ? __this_cpu_preempt_check+0x13/0x20 [ 5806.724504] ? lockdep_hardirqs_on+0x7e/0x100 [ 5806.724534] _raw_spin_lock_bh+0x36/0x70 [ 5806.724565] ? ath12k_dp_rxdma_mon_buf_ring_free.isra.0+0x8e/0x2d0 [ath12k] [ 5806.724614] ath12k_dp_rxdma_mon_buf_ring_free.isra.0+0x8e/0x2d0 [ath12k] [ 5806.724664] ? ath12k_dp_rx_link_desc_return.isra.0+0xf0/0xf0 [ath12k] [ 5806.724713] ? dma_free_attrs+0xef/0x130 [ 5806.724746] ath12k_dp_rx_free+0x234/0x2e0 [ath12k] [ 5806.724796] ath12k_dp_free+0x32b/0x430 [ath12k] [ 5806.724847] ath12k_core_deinit+0xe0/0x130 [ath12k] [ 5806.724893] ath12k_pci_remove+0xad/0x1b0 [ath12k] [ 5806.724943] pci_device_remove+0x93/0x1b0 [ 5806.724975] device_remove+0xbf/0x150 [ 5806.725007] device_release_driver_internal+0x3c3/0x580 [ 5806.725037] ? __kasan_check_read+0x11/0x20 [ 5806.725069] driver_detach+0xc4/0x190 [ 5806.725101] bus_remove_driver+0x130/0x2a0 [ 5806.725133] driver_unregister+0x68/0x90 [ 5806.725166] pci_unregister_driver+0x24/0x240 [ 5806.725198] ? find_module_all+0x13e/0x1c0 [ 5806.725229] ath12k_pci_exit+0x10/0x20 [ath12k] [ 5806.725277] __do_sys_delete_module+0x32d/0x540 [ 5806.725306] ? module_flags+0x300/0x300 [ 5806.725336] ? kmem_cache_free+0x306/0x330 [ 5806.725367] ? __fput+0x404/0xa50 [ 5806.725398] ? syscall_enter_from_user_mode+0x20/0x50 [ 5806.725428] ? __this_cpu_preempt_check+0x13/0x20 [ 5806.725458] __x64_sys_delete_module+0x4f/0x70 [ 5806.725487] do_syscall_64+0x3c/0xe0 [ 5806.725518] entry_SYSCALL_64_after_hwframe+0x46/0x4e [ 5806.725548] RIP: 0033:0x7f0d24d7bc8b [ 5806.725581] Code: 73 01 c3 48 8b 0d 05 c2 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d d5 c1 0c 00 f7 d8 64 89 01 48 [ 5806.725613] RSP: 002b:00007ffdf5aa4de8 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0 [ 5806.725647] RAX: ffffffffffffffda RBX: 000055e1720b77e0 RCX: 00007f0d24d7bc8b [ 5806.725678] RDX: 000000000000000a RSI: 0000000000000800 RDI: 000055e1720b7848 [ 5806.725710] RBP: 00007ffdf5aa4e48 R08: 0000000000000000 R09: 0000000000000000 [ 5806.725740] R10: 00007f0d24df7ac0 R11: 0000000000000206 R12: 00007ffdf5aa5020 [ 5806.725774] R13: 00007ffdf5aa6ebf R14: 000055e1720b62a0 R15: 000055e1720b77e0 [ 5806.725808] </TASK>