| Message ID | 20230527082939.11206-1-pkshih@realtek.com |
|---|---|
| Headers | show |
| Series | wifi: rtw88/89: add PS calculation to repair PS mode | expand |
On 5/27/23 03:29, Ping-Ke Shih wrote: > The commit 28977e790b5d ("wifi: mac80211: skip powersave recalc if driver SUPPORTS_DYNAMIC_PS") > introduced by kernel 5.20 will skip to recalculate IEEE80211_CONF_PS > of hw->conf.flags if driver sets SUPPORTS_DYNAMIC_PS. > > Since this problem was happened since 5.20, patches 1/3 and 2/3 should be > applied to kernel 6.1+. > > Patch 3/3 is to remove redundant/unnecessary check, so this can be seen as > an independent patch that can go either wireless or wireless-next tree. > Note, I can't combine this into patch 2/3, because this redundant check > is introduced by upcoming kernel 6.4, but patch 2/3 would go kernel 6.1+. > > Ping-Ke Shih (3): > wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS > wifi: rtw89: correct PS calculation for SUPPORTS_DYNAMIC_PS > wifi: rtw89: remove redundant check of entering LPS The patch for rtw88 has been added to the GitHub repo, and fixed the issue. [1] Thanks Ping-Ke, Larry [1] https://github.com/lwfinger/rtw88/issues/129
The commit 28977e790b5d ("wifi: mac80211: skip powersave recalc if driver SUPPORTS_DYNAMIC_PS") introduced by kernel 5.20 will skip to recalculate IEEE80211_CONF_PS of hw->conf.flags if driver sets SUPPORTS_DYNAMIC_PS. Since this problem was happened since 5.20, patches 1/3 and 2/3 should be applied to kernel 6.1+. Patch 3/3 is to remove redundant/unnecessary check, so this can be seen as an independent patch that can go either wireless or wireless-next tree. Note, I can't combine this into patch 2/3, because this redundant check is introduced by upcoming kernel 6.4, but patch 2/3 would go kernel 6.1+. Ping-Ke Shih (3): wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS wifi: rtw89: correct PS calculation for SUPPORTS_DYNAMIC_PS wifi: rtw89: remove redundant check of entering LPS drivers/net/wireless/realtek/rtw88/mac80211.c | 14 +++--- drivers/net/wireless/realtek/rtw88/main.c | 4 +- drivers/net/wireless/realtek/rtw88/ps.c | 43 +++++++++++++++++++ drivers/net/wireless/realtek/rtw88/ps.h | 2 + drivers/net/wireless/realtek/rtw89/core.c | 3 -- drivers/net/wireless/realtek/rtw89/mac80211.c | 15 +++---- drivers/net/wireless/realtek/rtw89/ps.c | 26 +++++++++++ drivers/net/wireless/realtek/rtw89/ps.h | 1 + 8 files changed, 85 insertions(+), 23 deletions(-)