mbox series

[0/2] ath11k: factory test mode support

Message ID 20230213130854.2473-1-quic_rajkbhag@quicinc.com
Headers show
Series ath11k: factory test mode support | expand

Message

Raj Kumar Bhagat Feb. 13, 2023, 1:08 p.m. UTC
Device is booted in factory test mode to calibrate the board.
The commands are sent from a userspace application, which is
sent to firmware using wmi commands. Firmware will send the
response back to the application which stores the calibration
data in caldata.bin file. This file will be loaded when the
device boots up normally next time.

Govindaraj Saminathan (1):
  wifi: ath11k: factory test mode support

Sowmiya Sree Elavalagan (1):
  wifi: ath11k: Allow ath11k to boot without caldata in ftm mode

 drivers/net/wireless/ath/ath11k/ahb.c        |   3 +-
 drivers/net/wireless/ath/ath11k/core.c       |  20 +-
 drivers/net/wireless/ath/ath11k/core.h       |  14 +-
 drivers/net/wireless/ath/ath11k/debug.h      |   2 +
 drivers/net/wireless/ath/ath11k/mac.c        |  13 +-
 drivers/net/wireless/ath/ath11k/pci.c        |   3 +-
 drivers/net/wireless/ath/ath11k/qmi.c        |  10 +-
 drivers/net/wireless/ath/ath11k/testmode.c   | 323 ++++++++++++++++---
 drivers/net/wireless/ath/ath11k/testmode.h   |  21 +-
 drivers/net/wireless/ath/ath11k/testmode_i.h |  19 ++
 drivers/net/wireless/ath/ath11k/wmi.c        |  40 ++-
 drivers/net/wireless/ath/ath11k/wmi.h        |  20 ++
 drivers/net/wireless/ath/ath11k/wow.c        |   3 +-
 13 files changed, 427 insertions(+), 64 deletions(-)


base-commit: ddd8e84e007263f3aa8993f32a3dd4dc8ec0876a

Comments

Vasanthakumar Thiagarajan Feb. 16, 2023, 2:56 p.m. UTC | #1
On 2/13/2023 6:38 PM, Raj Kumar Bhagat wrote:
> Device is booted in factory test mode to calibrate the board.
> The commands are sent from a userspace application, which is
> sent to firmware using wmi commands. Firmware will send the
> response back to the application which stores the calibration
> data in caldata.bin file. This file will be loaded when the
> device boots up normally next time.
> 
> Govindaraj Saminathan (1):
>    wifi: ath11k: factory test mode support
> 
> Sowmiya Sree Elavalagan (1):
>    wifi: ath11k: Allow ath11k to boot without caldata in ftm mode
> 
>   drivers/net/wireless/ath/ath11k/ahb.c        |   3 +-
>   drivers/net/wireless/ath/ath11k/core.c       |  20 +-
>   drivers/net/wireless/ath/ath11k/core.h       |  14 +-
>   drivers/net/wireless/ath/ath11k/debug.h      |   2 +
>   drivers/net/wireless/ath/ath11k/mac.c        |  13 +-
>   drivers/net/wireless/ath/ath11k/pci.c        |   3 +-
>   drivers/net/wireless/ath/ath11k/qmi.c        |  10 +-
>   drivers/net/wireless/ath/ath11k/testmode.c   | 323 ++++++++++++++++---
>   drivers/net/wireless/ath/ath11k/testmode.h   |  21 +-
>   drivers/net/wireless/ath/ath11k/testmode_i.h |  19 ++
>   drivers/net/wireless/ath/ath11k/wmi.c        |  40 ++-
>   drivers/net/wireless/ath/ath11k/wmi.h        |  20 ++
>   drivers/net/wireless/ath/ath11k/wow.c        |   3 +-
>   13 files changed, 427 insertions(+), 64 deletions(-)
> 
> 
> base-commit: ddd8e84e007263f3aa8993f32a3dd4dc8ec0876a

Series LGTM
Kalle Valo March 13, 2023, 12:21 p.m. UTC | #2
Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:

> Device is booted in factory test mode to calibrate the board.
> The commands are sent from a userspace application, which is
> sent to firmware using wmi commands. Firmware will send the
> response back to the application which stores the calibration
> data in caldata.bin file. This file will be loaded when the
> device boots up normally next time.
>
> Govindaraj Saminathan (1):
>   wifi: ath11k: factory test mode support
>
> Sowmiya Sree Elavalagan (1):
>   wifi: ath11k: Allow ath11k to boot without caldata in ftm mode

While reviewing the patches I made quite a few style cleanup to patches
(too many to list):

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=4a5ca29c396ace5c46b208a8c15a3ba53eabaddd

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=ba74c7478f5d15ce38e609b9ad4810db7511a3dd

I only compile tested them. Please use these as the baseline for v2.
Raj Kumar Bhagat March 28, 2023, 4:46 a.m. UTC | #3
On 3/13/2023 5:51 PM, Kalle Valo wrote:
> Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:
> 
>> Device is booted in factory test mode to calibrate the board.
>> The commands are sent from a userspace application, which is
>> sent to firmware using wmi commands. Firmware will send the
>> response back to the application which stores the calibration
>> data in caldata.bin file. This file will be loaded when the
>> device boots up normally next time.
>>
>> Govindaraj Saminathan (1):
>>   wifi: ath11k: factory test mode support
>>
>> Sowmiya Sree Elavalagan (1):
>>   wifi: ath11k: Allow ath11k to boot without caldata in ftm mode
> 
> While reviewing the patches I made quite a few style cleanup to patches
> (too many to list):
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=4a5ca29c396ace5c46b208a8c15a3ba53eabaddd
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=ba74c7478f5d15ce38e609b9ad4810db7511a3dd
> 
> I only compile tested them. Please use these as the baseline for v2.
> 
Hi Kalle,

Unable to get the baseline patch for v2 from the above link. Getting the
below error with the link:
Bad commit reference: 4a5ca29c396ace5c46b208a8c15a3ba53eabaddd
Kalle Valo May 12, 2023, 9:05 a.m. UTC | #4
Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:

> On 3/13/2023 5:51 PM, Kalle Valo wrote:
>
>> Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:
>> 
>>> Device is booted in factory test mode to calibrate the board.
>>> The commands are sent from a userspace application, which is
>>> sent to firmware using wmi commands. Firmware will send the
>>> response back to the application which stores the calibration
>>> data in caldata.bin file. This file will be loaded when the
>>> device boots up normally next time.
>>>
>>> Govindaraj Saminathan (1):
>>>   wifi: ath11k: factory test mode support
>>>
>>> Sowmiya Sree Elavalagan (1):
>>>   wifi: ath11k: Allow ath11k to boot without caldata in ftm mode
>> 
>> While reviewing the patches I made quite a few style cleanup to patches
>> (too many to list):
>> 
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=4a5ca29c396ace5c46b208a8c15a3ba53eabaddd
>> 
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=ba74c7478f5d15ce38e609b9ad4810db7511a3dd
>> 
>> I only compile tested them. Please use these as the baseline for v2.
>> 
> Hi Kalle,
>
> Unable to get the baseline patch for v2 from the above link. Getting the
> below error with the link:
> Bad commit reference: 4a5ca29c396ace5c46b208a8c15a3ba53eabaddd

I now pushed them again:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f3d1f7ae115e12108ba7d7fa0ea6374b9e28869c

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=229ea354bdd24bf3c33c9447674fab8d609e24a2