From patchwork Sun Feb 12 14:52:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fedor Pchelkin X-Patchwork-Id: 653950 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0381C05027 for ; Sun, 12 Feb 2023 14:53:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229463AbjBLOw7 (ORCPT ); Sun, 12 Feb 2023 09:52:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbjBLOw5 (ORCPT ); Sun, 12 Feb 2023 09:52:57 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FBAD3A9A; Sun, 12 Feb 2023 06:52:56 -0800 (PST) Received: from fpc.. (unknown [46.242.14.200]) by mail.ispras.ru (Postfix) with ESMTPSA id 2D4C140D403D; Sun, 12 Feb 2023 14:52:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 2D4C140D403D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1676213574; bh=1BOm5AF/SVPewGAsff3Q3TCQ4aozkAkOLj7Mo396mAE=; h=From:To:Cc:Subject:Date:From; b=HWiNqTf6viB3SkNSJIpMeGSyqyOZnFh1lrs096bNFBD4OwxPj6tOY93Yue5jmyRjs 2Y762XhvHCYPEiYeGGLaRb49aeFK8jYbY+yCaLywabHsLSgMc28w2qaQP3U21Avm2c fXLttrcQlZhMr9RZB7YVSGSSuDHjTHj2AjMEQOMo= From: Fedor Pchelkin To: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Fedor Pchelkin , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "John W. Linville" , Vasanthakumar Thiagarajan , Senthil Balasubramanian , Sujith , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: [PATCH 0/1] wifi: ath9k: hif_usb: fix memory leak of remain_skbs Date: Sun, 12 Feb 2023 17:52:37 +0300 Message-Id: <20230212145238.123055-1-pchelkin@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hello, the problem is described in the following patch. Some remarks: I'm not quite sure if the function proposed in the patch should be placed somewhere else in the code... The patch now calls it during device deinitialization after urbs deallocation, and I suppose the interrupt callback ath9k_hif_usb_rx_stream() not to be executed during/after that period (in this case the leak would still remain, but I couldn't reproduce this particular case). Maybe the function freeing remain_skbs should be placed right before calling 'kfree(hif_dev)'? The patch is made on top of [1] master branch. [1] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/ --- Regards, Fedor