| Message ID | 20221206114609.2006175-1-yangyingliang@huawei.com |
|---|---|
| Headers | show |
| Series | libertas/libertas_tf: don't call kfree_skb() under spin_lock_irqsave() | expand |
Hi, thank you for your information. On our website you can find email addresses of companies and people. https://www.skymem.info In short, it’s like Google for emails. Best regards, Robert, Skymem team On Tue, Dec 6, 2022 at 12:49 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > > It is not allowed to call kfree_skb() from hardware interrupt > context or with interrupts being disabled. So replace kfree_skb() > with dev_kfree_skb_irq() under spin_lock_irqsave(). > > Fixes: d2e7b3425c47 ("libertas: disable functionality when interface is down") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/wireless/marvell/libertas/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c > index 8f5220cee112..f42d28d99763 100644 > --- a/drivers/net/wireless/marvell/libertas/main.c > +++ b/drivers/net/wireless/marvell/libertas/main.c > @@ -216,7 +216,7 @@ int lbs_stop_iface(struct lbs_private *priv) > > spin_lock_irqsave(&priv->driver_lock, flags); > priv->iface_running = false; > - kfree_skb(priv->currenttxskb); > + dev_kfree_skb_irq(priv->currenttxskb); > priv->currenttxskb = NULL; > priv->tx_pending_len = 0; > spin_unlock_irqrestore(&priv->driver_lock, flags); > -- > 2.25.1 > > > _______________________________________________ > libertas-dev mailing list > libertas-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/libertas-dev
It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. As the comment of dev_kfree_skb_irq() says, kfree_skb() can be replaced with dev_kfree_skb_irq() under spin_lock_irqsave(). Yang Yingliang (4): libertas_tf: don't call kfree_skb() under spin_lock_irqsave() libertas: don't call kfree_skb() under spin_lock_irqsave() in process_cmdrequest() libertas: don't call kfree_skb() under spin_lock_irqsave() in lbs_stop_iface() libertas: don't call kfree_skb() under spin_lock_irqsave() in lbs_mac_event_disconnected() drivers/net/wireless/marvell/libertas/cmdresp.c | 2 +- drivers/net/wireless/marvell/libertas/if_usb.c | 2 +- drivers/net/wireless/marvell/libertas/main.c | 2 +- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)