mbox series

[0/4] ath11k: add support for 256 bitmap in Block ack and duration based RTS threshold

Message ID 20201009021811.18584-1-pradeepc@codeaurora.org
Headers show
Series ath11k: add support for 256 bitmap in Block ack and duration based RTS threshold | expand

Message

Pradeep Kumar Chitrapu Oct. 9, 2020, 2:18 a.m. UTC 
This series adds support for the configuration of following in
HE capable ath11k APs:
1. TXOP duration based RTS threshold using HE Operation parameters in
   beacons for AP and mesh modes.
2. BlockAck's bitmap to support upto 256 bits in mesh mode. Without
   this maximum of 64 bits are supported in BlockAck bitmap.

mac80211 patch sets he_support flag for mesh BSS and addresses
previous review comments from https://patchwork.kernel.org/patch/11664077/

Pradeep Kumar Chitrapu (4):
  mac80211: save HE oper info in BSS config for mesh
  ath11k: fix incorrect wmi param for configuring HE operation
  ath11k: support TXOP duration based RTS threshold
  ath11k: mesh: add support for 256 bitmap in blockack frames in 11ax

 drivers/net/wireless/ath/ath11k/mac.c | 40 +++++++++++++++++----------
 drivers/net/wireless/ath/ath11k/wmi.h |  2 +-
 include/net/mac80211.h                |  3 +-
 net/mac80211/mesh.c                   | 30 ++++++++++++++++++++
 4 files changed, 58 insertions(+), 17 deletions(-)


base-commit: ba6ff70a3bb76c1ff440d3a0044b82e97abb648f

Comments

Peter Oh Oct. 19, 2020, 8:29 p.m. UTC | #1 
> +static void
> +ieee80211_mesh_update_bss_params(struct ieee80211_sub_if_data *sdata,
> +				 u8 *ie, u8 ie_len)
> +{
> +	struct ieee80211_supported_band *sband;
> +	const u8 *cap;
> +	const struct ieee80211_he_operation *he_oper = NULL;
> +
> +	sband = ieee80211_get_sband(sdata);
> +	if (!sband)
> +		return;
> +
> +	if (ieee80211_get_he_iftype_cap(sband, NL80211_IFTYPE_MESH_POINT) &&
> +	    !(sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20_NOHT ||
> +	    sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_5 ||
> +	    sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10))
> +		return;

Are you update BSS only for sub-20Mhz?

Shouldn't you remove "!" for 20~160Mhz?


Thanks,

Peter
Pradeep Kumar Chitrapu Oct. 20, 2020, 3:34 p.m. UTC | #2 
>> +	if (ieee80211_get_he_iftype_cap(sband, NL80211_IFTYPE_MESH_POINT) &&

>> +	    !(sdata->vif.bss_conf.chandef.width == 

>> NL80211_CHAN_WIDTH_20_NOHT ||

>> +	    sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_5 ||

>> +	    sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10))

>> +		return;

> 

> Are you update BSS only for sub-20Mhz?

> 

> Shouldn't you remove "!" for 20~160Mhz?

> 

> 

> Thanks,

> 

> Peter

Thanks Peter for the review..Might have been a typo and I missed it..
I will fix this and submit next revision.