From patchwork Thu Sep 10 15:05:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249632 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ecf:0:0:0:0 with SMTP id i15csp825327ilk; Thu, 10 Sep 2020 08:05:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6PT1w7wIx5akbhbPTYHj2lwwrAfdqHkXba6jYf9jgdbiQh7nyts5u1fTF0CJu1qJcRtsW X-Received: by 2002:a05:6830:4a4:: with SMTP id l4mr4047958otd.212.1599750316499; Thu, 10 Sep 2020 08:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599750316; cv=none; d=google.com; s=arc-20160816; b=t0yLhhe7eeyzGLImpo3rXgemdIamYe47iv7ZGb5d3XNXv0WGY2EyDo+EqFjSBLi2bU U2dJ/h39ef/YkzdPL94Wpdi1sl9VljR+OhWoL04rjOZphQ7tvZBUd+sApGyaJ3aGRJtu rvJ16dinTQOmEjHoDVk3Ss2n7fB8VYi7fEiMPKAZS6c+o11M2/oN4MJ0856W4ZH2Hoch wNOqixEp9kVJ9PqvXF5kwRTz4csoyIgUKADFuu303hXJu5JlxwSEtP1BxJz+DiDA6e6s 3qcM6fuAYdhSH2O+jbBOM78E/6H7VVSiNlOaADbzGOxkzrA+2phEkh4gMF6DDW8mcGzI OupA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:dkim-signature; bh=TEBADuL62Ojm2yehfN6rwBpqFAe9X1QN02W9ea8NJH4=; b=ZXOWDrFJ+Xf2qdvmN5Sbi6Tyoau5NkienLeCClodTj+hkYrC4gqfblCGTlj3I1m6Tg PB99j4723zFlCiwLZ7z3Y94YArVMeWi3tuAmhpzBXokCeNTpO7D8mUjJ0pBKUXbddFNU WgBcH1cYaAf7Jr5a0fzyQJZWAfpzbg8BILoSo8/J+P+yI+AAg1IhJn5fW1kwtLIq3UT1 mtMQwa4hBi8KZiKm+Gr9ouC10nL24CpcV0m16CfadqrBXIUpC2zFWQ41IA2Fx4VmKDVp 5/E8JCgUpulF0KKKWk28MwFXIOMtd5tMBlw9BQxV4K1IseBYatdUTTKhLO0I5GbBoI1s DF7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=plNcnHwM; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="FhpAm/mF"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id l11si2976521oig.256.2020.09.10.08.05.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 08:05:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=plNcnHwM; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="FhpAm/mF"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=TEBADuL62Ojm2yehfN6rwBpqFAe9X1QN02W9ea8NJH4=; b=plNcnHwMF66VKgq8tkKbNqL6w5 LvD4RKLjdZTc9iKWigI4y0RIUdQDb8yahlbBVQUHznfMboDK0Snc6qWN+hNlIpN5mXBuE89Qoyt2z FsOjOZ/K/F93DxfVVAeOypvPTz+x48tTA9ee7aE99RU9r4ixO6prrWN2VCUJqM5zwXd0zr02dFU1K 8YBW4pTSg4+VztT2ft5bEskVppQm4EYJwIxq2ngkn2oH059n7TBZscJReZgVj0bkiIYfBneZaxBga s/+pKD0wwJr0GBJS2PMdEDFbmjE8HbwBRuZ3ZToAVWDSB7ADGtCLme4W5Lr8W8XbRiNpClTok9n5E tQnE43ZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGO8O-0007VL-5S; Thu, 10 Sep 2020 15:05:12 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGO8H-0007RN-Jf for wcn36xx@lists.infradead.org; Thu, 10 Sep 2020 15:05:09 +0000 Received: by mail-wm1-x341.google.com with SMTP id a65so355760wme.5 for ; Thu, 10 Sep 2020 08:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mL4mzudrzXf2cUTx9eQ/J+GPxyAkKkLNs3IL5Bs2Jrg=; b=FhpAm/mF2S0ktfsReBCbwmNFlAi5VPzeXlMJMmtmVLby9qk8bR0fJkQEL3UY+s1Np3 vLce65hZUqyLXnzoSKTWZpQxyMN1VhVUmzvlEweZ8cf2lSI3KN9I1ZpXaO3d4V/lI6wE f+LwN9N41+i1LOJFI3g2mMpeNCNhm+f6+oWCsdIX2VSuUPnHUT7LkYVLHUmMtfJ/t0W2 OHIAnJMQUxoxFY3WApy7e7S1CI+PYqxppde+9p6gdoj3IgudYh+feFyVGJRqF0+S+AGs ZEM1KeZjVXGdq4FnZp6m2iTzqIm+itiJ+aBjU6rP9J7wCNNcfmNep9iELlcmAv6ux/yx GVxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mL4mzudrzXf2cUTx9eQ/J+GPxyAkKkLNs3IL5Bs2Jrg=; b=Jqlf7ihcmZK8JfhtCHNx5i8mZIwjKFsLYqDpa5gMSBif5tMReo6psmpEh86T6GSlJz xA6idmo/VvNV6mbEh8X/p7FeVDYySxFOeT6PnrhsQFUt1RZMUfIlk8aB5uz2ArfxqXJe 1lR5RoR29g0gEk8zgzNgV/1Er+XL7QJ4Zt64Ri9+Oc9i1XsN7/ySI1qQE6eCR3A62ibM XVVvWCHLR3LwWjfzxi1O5e53y5b+9/RWlV/t4bmWTOvHUzVYwFLAehnq99rF7g4XeVrX B1syW++a5ickMCWGF9tAmRWeJb0qTqsdCc2dY4We6tyxO8cAukeRKsoZzeLY8PzrQtTi 5M4w== X-Gm-Message-State: AOAM532+ZWjtH8HlUrC8zUaSqikfHAkR+vOQA5LQhV3Js+na4zptoOG1 EigEHgklw/Xc76qAuS/hhnw4NQ== X-Received: by 2002:a7b:c397:: with SMTP id s23mr454417wmj.174.1599750304517; Thu, 10 Sep 2020 08:05:04 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id g8sm3852620wmd.12.2020.09.10.08.05.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 08:05:04 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v5 0/7] wcn36xx: Add a set of helpers to enable VHT parameter passing Date: Thu, 10 Sep 2020 16:05:45 +0100 Message-Id: <20200910150552.2178882-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_110505_677127_4D63D5BD X-CRM114-Status: GOOD ( 16.18 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This series is two in a set of seven to add support for wcn3680 at 802.11ac data-rates. V5: - Fixes -W=1 warning caught in later patches by kernel build robot I'm still declaring these functions standalone for the purposes of granularity and bisectability, a later patch makes them static. V4: - No functional change. Sending out full set again using --base=ath-202009090652 to aid kernel test robot - https://lore.kernel.org/linux-wireless/20200908182437.2870281-1-bryan.odonoghue@linaro.org/T/#t V3: - Enables MU-MIMO bits in wcn36xx_smd_set_sta_vht_params() - Adds a set of helper functions. In the previous set these unused declarations would cause a warning during compile because they were declared static with the intention to add code later on to use them. To resolve that, I do not declare the functions static. Static declaration is done in a later patch after the functions have been used. - There are two good reasons for this: 1. Granularity. I think its important and useful to have a patch per function that clearly sets out what it does and why. 2. Patch size. Declaring seven functions at the time of their first use is not good practice. I think maintaining patch granularity is a good enough reason to not squash these commits down. It is pretty trivial to declare the functions static later on without generating compile warnings in the interregnum. V2: This set makes a series of modifications to enable passing of an extended V1 data-structure to the firmware. A series of of helper functions are added to facilitate the setup. The final step in the process is enabling the extended data-structure parameter passing for the wcn3680 only. Only a firmware that is capable of 80211.ac will accept the larger V1 messages and only after explicitly enabling the DOT11AC firmware feature bit. - No functional difference from V1 for these patches Breaking into smaller chunks to enable easier review/merging V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t Bryan O'Donoghue (7): wcn36xx: Add wcn36xx_set_default_rates_v1 wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_sta_vht_params() wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() wcn36xx: Add wcn36xx_smd_set_bss_vht_params() wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() drivers/net/wireless/ath/wcn36xx/main.c | 8 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 108 +++++++++++++++++++++ drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 1 + 3 files changed, 117 insertions(+) base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69 prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938 -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx