From patchwork Wed Sep 9 15:36:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249479 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp523895ilg; Wed, 9 Sep 2020 08:35:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxY9qwWT4aHJjivrtgiurO7nEWlWUGXL7nXYaDfL22R5Q0Q8U4Gfst2jt0IWq1pErdE1Or5 X-Received: by 2002:a92:d843:: with SMTP id h3mr4390273ilq.286.1599665747742; Wed, 09 Sep 2020 08:35:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599665747; cv=none; d=google.com; s=arc-20160816; b=btdPC4SSW8hzr7312ITGWzxhnDzgEzry2dOu2ep8GBIki+4Lo+skmgL+YYwsMhCtWI d9h7xdSCrjERMiruZtS0yjSj8lRTF9WGJrpwAWRtXZoHdvbodagTb4/sHMv8ox3Vl5wD ktMb5iVw8LKROGF+ycK2S54EdI6WqwStiiZkoWtEsKPE3QTZ5dTD+QdSlvPQPVAMfQxk DjwyVImofrnTGTOrp5G30wjx5vzUepgvdBfcv/xmtkKJG/2jyJDpRJjPFTzQvrp+bTxz ftVt/FU5+LvRFyM7v/UEPUAB1mZR3enaxrEV8RNWCadDUuxe5fccYKt2In89MZLd/vJr I1pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:dkim-signature; bh=n1AiJ63sYzdzEcCkwWgopuDCaAIBn7CKkXoPbM67sp0=; b=RRJYM4v0hMV7DiDe1w3nC5h6MKKNfaIMXaaVip32SXOYEJo/SUwPN60Xuisurs/bs0 knrfA6cQp6mUVqxAGTbl9Xlq2BHmgs1ybN3HejIiWZNxifsNrcCj73ZoYN0O2O+ix9Ob MJnk6QtumXLnobjvUyZAmjmALgVjthAgZAhkSNroYmuV0DMZ3mo3Ll+l09e0cRCTRbSj A38mFoAjxSUJ6SpCf/HwoRiOrAYiruMdC1nX5lLjZqK60XmunG03j7Sbjb5ecf4zbhwM TmImY89iZn4WH6gelS3X46DLkdIOPieOLovkoRxRY/q8XnUZ8j7dkKQ3Q45mlgpzPZEM ivXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=BZxXlKDO; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UnClN4JT; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id o17si2350714iow.102.2020.09.09.08.35.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 08:35:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=BZxXlKDO; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=UnClN4JT; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=n1AiJ63sYzdzEcCkwWgopuDCaAIBn7CKkXoPbM67sp0=; b=BZxXlKDOKV+UGPZeolbgLe9UGn zJgjCTnaPp7vhdcP8+1U4121i6kJlh6zyQUIQr7M2+/9gSb7nJ6MonZyEpDGXa/ZcyfkV30BXNkTc SSiVhImaHYOQw8ZqWZkQUC7ul3mDsdbfL1qzJOkQZvj9u8fYMNg6JAi6g8jj2VeAkJN743dDCccml kDhNz+842/BqQuy25Cgyd2YLmEiCwuoVtZ8b/OnnRtTp7XGqwnLs8WkdENR++LsG472qS6F1osm1g yJ8QJPXLUP/iPY4aJEU8WO5VNqfE/0xZIzDOXq2wg1yiWRXhn4Ox21WpGk/7qHJoSct7r6WMjk+Q+ sn0Tcn6A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG28N-0006Rm-NH; Wed, 09 Sep 2020 15:35:44 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kG28K-0006Qe-SV for wcn36xx@lists.infradead.org; Wed, 09 Sep 2020 15:35:41 +0000 Received: by mail-wm1-x341.google.com with SMTP id a9so2834925wmm.2 for ; Wed, 09 Sep 2020 08:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/OW3OE0n8UmsNmm14ps/mNaK009oeWo9VSNVPySBtug=; b=UnClN4JTf+DCzY7QJnxF/ctP81kbS/rW7iXwz65EMLlKyXeY4WPNvpuy+QOugOkJvA xzk8Nxqq5kHiSArGY1QRG9UxrcIjx/nzrkDiYMfwi/4fCNIt+oOibiqz8x3LVLRzhmPE jBUk4HXMn5VSkS8qmsEYb2sDXXrEOWRJ7geExAeqe+Xfgi8H/bdMkS9Y3BXOZK2zLYmx Kp09eEuyX8rdClw1YFZf4uxhVBID8E9ihB9wd4nIDU3O+Ffq4zuRgtm5eAetp1VAKD1Z rNqhXq7/Hx6duTIAs8Pr+D2CROhnFwdAe8yDVITWK4tnI/VourxlG4wvd8NeyS2z1YFp teWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/OW3OE0n8UmsNmm14ps/mNaK009oeWo9VSNVPySBtug=; b=sZjjZnh4YvvfKZ7ZziMNewmMx2A3GOfmgPSzZX6I75sYv/1GtPMfzHddnStWIooN5N Ekl5HKpEZaMtzy7rT8zNLkgrQp4aYMypaX8uaUh4F0Quuswvc5DlhDBXLpMOxnNobcUw XbmB8E1A+qZWC5uLGk7n0iNNoU8yVy9U9yXmHg3n9hEjjZY+v76StRf3vufR0D5xk+h9 wt1k7f7wj2c2SzvbXC6YzTkyG5HiMMmf/YFa2ZKATnUe/EHCtSKp6qA0E2e4g1rP60WK n6EvILdwjFyYWpgaqnjUwjPrNbRCedskQ9ecr2eb3m4bO0XIUMy+lePJFglU1fA+EESI b7XQ== X-Gm-Message-State: AOAM531WfdVuLa0J7S5Z0aqxjBX7+Acg9gEG+n/KYS1py0O8jV+HcJMo BUSJNK2e9pzqWkyH8QymGDi7yQ== X-Received: by 2002:a1c:40f:: with SMTP id 15mr4299334wme.175.1599665739621; Wed, 09 Sep 2020 08:35:39 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id c18sm4924871wrx.63.2020.09.09.08.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 08:35:39 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v4 0/7] wcn36xx: Tidy up BSS/STA config Date: Wed, 9 Sep 2020 16:36:21 +0100 Message-Id: <20200909153628.2904888-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200909_113541_010505_18A15052 X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This series is three in a set of seven to add support for wcn3680 at 802.11ac data-rates. Both the BSS and STA config paths have redundant/duplicate code. Before adding more code to either it makes sense to reduce/reuse and functionally decompose as much as possible. While not strictly necessary to get the wcn3680/80211.ac functioning in this driver, it seems like a missed opportunity to leave the code as is. Lets reduce down before adding more. V4: - No functional change. Sending out full set again using --base=ath-202009090652 to aid kernel test robot - https://lore.kernel.org/linux-wireless/20200908182455.2870345-1-bryan.odonoghue@linaro.org/T/#t V3: - No functional difference to V2 https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#t - Adds Loic's Reviewed-by as indicated https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#m2256137b97859c8eac26a2836f96db5e82475d3f V2: - Adds a memset to wcn36xx_smd_config_bss_v1() Since we are doing one less kzalloc() we need to make sure we clear out the bss config. V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t Bryan O'Donoghue (7): wcn36xx: Functionally decompose wcn36xx_smd_config_sta() wcn36xx: Move wcn36xx_smd_set_sta_params() inside wcn36xx_smd_config_bss() wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params() wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally wcn36xx: Add wcn36xx_smd_config_bss_v0 wcn36xx: Convert to using wcn36xx_smd_config_bss_v0() wcn36xx: Remove dead code in wcn36xx_smd_config_bss() drivers/net/wireless/ath/wcn36xx/smd.c | 416 ++++++++++++++----------- 1 file changed, 228 insertions(+), 188 deletions(-) base-commit: 160b351d75cb50a0dd2abf9b63e1891935aa9e4a prerequisite-patch-id: 9a4ac7faca179f6594c9b3a115ee69a2da540a69 prerequisite-patch-id: 183286f9c22d1aaa12f356651224e6b337ef1938 prerequisite-patch-id: af468d413daaf8d2aad195fcb43c6e66390d8468 prerequisite-patch-id: 1a7fb93ee5874d2d011409eaed0b4fd764666b9c prerequisite-patch-id: 77cc008b21a650fa7a33c4acad2fb632b09634fd prerequisite-patch-id: 988ae4802971d6895b03b2752122b2be42baf188 prerequisite-patch-id: a3ba2a1963e03e23e86c937cd4cfb649e1b819b2 prerequisite-patch-id: 8a1fe4f63bc80e9a8035aa52356da8c46eab8665 prerequisite-patch-id: d75c1a60d1ede373c1f3eb684bb15c853c88eedc -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx