From patchwork Tue Sep 8 18:24:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 249323 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp4791547ilg; Tue, 8 Sep 2020 11:24:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyHJMgxpByP4gsoF+jEDRZHlHmHIL/VEgvsf6x/VAqPz28zrjCQ5lhjMVfmkWJqFoZ3yXH X-Received: by 2002:a92:8709:: with SMTP id m9mr52018ild.242.1599589454567; Tue, 08 Sep 2020 11:24:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599589454; cv=none; d=google.com; s=arc-20160816; b=Eavb5lMl2qt+P2JF2PGGkNfYx61dxW1uJp8+2TvuzSOY3vg25fedpZ80HouCEkId8Y +0V4LLpKPSReFwMnUTK0s9QSRBydYDX3xGLnqUZz00EmxKRtriV4zb+IVRR3m1FohWlN jkMQA9fnYHzFsYVjBQkCJ/xzstQDn/VRg2zXrMtmDPqlNihdIqmcMfNufpEmX7tgNLQg BqzXu+OM0BS6VAJfYzKQgoMFlUx0+h+gRbr6oUmY+ezt/G9n9TZBibiYOONnXlIp5tq8 2r/sk2RqGy2eq2aB9LBzYwYIOf+qm67XxGYshidSaVkZET46IE09Uct9y+9y6sntzqSq yTUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:dkim-signature; bh=OJ04J33qB8IQ5B26oMBYKy7wh2A7GSkkVfL29S5k3O8=; b=bPJ6NmCjBECLSzwyNbLWHab1RTduTUbODC6NE2c46tFcFVUwFObCaIsiXJHk6lJz4X 3tgOevLo8z/HZBIL9I81SnpMKxkg7mk3DGCvUNGsVO3DGIDerHeIwzdDmF1qkOMQ63n4 IuYmpDasXRld1Up+LqUKN9u3HpU1PLd8qY/EnyA/rcF4ZqVPT4uXm46dCfyZssOTUUGL 0zQ14lIQglCRvu/SYu2CFh8xxYEbHq3AA7+QoNFZCaGcri57uAQJJB364vvhIhPnQ1Gb bsMe/Ao3ud7Qn4rMBalMcl1uZh5NxPp6JKcKijaCBc0mjy/peMO5x5BCtUtoZykqq7E5 D9rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b="s4t/Bn5P"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="i/I97V2n"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id t18si171224ilj.134.2020.09.08.11.24.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:24:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b="s4t/Bn5P"; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b="i/I97V2n"; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=OJ04J33qB8IQ5B26oMBYKy7wh2A7GSkkVfL29S5k3O8=; b=s4t/Bn5PqexrCNqQFuwKs4lNxc 321ff6nY9b1VNUzLlFFr9KOvbifh2WoR4FKuX3H3wlzcubPHjHKIeZSKMdKudRvMtJ9gAc4HsJqkI RcnydXC4r9keQ/nv3yCYub4panoWMLoGoWVn9jUnDePEyXX4wb8Cz+p84vOEoOajpmo4XjD1260q9 +5f0Hzbn0r/+c+WNAGWo84X/lUppJrZTVjRk6AubV/7vd414y47s+/L5g2z8hkjenSZgmlGrAo+zf uRy0vS5zDp2J4/H7z0CUWP4s3lzJ2lgBwVvVvzIiOWufHI4jh2vsLeOmRIJ9HBL/fYO8Nuv3YoiuF 3FvcbkXw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiHr-00057n-H1; Tue, 08 Sep 2020 18:24:11 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFiHp-00056W-8c for wcn36xx@lists.infradead.org; Tue, 08 Sep 2020 18:24:10 +0000 Received: by mail-wr1-x442.google.com with SMTP id w5so207862wrp.8 for ; Tue, 08 Sep 2020 11:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FXRT8WPZIszbUjKzavBItUfnyzFeyxdJUeheAT4v54k=; b=i/I97V2nHsKWo8C1wBzOSpKIZYSl1zoklkERJrnbyYgUd0gSyQrMflUhq3g/p36ohg RDoY82DNAs8+63aMllKIPUrBSGLWTYM0PgiXMsQkh0hoRvI5m8rFQDXpirkQGTqEap9E rhrxg55s68/NWf6pPLYbVgh99QNGkvB//2ceySG75VyggGvdd3My4zynJr8ShCKu9jH+ AT768JPbt8nfVWdcJFbUxm7uRumwvr5OuVtWVPuu0yQfOPhM+myR3FoH9YSDaLBX67XJ ndDwq1w8/b1ao4JKUKwR2oj1o8PzLPIOBbJdnEFzwVIueQbBRibYIixUCT/M0wvqvdC1 oBMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FXRT8WPZIszbUjKzavBItUfnyzFeyxdJUeheAT4v54k=; b=Qz5YO3TdITp3e4F+bLpdw8qNSYiJ5QQcg2jJ5bMwNOOE2B4cO/aYIfj5zNBHVgMTYf /BPkmAlMsbhKRnIvJJkA5IALezNw9dHWXINrBoNuzLuZE/uYFAEEUfT5qPuRT5kAJ9qL KqBV8bydmtivHWLn7Hg9PZ2odLn4YuKByxWBiDf8vazEQ7HkmRyX6PeDeqi/9SPIKKEw QlETo2sDNn0XxY6L7U6G+qzweJzRXs8QTTgp+zU4G9TLT05viAc7WUDql3R3wpa/xhj0 i6/BX2a43HnIHVbShDZSRZhN91qnprrgyaYwttIu3pe8DNs3rK7qQdr8Mu/8mMkjBrgZ 9dVA== X-Gm-Message-State: AOAM533vKJr/lCTVecYRJfygAN08btpM13VHMHjJPkfEdFwXChvBqEbF T62F7I5O6Y5m7YEn2oARO16Mfw== X-Received: by 2002:a5d:44cc:: with SMTP id z12mr922331wrr.189.1599589448324; Tue, 08 Sep 2020 11:24:08 -0700 (PDT) Received: from localhost.localdomain ([176.61.57.127]) by smtp.gmail.com with ESMTPSA id 189sm330439wmb.3.2020.09.08.11.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 11:24:07 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v3 0/7] wcn36xx: Tidy up BSS/STA config Date: Tue, 8 Sep 2020 19:24:48 +0100 Message-Id: <20200908182455.2870345-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_142409_323602_D8D3BE6F X-CRM114-Status: GOOD ( 10.53 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This series is three in a set of seven to add support for wcn3680 at 802.11ac data-rates. Both the BSS and STA config paths have redundant/duplicate code. Before adding more code to either it makes sense to reduce/reuse and functionally decompose as much as possible. While not strictly necessary to get the wcn3680/80211.ac functioning in this driver, it seems like a missed opportunity to leave the code as is. Lets reduce down before adding more. V3: - No functional difference to V2 https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#t - Adds Loic's Reviewed-by as indicated https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#m2256137b97859c8eac26a2836f96db5e82475d3f V2: - Adds a memset to wcn36xx_smd_config_bss_v1() Since we are doing one less kzalloc() we need to make sure we clear out the bss config. V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t Bryan O'Donoghue (7): wcn36xx: Functionally decompose wcn36xx_smd_config_sta() wcn36xx: Move wcn36xx_smd_set_sta_params() inside wcn36xx_smd_config_bss() wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params() wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally wcn36xx: Add wcn36xx_smd_config_bss_v0 wcn36xx: Convert to using wcn36xx_smd_config_bss_v0() wcn36xx: Remove dead code in wcn36xx_smd_config_bss() drivers/net/wireless/ath/wcn36xx/smd.c | 416 ++++++++++++++----------- 1 file changed, 228 insertions(+), 188 deletions(-) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx