From patchwork Sat Aug 29 03:39:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 248687 Delivered-To: patch@linaro.org Received: by 2002:a92:5b9c:0:0:0:0:0 with SMTP id c28csp1602654ilg; Fri, 28 Aug 2020 20:38:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcdulGz4xUM4eZMwjfzZmD7rJ3nj1qq0gG0DNUxDfSNUrXPb0KK8CkDVGksZq7pq5+uEL5 X-Received: by 2002:a05:6602:2c08:: with SMTP id w8mr1510937iov.38.1598672329269; Fri, 28 Aug 2020 20:38:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598672329; cv=none; d=google.com; s=arc-20160816; b=HAJJ7dLFsJWLUGfNzWoxXtn6CM27c5qHre7MAHaHudvt6Bk+VrLhC9SyzlBYkAG2pA tGWSqX/OCSXZ3tckKWB6zDldcwv3T4YcRZYwbqYLgn+AuGzogcQBnB72Z3V75wjnBwzI 1udiR0hhysi/pm7k+6/u9sqrCSZFHpquD49wJiZ/c0vPmQoLPM4IOzyBFca/f2J03a4l 2SIx2FnidiEmZc4uIY0UUl/eKMv03kDyLbH9W+O4N7+OZFtqY7e5leo7a4IGkElhhPcJ MSb4vpmh8nIQLpB0yfVR0U4KfSQsffCU1DHqxn/gwPHhWMj11BKl9Ai63ti8fZ7OiGVz LxbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :dkim-signature:dkim-signature; bh=t2P6CRQpeVvaUZeXU6Du6r9FNlQyqY9zg+QjGenvLrA=; b=FKZmnLFcVv2dwyoXfoGkp2vXDuOKq/5THclK1GUrrkBczmUk/vayqtyfzZZoI6lHeo 1XszDaQiGhFbOd4TYbBA2yPaWdak+NTkSQqXYt0g3DZ7j5rQoThyWUsEehG0dga/GDBx /k1t6V1xQyf2aRN3lkIdg0QBAtGojDuGmDoSK8QE/aipo3mn3ikGsPCyqrZmnPi2UW3C uABesoDw19hnaaFsWG2uFXWy5Z0aaShdftp0H/K5s+nNa/DPzqerK5QuTeav2xB2SZHQ qZAQsct8dhl2cta6ZwU8U0iPkQpMn+yzaYjs7RuYLIfne6YsJyeZV6Qby19K8qhzugMx jCmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=b92+Hvg7; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Szt7SoQf; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from merlin.infradead.org (merlin.infradead.org. [2001:8b0:10b:1231::1]) by mx.google.com with ESMTPS id z25si2078013ioe.103.2020.08.28.20.38.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 20:38:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) client-ip=2001:8b0:10b:1231::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.infradead.org header.s=merlin.20170209 header.b=b92+Hvg7; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Szt7SoQf; spf=pass (google.com: best guess record for domain of wcn36xx-bounces+patch=linaro.org@lists.infradead.org designates 2001:8b0:10b:1231::1 as permitted sender) smtp.mailfrom="wcn36xx-bounces+patch=linaro.org@lists.infradead.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=t2P6CRQpeVvaUZeXU6Du6r9FNlQyqY9zg+QjGenvLrA=; b=b92+Hvg7d1pfI9UoZrsf2v//7g Q+hqVewnWcGNdYR7gqU4DmPYHk0ch0PwXeoan9BmGu5WT/H4gAYRvgoMfycJkY5g08+Fj/f0wRATP 5BZ7CJxmdC0F04buygyaNx1LSX+1K0iB/b6C9ax4LsQJuSfU2aHw41S46NWJL04NQBWcnIPv7BUGR 8djxmgZ6ST27wM9wYuyG2X2IFF2ZsAu5t2shuv6yCxcizPtmRKiy33oh3FjAmwb+r/K5o04OKIfT+ S7Utu/UWfXp8fzMZJogyENw1IQzbm7Yf7a1V1vXSFSs3zBYN91C4QNfkDSvHozfw8d5h2BfpjbkKd salQk6cA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBrhW-0002RY-5a; Sat, 29 Aug 2020 03:38:46 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBrhU-0002QQ-Kc for wcn36xx@lists.infradead.org; Sat, 29 Aug 2020 03:38:45 +0000 Received: by mail-wr1-x441.google.com with SMTP id c15so851972wrs.11 for ; Fri, 28 Aug 2020 20:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i/tDMzToGhn5zkUCIJf+cXavnQyI/guUVXMmCWA+AHU=; b=Szt7SoQfWq5T4YtzuYZmAB+4D8tCwMcyzI/THkSiJ6LG+XRdvXu3CfEaWcBhPErzGm r/r2jPO8uYdt4JUrAZYiSK16aPjHJEyzB5mCcfNo92fEmpb0TY4mHyBo8hoL3uxP5Pd1 7TLrr8BPsdPVbGbp6rgnP5B6NJjDFw49UyeywFh/kLQdtjpSHgctodW+jyHplQhVcVAA Tu3HDyTipbbwwxdysMx3h5NJcQ9pjBXqbLOBsVMEJ/WSiHIhEk4CEeoCyqD6sqU0qolu x7elNaR28H+yyz/FehxaPoG0o7dRB2DMjtAWp7TtnDsTRUN1mvAnSjspeCgYAQ8sIOWL obig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i/tDMzToGhn5zkUCIJf+cXavnQyI/guUVXMmCWA+AHU=; b=mztmgdJ7MWh3a617zA4zhbO155f4UDvJ2mTgihAztWRfZQ9HQCmkGeB4QGDhlWoMiM 5aI3oTXOVrPN8hfR2pi4tLrUvXMb+Z3Z/1jdB4aNcY68OUbrUo/lEu2JoX73MHSb2Ahh RPqyD1XJflPw5poWtfn7llnuQHbYnMwZP4Vuz73STnVusHPxc6Rk9tG1lT44T9NoPtbP SpZKOhZbDc6CgteZ7ZTm2IbsbST5MscwdynDXLsZvGzLDtvWnrAezA3SGywgSSE/dxWM zA6Fyn/j+sgMeZ6pyAEJuZ5W1mCb2b3gzBxMykTTGQPmzCr3D88cz6UoF4lnwv7qvBTO JRbA== X-Gm-Message-State: AOAM531V8EwlHJIDByUof6VlUu2VyN0g2bieeOzsJMuX1xrpYmHDi8u0 swHp/k83Gn0gXAwC+r/SVMDgvA== X-Received: by 2002:adf:80cb:: with SMTP id 69mr1795594wrl.313.1598672323489; Fri, 28 Aug 2020 20:38:43 -0700 (PDT) Received: from localhost.localdomain ([176.61.57.127]) by smtp.gmail.com with ESMTPSA id s20sm1691700wmh.21.2020.08.28.20.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 20:38:43 -0700 (PDT) From: Bryan O'Donoghue To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org Subject: [PATCH v2 0/7] wcn36xx: Tidy up BSS/STA config Date: Sat, 29 Aug 2020 04:39:22 +0100 Message-Id: <20200829033929.2167761-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200828_233844_729725_0F5D4C5F X-CRM114-Status: GOOD ( 10.32 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: wcn36xx@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org Sender: "wcn36xx" Errors-To: wcn36xx-bounces+patch=linaro.org@lists.infradead.org This series is three of a set of five to add support for wcn3680 at 802.11ac data-rates. Both the BSS and STA config paths have redundant/duplicate code and before adding more code to either it makes sense to reduce/reuse and functionally decompose as much as possible. While not strictly necessary to get the wcn3680/80211.ac functioning in this driver, it seems like a missed opportunity to leave the code as is. Lets reduce down before adding more. V2: - Adds a memset to wcn36xx_smd_config_bss_v1() Since we are doing one less kzalloc() we need to make sure we clear out the bss config. V1: https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t Bryan O'Donoghue (7): wcn36xx: Functionally decompose wcn36xx_smd_config_sta() wcn36xx: Move wcn36xx_smd_set_sta_params() inside wcn36xx_smd_config_bss() wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params() wcn36xx: Add wcn36xx_smd_config_bss_v0 wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally wcn36xx: Convert to using wcn36xx_smd_config_bss_v0() wcn36xx: Remove dead code in wcn36xx_smd_config_bss() drivers/net/wireless/ath/wcn36xx/smd.c | 416 ++++++++++++++----------- 1 file changed, 227 insertions(+), 189 deletions(-) -- 2.27.0 _______________________________________________ wcn36xx mailing list wcn36xx@lists.infradead.org http://lists.infradead.org/mailman/listinfo/wcn36xx Reviewed-by: Loic Poulain