From patchwork Wed Aug 26 09:33:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 248375 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:522:0:0:0:0 with SMTP id h2csp4155014ils; Wed, 26 Aug 2020 02:34:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAgh0Dwk/JzuZgqlDjei+WhOI+OEHFLoFRNaWgHj9V16vRHVgWxSvNifZhABp0Tlre2sIi X-Received: by 2002:a17:906:a293:: with SMTP id i19mr867652ejz.523.1598434468728; Wed, 26 Aug 2020 02:34:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598434468; cv=none; d=google.com; s=arc-20160816; b=y6X8GjO2zKucsYvsjGL33rb77WCiK/W2at/e+8kHiatXegYDjLl0wSTuIZMJEoI/Wt RbnAwA4wmouvl9CTDsRZRJcEt2sNiJV8biXNuVI+vgp9YFKEH2Gp7eB7UeqTWOlP1rRj yX4m0WcBxlCE7WFfMT/ccRQQU73JlHm+VIIMnGvrM+wJe8GQ+rPIeTYR8cRqiAX0fNmF +wae4MIlZYHnzsW/+z8ZGAiB9v2d2KkijMnE0tAY0RUfYh8CcPPSAmeIzspCSQiQYwHx p6jRrcDgJFBUHcmOs3FBM9CQ3pQ/rlsZnztpV0zi/VqkVQKJ0ATi1hNMR5JL/1hxHwe5 vaLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Nj39KvvJBDQl5ELAslfY4/i9vvM4QKppfETPhCXArpc=; b=B9wGlCFjXjoD5nxhVBb8uU/1pVoIpi6PGnhAmbf+xl7pvpbQsqeIKsDT1QQiwSEdfB UextOanLlxXtKsnMfQlc1ouAP+6gIqtXg9ItUJjh9+Jm68/ekQC9Z1ytis4X/vmDst0Z ldPMb3EfLqsR7mkylnpY7y8MYloCepAzTp5woWYfkn9xa09b3Bc7vucCmuMIDSWXOtmL Sun0t05wp+EPcptDLSNV5siYuLuQRlbHd/iqdw0lcdfQKxuyZa3IaU6SwmMduDQLMOTe g1MKfRhggPBO4c4zCaiibIu6NG27r2O6EF+HpQSItwQmZ4BRys+zxz7YP/29uNWcKlFs dT7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jVsOQgq3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1209847eja.203.2020.08.26.02.34.28; Wed, 26 Aug 2020 02:34:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jVsOQgq3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728254AbgHZJeZ (ORCPT + 2 others); Wed, 26 Aug 2020 05:34:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728005AbgHZJeG (ORCPT ); Wed, 26 Aug 2020 05:34:06 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C1E0C061574 for ; Wed, 26 Aug 2020 02:34:06 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id z9so1077675wmk.1 for ; Wed, 26 Aug 2020 02:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Nj39KvvJBDQl5ELAslfY4/i9vvM4QKppfETPhCXArpc=; b=jVsOQgq3bmDNN84kXzuXjYV8L219/+agEp0AYrZTWi5mNYBgR3wJWjK+E3NUMNqTSe 3KFmoA6/7YIs9JZpCb74AcRq9O9xaj6fPkyteXmvcuajLsbeghuzoHxVAHPPXeSg2gQO T2GCNNXYeuCb2bro/kdqyOU2+rUESJ8vJX3xsQDV6i6dhGQdBJgDo+knImzjnlvTLXDH M1XL3XkTrIlxP3VfixZNTU+3iwZAM27dY/Zol2KPSQp0YzUqPKr3ww3GVEjZ+GsLa6zB BRq9+P37N55Se0YARaCTvStQAhPkLSLc6KTxuOjimy3oJ/Ie2JUhsvOqLOfyBBrC3HHt KLjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Nj39KvvJBDQl5ELAslfY4/i9vvM4QKppfETPhCXArpc=; b=uF8cSsnjfyNgw1DyB0b6QQiuE//a2rsiychz+tToSTpu0sZEkwfhGiQBuHb6SSO0Ve g2jmHLyRusJvAx1Gxi9Mf2LQJaLMysQ1QDJm0ZBW2Yi5uYi/h3ICQfrXs1+8I+cRBDOj FX3K1r/7XQpZSg5wiWWZMuMJgTIzGkEGUUOqq+4V4LsbmDzSlsQQrpnlJ7A0gFbskr1C 8FW2FDVsETASnpoEXURBnApUAKnRO1IaqsupMCGFv7jtTJZtBkwzASusQfk7TomMR4v0 Z2hn+aHatn5WHbftxrx5xD4mfvnbpiMOL9AjITuAcdk5Q76f7wLVP9ZIJbEROMKW/5u0 NDGw== X-Gm-Message-State: AOAM531/HmKTxlxvz7QDtkgurXkysNY31vJROvKqNlnY/w3otPw5zDBL 0pXZKqSRz28zzbRTgzfMa+7r5A== X-Received: by 2002:a05:600c:2212:: with SMTP id z18mr6041484wml.186.1598434444635; Wed, 26 Aug 2020 02:34:04 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id u3sm3978759wml.44.2020.08.26.02.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 02:34:04 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones Subject: [PATCH 00/30] Set 3: Rid W=1 warnings in Wireless Date: Wed, 26 Aug 2020 10:33:31 +0100 Message-Id: <20200826093401.1458456-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There are quite a few W=1 warnings in the Wireless. My plan is to work through all of them over the next few weeks. Hopefully it won't be too long before drivers/net/wireless builds clean with W=1 enabled. This set brings the total number of (arm, arm64, x86, mips and ppc *combined* i.e. some duplicated) warnings down from 2066 (since the last set) to 1018. Lee Jones (30): wireless: marvell: mwifiex: pcie: Move tables to the only place they're used wireless: broadcom: brcmsmac: ampdu: Remove a couple set but unused variables wireless: intel: iwlegacy: 3945-mac: Remove all non-conformant kernel-doc headers wireless: intel: iwlegacy: 3945-rs: Remove all non-conformant kernel-doc headers wireless: intel: iwlegacy: 3945: Remove all non-conformant kernel-doc headers wireless: broadcom: brcmfmac: p2p: Fix a couple of function headers wireless: intersil: orinoco_usb: Downgrade non-conforming kernel-doc headers wireless: broadcom: brcmsmac: phy_cmn: Remove a unused variables 'vbat' and 'temp' wireless: zydas: zd1211rw: zd_chip: Fix formatting wireless: zydas: zd1211rw: zd_mac: Add missing or incorrect function documentation wireless: zydas: zd1211rw: zd_chip: Correct misspelled function argument wireless: ath: wil6210: wmi: Correct misnamed function parameter 'ptr_' wireless: broadcom: brcm80211: brcmfmac: fwsignal: Finish documenting 'brcmf_fws_mac_descriptor' wireless: ath: ath6kl: wmi: Remove unused variable 'rate' wireless: ti: wlcore: debugfs: Remove unused variable 'res' wireless: rsi: rsi_91x_sdio: Fix a few kernel-doc related issues wireless: ath: ath9k: ar9002_initvals: Remove unused array 'ar9280PciePhy_clkreq_off_L1_9280' wireless: ath: ath9k: ar9001_initvals: Remove unused array 'ar5416Bank6_9100' wireless: intersil: hostap: hostap_hw: Remove unused variable 'fc' wireless: wl3501_cs: Fix a bunch of formatting issues related to function docs wireless: realtek: rtw88: debug: Remove unused variables 'val' wireless: rsi: rsi_91x_sdio_ops: File headers are not good kernel-doc candidates wireless: intersil: prism54: isl_ioctl: Remove unused variable 'j' wireless: marvell: mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused wireless: ath: ath9k: ar5008_initvals: Remove unused table entirely wireless: ath: ath9k: ar5008_initvals: Move ar5416Bank{0,1,2,3,7} to where they are used wireless: broadcom: brcm80211: phy_lcn: Remove a bunch of unused variables wireless: broadcom: brcm80211: phy_n: Remove a bunch of unused variables wireless: broadcom: brcm80211: phytbl_lcn: Remove unused array 'dot11lcnphytbl_rx_gain_info_rev1' wireless: broadcom: brcm80211: phytbl_n: Remove a few unused arrays drivers/net/wireless/ath/ath6kl/wmi.c | 10 +- .../net/wireless/ath/ath9k/ar5008_initvals.h | 68 ----- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 31 +- .../net/wireless/ath/ath9k/ar9001_initvals.h | 37 --- .../net/wireless/ath/ath9k/ar9002_initvals.h | 14 - drivers/net/wireless/ath/wil6210/wmi.c | 2 +- .../broadcom/brcm80211/brcmfmac/fwsignal.c | 6 + .../broadcom/brcm80211/brcmfmac/p2p.c | 5 +- .../broadcom/brcm80211/brcmsmac/ampdu.c | 9 +- .../broadcom/brcm80211/brcmsmac/phy/phy_cmn.c | 6 +- .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 40 +-- .../broadcom/brcm80211/brcmsmac/phy/phy_n.c | 47 +-- .../brcm80211/brcmsmac/phy/phytbl_lcn.c | 13 - .../brcm80211/brcmsmac/phy/phytbl_n.c | 268 ------------------ .../net/wireless/intel/iwlegacy/3945-mac.c | 24 +- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 8 +- drivers/net/wireless/intel/iwlegacy/3945.c | 46 +-- .../net/wireless/intersil/hostap/hostap_hw.c | 3 +- .../wireless/intersil/orinoco/orinoco_usb.c | 6 +- .../net/wireless/intersil/prism54/isl_ioctl.c | 3 +- drivers/net/wireless/marvell/mwifiex/pcie.c | 149 ++++++++++ drivers/net/wireless/marvell/mwifiex/pcie.h | 149 ---------- drivers/net/wireless/marvell/mwifiex/wmm.h | 3 +- drivers/net/wireless/realtek/rtw88/debug.c | 6 +- drivers/net/wireless/rsi/rsi_91x_sdio.c | 7 +- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 2 +- drivers/net/wireless/ti/wlcore/debugfs.h | 6 +- drivers/net/wireless/wl3501_cs.c | 22 +- drivers/net/wireless/zydas/zd1211rw/zd_chip.c | 4 +- drivers/net/wireless/zydas/zd1211rw/zd_mac.c | 15 +- 30 files changed, 288 insertions(+), 721 deletions(-) -- 2.25.1