[00/30] Set 3: Rid W=1 warnings in Wireless

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

There are quite a few W=1 warnings in the Wireless.  My plan
is to work through all of them over the next few weeks.
Hopefully it won't be too long before drivers/net/wireless
builds clean with W=1 enabled.

This set brings the total number of (arm, arm64, x86, mips and
ppc *combined* i.e. some duplicated) warnings down from 2066
(since the last set) to 1018.

Lee Jones (30):
  wireless: marvell: mwifiex: pcie: Move tables to the only place
    they're used
  wireless: broadcom: brcmsmac: ampdu: Remove a couple set but unused
    variables
  wireless: intel: iwlegacy: 3945-mac: Remove all non-conformant
    kernel-doc headers
  wireless: intel: iwlegacy: 3945-rs: Remove all non-conformant
    kernel-doc headers
  wireless: intel: iwlegacy: 3945: Remove all non-conformant kernel-doc
    headers
  wireless: broadcom: brcmfmac: p2p: Fix a couple of function headers
  wireless: intersil: orinoco_usb: Downgrade non-conforming kernel-doc
    headers
  wireless: broadcom: brcmsmac: phy_cmn: Remove a unused variables
    'vbat' and 'temp'
  wireless: zydas: zd1211rw: zd_chip: Fix formatting
  wireless: zydas: zd1211rw: zd_mac: Add missing or incorrect function
    documentation
  wireless: zydas: zd1211rw: zd_chip: Correct misspelled function
    argument
  wireless: ath: wil6210: wmi: Correct misnamed function parameter
    'ptr_'
  wireless: broadcom: brcm80211: brcmfmac: fwsignal: Finish documenting
    'brcmf_fws_mac_descriptor'
  wireless: ath: ath6kl: wmi: Remove unused variable 'rate'
  wireless: ti: wlcore: debugfs: Remove unused variable 'res'
  wireless: rsi: rsi_91x_sdio: Fix a few kernel-doc related issues
  wireless: ath: ath9k: ar9002_initvals: Remove unused array
    'ar9280PciePhy_clkreq_off_L1_9280'
  wireless: ath: ath9k: ar9001_initvals: Remove unused array
    'ar5416Bank6_9100'
  wireless: intersil: hostap: hostap_hw: Remove unused variable 'fc'
  wireless: wl3501_cs: Fix a bunch of formatting issues related to
    function docs
  wireless: realtek: rtw88: debug: Remove unused variables 'val'
  wireless: rsi: rsi_91x_sdio_ops: File headers are not good kernel-doc
    candidates
  wireless: intersil: prism54: isl_ioctl:  Remove unused variable 'j'
  wireless: marvell: mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as
    __maybe_unused
  wireless: ath: ath9k: ar5008_initvals: Remove unused table entirely
  wireless: ath: ath9k: ar5008_initvals: Move ar5416Bank{0,1,2,3,7} to
    where they are used
  wireless: broadcom: brcm80211: phy_lcn: Remove a bunch of unused
    variables
  wireless: broadcom: brcm80211: phy_n: Remove a bunch of unused
    variables
  wireless: broadcom: brcm80211: phytbl_lcn: Remove unused array
    'dot11lcnphytbl_rx_gain_info_rev1'
  wireless: broadcom: brcm80211: phytbl_n: Remove a few unused arrays

 drivers/net/wireless/ath/ath6kl/wmi.c         |  10 +-
 .../net/wireless/ath/ath9k/ar5008_initvals.h  |  68 -----
 drivers/net/wireless/ath/ath9k/ar5008_phy.c   |  31 +-
 .../net/wireless/ath/ath9k/ar9001_initvals.h  |  37 ---
 .../net/wireless/ath/ath9k/ar9002_initvals.h  |  14 -
 drivers/net/wireless/ath/wil6210/wmi.c        |   2 +-
 .../broadcom/brcm80211/brcmfmac/fwsignal.c    |   6 +
 .../broadcom/brcm80211/brcmfmac/p2p.c         |   5 +-
 .../broadcom/brcm80211/brcmsmac/ampdu.c       |   9 +-
 .../broadcom/brcm80211/brcmsmac/phy/phy_cmn.c |   6 +-
 .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c |  40 +--
 .../broadcom/brcm80211/brcmsmac/phy/phy_n.c   |  47 +--
 .../brcm80211/brcmsmac/phy/phytbl_lcn.c       |  13 -
 .../brcm80211/brcmsmac/phy/phytbl_n.c         | 268 ------------------
 .../net/wireless/intel/iwlegacy/3945-mac.c    |  24 +-
 drivers/net/wireless/intel/iwlegacy/3945-rs.c |   8 +-
 drivers/net/wireless/intel/iwlegacy/3945.c    |  46 +--
 .../net/wireless/intersil/hostap/hostap_hw.c  |   3 +-
 .../wireless/intersil/orinoco/orinoco_usb.c   |   6 +-
 .../net/wireless/intersil/prism54/isl_ioctl.c |   3 +-
 drivers/net/wireless/marvell/mwifiex/pcie.c   | 149 ++++++++++
 drivers/net/wireless/marvell/mwifiex/pcie.h   | 149 ----------
 drivers/net/wireless/marvell/mwifiex/wmm.h    |   3 +-
 drivers/net/wireless/realtek/rtw88/debug.c    |   6 +-
 drivers/net/wireless/rsi/rsi_91x_sdio.c       |   7 +-
 drivers/net/wireless/rsi/rsi_91x_sdio_ops.c   |   2 +-
 drivers/net/wireless/ti/wlcore/debugfs.h      |   6 +-
 drivers/net/wireless/wl3501_cs.c              |  22 +-
 drivers/net/wireless/zydas/zd1211rw/zd_chip.c |   4 +-
 drivers/net/wireless/zydas/zd1211rw/zd_mac.c  |  15 +-
 30 files changed, 288 insertions(+), 721 deletions(-)

-- 
2.25.1

Lee Jones <lee.jones@linaro.org> writes:

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> There are quite a few W=1 warnings in the Wireless.  My plan
> is to work through all of them over the next few weeks.
> Hopefully it won't be too long before drivers/net/wireless
> builds clean with W=1 enabled.

How much patches are there going to be? I was first positive about the
idea but now I am really starting to wonder if this is worth the effort,
these patches are spamming my patchwork significantly and taking too
much time. At least please hold of on any new patches for at least a
week so I can catch up with all patches I have.

And like I said already before, follow the title style we use so that I
don't need to edit every patch myself:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong