mbox series

[0/4] nl80211: add support for WPA/WPA2-PSK 4-way handshake and SAE offload in AP mode

Message ID 20200623134938.39997-1-chi-hsien.lin@cypress.com
Headers show
Series nl80211: add support for WPA/WPA2-PSK 4-way handshake and SAE offload in AP mode | expand

Message

Chi-Hsien Lin June 23, 2020, 1:49 p.m. UTC
From: Chung-Hsien Hsu <stanley.hsu@cypress.com>

This patch series add support for offloading WPA/WPA2-PSK 4-way handshake
and SAE authentication in AP mode.

Chung-Hsien Hsu (4):
  nl80211: support 4-way handshake offloading for WPA/WPA2-PSK in AP
    mode
  brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK in AP
    mode
  nl80211: support SAE authentication offload in AP mode
  brcmfmac: support SAE authentication offload in AP mode

 .../broadcom/brcm80211/brcmfmac/cfg80211.c    | 49 ++++++++++++++++--
 .../broadcom/brcm80211/brcmfmac/cfg80211.h    | 14 +++++
 .../broadcom/brcm80211/brcmfmac/feature.c     |  1 +
 .../broadcom/brcm80211/brcmfmac/feature.h     |  4 +-
 include/uapi/linux/nl80211.h                  | 51 ++++++++++++-------
 net/wireless/nl80211.c                        |  9 ++--
 6 files changed, 104 insertions(+), 24 deletions(-)

Comments

Johannes Berg July 30, 2020, 2:52 p.m. UTC | #1
On Tue, 2020-06-23 at 08:49 -0500, Chi-Hsien Lin wrote:
> From: Chung-Hsien Hsu <stanley.hsu@cypress.com>

> 

> Let drivers advertise support for AP-mode WPA/WPA2-PSK 4-way handshake

> offloading with a new NL80211_EXT_FEATURE_4WAY_HANDSHAKE_AP_PSK flag.

> 

> Extend use of NL80211_ATTR_PMK attribute indicating it might be passed

> as part of NL80211_CMD_START_AP command, and contain the PSK (which is

> the PMK, hence the name).

> 

> The driver is assumed to handle the 4-way handshake by itself in this

> case, instead of relying on userspace.


Applied.

johannes
Johannes Berg July 30, 2020, 2:55 p.m. UTC | #2
On Tue, 2020-06-23 at 08:49 -0500, Chi-Hsien Lin wrote:
> From: Chung-Hsien Hsu <stanley.hsu@cypress.com>

> 

> Add support for SAE authentication offload in AP mode.


It seems to me you need a new feature flag for this, just like in the
PSK case, because brcmfmac in fact already sets this, and in fact as we
can see in patch 4 it would now set it in two places depending on
*different* firmware support conditions ... that may be OK for the
firmware right now, but it still doesn't really make much sense.

Please change to add another flag here.

johannes