From patchwork Thu Dec 19 13:15:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 182111 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp466231iln; Thu, 19 Dec 2019 05:15:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxG3ZTs9ZhdCCqeL9lKFA+PWWq+hsAXpXLv7CgY6XdpznymtXySWw82aNh6GXL2ZxPQdyOc X-Received: by 2002:aca:52cd:: with SMTP id g196mr2099570oib.18.1576761323868; Thu, 19 Dec 2019 05:15:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576761323; cv=none; d=google.com; s=arc-20160816; b=iCG94/2CoQmqusMRS/s63qhAWqlEpUtew4m4wzg7Z8JY8w8g8hbDbqi0q4r06mVEA7 TjQCoSMgwxH1Fvt91H0t7F+YovghtAxF3h0kNnT9IOO1uJ03vFOy1P2CUZmIiw6IU2ZR TeTlwk0c/QbAgAQXhF1X3oL9mDjCiF4BAHx00H9ppF5xGyJPQsVLhYR5Gk2LuQrnozSU nxRx//JFFA9uRicJt9J60eZJ5RfIMQuBLnfIXgODK52sqvCqVTuTe1BDuqdcveRbtgla 2zKBA3ExRRi3KFTe0a925MQ71n3LqPNUH4lAJKOzjITKUCKNqQ2rJo36IncL+qdxRBA6 v+Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B+Ei4HzxmBsPDZTHsP8DZ9d6KPTrEHJVVPZdhv56adw=; b=pIDFidv3T90BpKZO0lPAc7QhI/JjV94s3icISOXoKYLxKYHzHtS5DmiMjlLtDJR51h 9uuLxr+mzkACasmHtPLzZfxsP4vIDKL2BNwa5rOzPK1RgNIdAn1EqPndGcGBldNrbIH0 ttEElEMispCNMd/BQS/QO/A8lFsXGhDf4LSQE4PWHpNiHZqFDynJohfe6JNtANmcDVdA VTz5vVsLT48q7sy9K2DRmJbPWrojX9NZUS58XfT80f9T1VCnhQwuSezguz7/D2fglRLb aUmGEebarpWPebI4PejZ28s6Nj2rvEqGAgNrRm+6yb1sNNtaVwQXkrPw4MHazN8Q8gk7 p8bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=awGrenJD; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 200si3035632oii.156.2019.12.19.05.15.23; Thu, 19 Dec 2019 05:15:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=awGrenJD; spf=pass (google.com: best guess record for domain of linux-wireless-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726719AbfLSNPX (ORCPT + 2 others); Thu, 19 Dec 2019 08:15:23 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:37214 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726701AbfLSNPW (ORCPT ); Thu, 19 Dec 2019 08:15:22 -0500 Received: by mail-ed1-f67.google.com with SMTP id cy15so4839336edb.4 for ; Thu, 19 Dec 2019 05:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=B+Ei4HzxmBsPDZTHsP8DZ9d6KPTrEHJVVPZdhv56adw=; b=awGrenJDW7xKsLpiPGeIRrNo2A6uiQq9t9EbV7eHgKbZd1UBgDN85SFMihKdxt44j+ McN6qtLM1968DRzpP0a3v1ukyOodwO29cpQTXazvDOHdqsYuLciQ55UDCyfH+YdBIzMq e49/fSYwOLqpnkDyCM7423wQOymJVFx9tuO+4fdWihvKsrcHQOtw/Z//n47v3AOFLdi8 brJY7pAPzOpBHP2CpfB/576DEtHzcWed93QDWBBfdlUSxAchDeMGW4TcBgkotPbzDVsG ndCmD8SioCy8XIc/BYIZKmVa4g5oVP+OhjkzBlqEJOiSJPmIpaQoNw4E9LQYgfptBYm3 Y6Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=B+Ei4HzxmBsPDZTHsP8DZ9d6KPTrEHJVVPZdhv56adw=; b=MJFfYkJGSnZUsoUfscd9akfSqFj0PzMH6cH2fodQ3KxWVj+WZkr/JI7pmZvE6X07ma uw7hD4ooH+CPXeSRkoERS2sSwLHj1vXQQ/gDS6y0cZHJpR9RL8PZvwVaUr/mCNsPKSnf FqRbfa6+3gQfglIpdhmI2QtbUeTYvtb/hDIX/rCgFE2npwqawGenswOIytAUCggSZ4IU DIymFrTwOPFYveX7NCSP4NSUnJCl21zABUOlsflD236nbw03Zzonv9hku7DFz/qlFZDg yGgiiL8MetAk+NshUvXwmQaYxQJFq7D76MgbOsqIzJrfyYQoAbHcSsPEyEB5SMfoH4C+ iNvA== X-Gm-Message-State: APjAAAUuB1RGiDVlav6WDpXV7V4ePvUdCqTN5qv5ey8ELrvMONiKUSev pLgYFfTubqvNGYcYbn3Hza3mEg== X-Received: by 2002:a17:906:19ca:: with SMTP id h10mr9395261ejd.282.1576761321093; Thu, 19 Dec 2019 05:15:21 -0800 (PST) Received: from localhost.localdomain ([176.61.57.127]) by smtp.gmail.com with ESMTPSA id cw15sm410286edb.44.2019.12.19.05.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 05:15:20 -0800 (PST) From: Bryan O'Donoghue To: kvalo@codeaurora.org, akolli@codeaurora.org, ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Bryan O'Donoghue Subject: [PATCH 0/2] ath10k: pci: Two PCI related fixups Date: Thu, 19 Dec 2019 13:15:37 +0000 Message-Id: <20191219131539.1003793-1-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This set addresses two issues one a contrived but real corner-case crash scenario and the other a simple typo. Debugging on a QCS405 which has an ath10k attached to PCIe its been found that a loop similar to the below [1] will cause. 1. A significant slow-down in the time it takes an individual ioread32() to complete. 2. A secure watchdog bite. This is as a result of the restart routine and the dump register routine running in parallel and a period of time during restart where dumping registers is unstable. The second patch is a simple fix to an apparent copy/paste error describing the behavior of a similar dump function. [1] Reset method while $1 do echo hw-restart > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash echo hard > /sys/kernel/debug/ieee80211/phy0/ath10k/simulate_fw_crash done; Bryan O'Donoghue (2): ath10k: pci: Only dump ATH10K_MEM_REGION_TYPE_IOREG when safe ath10k: pci: Fix comment on ath10k_pci_dump_memory_sram drivers/net/wireless/ath/ath10k/pci.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) -- 2.24.0