mbox series

[v2,0/3] rsi: fix startup and P2P mode

Message ID 1630337206-12410-1-git-send-email-martin.fuzzey@flowbird.group
Headers show
Series rsi: fix startup and P2P mode | expand

Message

Martin Fuzzey Aug. 30, 2021, 3:26 p.m. UTC 
This series fixes an occasional startup failure when BT
coexistence is enabled and makes P2P mode work
(the two are unrelated but sending as a series since the same files
are modified).

Tested on RS9116 in P2P client mode against an Android phone (S8, Android 9)

For an unknown reason GO mode does not work against the phone but it
does work against a second RS9116 device.
In this case Android does not send a response to the 3rd WPA handshake
packet. It is difficult to debug this without the phone wpa_supplicant
logs which I don't have.

Regression tested OK for STA and AP modes.

V2:
  * rebase against wireless-drivers-next
  * add cc: stable to patches 2 & 3

Martin Fuzzey (3):
  rsi: fix occasional initialisation failure with BT coex
  rsi: fix key enabled check causing unwanted encryption for vap_id > 0
  rsi: fix rate mask set leading to P2P failure

 drivers/net/wireless/rsi/rsi_91x_core.c     |  2 +
 drivers/net/wireless/rsi/rsi_91x_hal.c      | 10 ++--
 drivers/net/wireless/rsi/rsi_91x_mac80211.c | 74 +++++++++--------------------
 drivers/net/wireless/rsi/rsi_91x_main.c     | 16 +++++--
 drivers/net/wireless/rsi/rsi_91x_mgmt.c     | 24 +++++++---
 drivers/net/wireless/rsi/rsi_main.h         | 15 ++++--
 6 files changed, 72 insertions(+), 69 deletions(-)

--
1.9.1

Comments

Kalle Valo Sept. 21, 2021, 5:49 a.m. UTC | #1 
Martin Fuzzey <martin.fuzzey@flowbird.group> writes:

> This series fixes an occasional startup failure when BT

> coexistence is enabled and makes P2P mode work

> (the two are unrelated but sending as a series since the same files

> are modified).

>

> Tested on RS9116 in P2P client mode against an Android phone (S8, Android 9)

>

> For an unknown reason GO mode does not work against the phone but it

> does work against a second RS9116 device.

> In this case Android does not send a response to the 3rd WPA handshake

> packet. It is difficult to debug this without the phone wpa_supplicant

> logs which I don't have.

>

> Regression tested OK for STA and AP modes.

>

> V2:

>   * rebase against wireless-drivers-next

>   * add cc: stable to patches 2 & 3

>

> Martin Fuzzey (3):

>   rsi: fix occasional initialisation failure with BT coex

>   rsi: fix key enabled check causing unwanted encryption for vap_id > 0

>   rsi: fix rate mask set leading to P2P failure


BTW thanks for the outstanding cover letter and commit logs in the
patches, it was so easy for me to understand the background and the
level of testing these patches have had. If everyone would write their
patches like this my job would be a lot easier :)

I'm going to use this patchset as an example in the submittingpatches
wiki page.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches