| Message ID | 20241004200314.5459-4-wsa+renesas@sang-engineering.com |
|---|---|
| State | New |
| Headers | show |
| Series | watchdog: don't print out if registering watchdog fails | expand |
On Fri, Oct 04, 2024 at 10:03:06PM +0200, Wolfram Sang wrote: > The core will do this already. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
On Fri, Oct 04, 2024 at 10:03:06PM +0200, Wolfram Sang wrote: > The core will do this already. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > drivers/watchdog/gxp-wdt.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Question: should email have been titled "watchdog: gxp-wdt: ..." instead of "watchdog: hpe-wdt: ..." to match the module name as the email title gets put into the git log for the file? Thanks Jerry > > diff --git a/drivers/watchdog/gxp-wdt.c b/drivers/watchdog/gxp-wdt.c > index 2fd85be88278..f2c236160266 100644 > --- a/drivers/watchdog/gxp-wdt.c > +++ b/drivers/watchdog/gxp-wdt.c > @@ -151,10 +151,8 @@ static int gxp_wdt_probe(struct platform_device *pdev) > > watchdog_stop_on_reboot(&drvdata->wdd); > err = devm_watchdog_register_device(dev, &drvdata->wdd); > - if (err) { > - dev_err(dev, "Failed to register watchdog device"); > + if (err) > return err; > - } > > dev_info(dev, "HPE GXP watchdog timer"); > > -- > 2.45.2 >
diff --git a/drivers/watchdog/gxp-wdt.c b/drivers/watchdog/gxp-wdt.c index 2fd85be88278..f2c236160266 100644 --- a/drivers/watchdog/gxp-wdt.c +++ b/drivers/watchdog/gxp-wdt.c @@ -151,10 +151,8 @@ static int gxp_wdt_probe(struct platform_device *pdev) watchdog_stop_on_reboot(&drvdata->wdd); err = devm_watchdog_register_device(dev, &drvdata->wdd); - if (err) { - dev_err(dev, "Failed to register watchdog device"); + if (err) return err; - } dev_info(dev, "HPE GXP watchdog timer");
The core will do this already. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/watchdog/gxp-wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)