| Message ID | 1615805214-24857-2-git-send-email-srinivas.neeli@xilinx.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/9] watchdog: of_xilinx_wdt: Add comment to spinlock | expand |
On 3/15/21 3:46 AM, Srinivas Neeli wrote: > From: Srinivas Goud <srinivas.goud@xilinx.com> > > Based on checkpatch every spinlock should be documented. > The patch is fixing this issue: > ./scripts/checkpatch.pl --strict -f drivers/watchdog/of_xilinx_wdt.c > CHECK: spinlock_t definition without comment > + spinlock_t spinlock; > > Signed-off-by: Srinivas Goud <srinivas.goud@xilinx.com> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/of_xilinx_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c > index 7fe4f7c3f7ce..00549164b3d7 100644 > --- a/drivers/watchdog/of_xilinx_wdt.c > +++ b/drivers/watchdog/of_xilinx_wdt.c > @@ -40,7 +40,7 @@ > struct xwdt_device { > void __iomem *base; > u32 wdt_interval; > - spinlock_t spinlock; > + spinlock_t spinlock; /* spinlock for register handling */ > struct watchdog_device xilinx_wdt_wdd; > struct clk *clk; > }; >
diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c index 7fe4f7c3f7ce..00549164b3d7 100644 --- a/drivers/watchdog/of_xilinx_wdt.c +++ b/drivers/watchdog/of_xilinx_wdt.c @@ -40,7 +40,7 @@ struct xwdt_device { void __iomem *base; u32 wdt_interval; - spinlock_t spinlock; + spinlock_t spinlock; /* spinlock for register handling */ struct watchdog_device xilinx_wdt_wdd; struct clk *clk; };