From patchwork Tue Mar 4 09:34:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 25674 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f200.google.com (mail-ob0-f200.google.com [209.85.214.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id EE95C20540 for ; Tue, 4 Mar 2014 09:40:32 +0000 (UTC) Received: by mail-ob0-f200.google.com with SMTP id gq1sf32487497obb.11 for ; Tue, 04 Mar 2014 01:40:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=WWe0i7VmyLMtl9rXFGFB3ty41+fz70dMYRxDNbRbmGw=; b=Y/tniz49ZOIxAwJBHLV4QphPjbT+KoH5DIGuqLQMBDPYnR7ln1V8KqC5T0pyFdma9v Mx2xzlrGz8aOog60nULwK0/3wSSpon3ZuS/KK0brWlng3+Ula0qtzriXj/MgabFj2xrN a0rEwpwr7QZF05l04ZelMzr29XyJpJt6xO4FlhnzdVqVhmXsIQrkcZB1bGcj4CvEzTkN 8pcOOvN2m/DkHsSRdT5oj3q0xbE/HnhOwp0TYmnP6O8XY2TBH0xgCHMoqnHvhtSufeK7 3u/2TKN85QUC98Ui3ZhhWL5cINF8nzPwRxanF54HJRF99D9bnKTkNc2KFt7Pk3Zsr8sg x22w== X-Gm-Message-State: ALoCoQm8SgpmdrCf+xinqhc/DF0errofVzBWArKcrlAJh3RRKQO6HGXTRWpz4Itu1H/SiYSbuf0V X-Received: by 10.50.26.65 with SMTP id j1mr934839igg.7.1393926031939; Tue, 04 Mar 2014 01:40:31 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.87.5 with SMTP id q5ls2534679qgd.99.gmail; Tue, 04 Mar 2014 01:40:31 -0800 (PST) X-Received: by 10.58.168.142 with SMTP id zw14mr1567313veb.33.1393926031770; Tue, 04 Mar 2014 01:40:31 -0800 (PST) Received: from mail-ve0-f178.google.com (mail-ve0-f178.google.com [209.85.128.178]) by mx.google.com with ESMTPS id tz5si983416vdc.150.2014.03.04.01.40.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Mar 2014 01:40:31 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.178; Received: by mail-ve0-f178.google.com with SMTP id jw12so2682445veb.9 for ; Tue, 04 Mar 2014 01:40:31 -0800 (PST) X-Received: by 10.58.37.67 with SMTP id w3mr21217847vej.22.1393926031692; Tue, 04 Mar 2014 01:40:31 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.130.193 with SMTP id u1csp114943vcs; Tue, 4 Mar 2014 01:40:31 -0800 (PST) X-Received: by 10.66.176.143 with SMTP id ci15mr4839061pac.35.1393926030881; Tue, 04 Mar 2014 01:40:30 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ub8si2428588pac.68.2014.03.04.01.40.30; Tue, 04 Mar 2014 01:40:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-watchdog-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756661AbaCDJka (ORCPT + 1 other); Tue, 4 Mar 2014 04:40:30 -0500 Received: from mail-pb0-f53.google.com ([209.85.160.53]:65166 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756452AbaCDJk2 (ORCPT ); Tue, 4 Mar 2014 04:40:28 -0500 Received: by mail-pb0-f53.google.com with SMTP id rp16so4991812pbb.12 for ; Tue, 04 Mar 2014 01:40:27 -0800 (PST) X-Received: by 10.66.136.71 with SMTP id py7mr5108100pab.2.1393926027756; Tue, 04 Mar 2014 01:40:27 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id gj9sm45620806pbc.7.2014.03.04.01.40.25 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Mar 2014 01:40:27 -0800 (PST) From: Sachin Kamat To: linux-watchdog@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, wim@iguana.be, sachin.kamat@linaro.org Subject: [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization Date: Tue, 4 Mar 2014 15:04:34 +0530 Message-Id: <1393925675-21636-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-watchdog-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.178 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Initializing clk to NULL as a reset/error condition does not help as NULL is not an invalid condition w.r.t clk. Remove this initialization altogether as there is no state retention. Signed-off-by: Sachin Kamat Reviewed-by: Guenter Roeck --- drivers/watchdog/s3c2410_wdt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index aba6cd46b45b..a0f8f771adec 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -607,7 +607,6 @@ static int s3c2410wdt_probe(struct platform_device *pdev) err_clk: clk_disable_unprepare(wdt->clock); - wdt->clock = NULL; err: return ret; @@ -627,7 +626,6 @@ static int s3c2410wdt_remove(struct platform_device *dev) s3c2410wdt_cpufreq_deregister(wdt); clk_disable_unprepare(wdt->clock); - wdt->clock = NULL; return 0; }