| Message ID | 20240903152308.13565-1-detlev.casanova@collabora.com |
|---|---|
| Headers | show |
| Series | Add device tree for ArmSoM Sige 5 board | expand |
Hi, On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote: > Just like RK356x and RK3588, RK3576 is compatible to the existing > rk3399 binding. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Heiko Stuebner <heiko@sntech.de> merged to i2c/i2c-host. Thanks, Andi
On Tue, 03 Sep 2024 11:22:30 -0400, Detlev Casanova wrote: > Add the rk3576-armsom-sige5 device tree as well as its rk3576.dtsi base > and pinctrl information in rk3576-pinctrl.dtsi. > > The other commits add DT bindings documentation for the devices that > already work with the current corresponding drivers. > > Note that as is, the rockchip gpio driver needs the gpio nodes > to be children of the pinctrl node, even though this is deprecated. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [7/9] spi: dt-bindings: Add rockchip,rk3576-spi compatible commit: b0cdf9cc089525da330919d1bcd3b92655aaa621 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Tue, 03 Sep 2024 11:22:30 -0400, Detlev Casanova wrote: > Add the rk3576-armsom-sige5 device tree as well as its rk3576.dtsi base > and pinctrl information in rk3576-pinctrl.dtsi. > > The other commits add DT bindings documentation for the devices that > already work with the current corresponding drivers. > > Note that as is, the rockchip gpio driver needs the gpio nodes > to be children of the pinctrl node, even though this is deprecated. > > When the driver supports it, they can be moved out of the pinctrl node. > > The power-domain@RK3576_PD_USB is a child of power-domain@RK3576_PD_VOP. > That looks strange but it is how the hardware is, and confirmed by > Rockchip: The NOC bus of USB passes through the PD of VOP, so it relies on > VOP PD. > > The other bindings have been applied on next. > > Changes since v3: > - Dropped mmc dt-bindings (submitted in [2]) > - Dropped syscon dt-bindings (applied in [3]) > - Fix gpu interrupt names mapping > - (Fix email headers overwriting) > > Changes since v2: > - Fix LEDs in armsom dts > - mmc: Move allOf after the required block > - Remove saradc dt-binding commit (already applied) > - Remove opp-microvolt-L* fields > - Reword mali commit message > - Use rgmii-id and remove delays on gmac nodes > > Changes since v1: > - Add eMMC support > - Add gpu node > - Add rtc node > - Add spi compatible dt-bindings > - Add watchdog support > - Dropped timer compatible commit (applied in [0]) > - Move ethernet aliases to board dt > - Move mmio nodes to soc node > - Removed cru grf phandle > - Removed gpio aliases > - Removed grf compatibles (applied in [1]) > - Removed pinctrl php-grf phandle > - Removed v2-tuning for sdcard > - Renamed clock nodes > - Renamed regulators do match regulator-vcc-<voltage>-<name> > - Renamed the rkvdec_sram node to vdec_sram to match prior generations > - Reorder fields consistently in nodes > - Use correct #power-domain-cells values > > [0]: https://lore.kernel.org/all/918bb9e4-02d9-4dca-bed2-28bb123bdc10@linaro.org/ > [1]: https://lore.kernel.org/all/172441646605.877570.8075942261050000.b4-ty@sntech.de/ > [2]: https://lore.kernel.org/all/20240903145615.9302-1-detlev.casanova@collabora.com/ > [3]: https://lore.kernel.org/all/172500660860.97285.13837050366813522297.b4-ty@kernel.org/ > > Detlev. > > Detlev Casanova (9): > dt-bindings: arm: rockchip: Add ArmSoM Sige 5 > dt-bindings: arm: rockchip: Add rk3576 compatible string to pmu.yaml > dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible > dt-bindings: serial: snps-dw-apb-uart: Add Rockchip RK3576 > dt-bindings: gpu: Add rockchip,rk3576-mali compatible > dt-bindings: watchdog: Add rockchip,rk3576-wdt compatible > spi: dt-bindings: Add rockchip,rk3576-spi compatible > arm64: dts: rockchip: Add rk3576 SoC base DT > arm64: dts: rockchip: Add rk3576-armsom-sige5 board > > .../devicetree/bindings/arm/rockchip.yaml | 5 + > .../devicetree/bindings/arm/rockchip/pmu.yaml | 2 + > .../bindings/gpu/arm,mali-bifrost.yaml | 1 + > .../devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + > .../bindings/serial/snps-dw-apb-uart.yaml | 1 + > .../devicetree/bindings/spi/spi-rockchip.yaml | 1 + > .../bindings/watchdog/snps,dw-wdt.yaml | 1 + > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 659 ++ > .../boot/dts/rockchip/rk3576-pinctrl.dtsi | 5775 +++++++++++++++++ > arch/arm64/boot/dts/rockchip/rk3576.dtsi | 1644 +++++ > 11 files changed, 8091 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-pinctrl.dtsi > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576.dtsi > > -- > 2.46.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3576-armsom-sige5.dtb' for 20240903152308.13565-1-detlev.casanova@collabora.com: arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: clock-controller@27200000: 'rockchip,grf' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/clock/rockchip,rk3576-cru.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: gpu@27800000: interrupt-names:0: 'job' was expected from schema $id: http://devicetree.org/schemas/gpu/arm,mali-bifrost.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: gpu@27800000: interrupt-names:2: 'gpu' was expected from schema $id: http://devicetree.org/schemas/gpu/arm,mali-bifrost.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: mmc@2a310000: compatible: 'oneOf' conditional failed, one must be fixed: ['rockchip,rk3576-dw-mshc', 'rockchip,rk3288-dw-mshc'] is too long 'rockchip,rk2928-dw-mshc' was expected 'rockchip,rk3288-dw-mshc' was expected 'rockchip,rk3576-dw-mshc' is not one of ['rockchip,px30-dw-mshc', 'rockchip,rk1808-dw-mshc', 'rockchip,rk3036-dw-mshc', 'rockchip,rk3128-dw-mshc', 'rockchip,rk3228-dw-mshc', 'rockchip,rk3308-dw-mshc', 'rockchip,rk3328-dw-mshc', 'rockchip,rk3368-dw-mshc', 'rockchip,rk3399-dw-mshc', 'rockchip,rk3568-dw-mshc', 'rockchip,rk3588-dw-mshc', 'rockchip,rv1108-dw-mshc', 'rockchip,rv1126-dw-mshc'] from schema $id: http://devicetree.org/schemas/mmc/rockchip-dw-mshc.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: mmc@2a310000: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/mmc/rockchip-dw-mshc.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: mmc@2a330000: compatible:0: 'rockchip,rk3576-dwcmshc' is not one of ['rockchip,rk3568-dwcmshc', 'rockchip,rk3588-dwcmshc', 'snps,dwcmshc-sdhci', 'sophgo,cv1800b-dwcmshc', 'sophgo,sg2002-dwcmshc', 'sophgo,sg2042-dwcmshc', 'thead,th1520-dwcmshc'] from schema $id: http://devicetree.org/schemas/mmc/snps,dwcmshc-sdhci.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: mmc@2a330000: compatible: ['rockchip,rk3576-dwcmshc', 'rockchip,rk3588-dwcmshc'] is too long from schema $id: http://devicetree.org/schemas/mmc/snps,dwcmshc-sdhci.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: mmc@2a330000: Unevaluated properties are not allowed ('compatible', 'power-domains' were unexpected) from schema $id: http://devicetree.org/schemas/mmc/snps,dwcmshc-sdhci.yaml# arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: /soc/mmc@2a330000: failed to match any schema with compatible: ['rockchip,rk3576-dwcmshc', 'rockchip,rk3588-dwcmshc'] arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: rtc@51: Unevaluated properties are not allowed ('clock-frequency' was unexpected) from schema $id: http://devicetree.org/schemas/rtc/haoyu,hym8563.yaml#
On Tue, 3 Sep 2024 11:22:30 -0400, Detlev Casanova wrote: > Add the rk3576-armsom-sige5 device tree as well as its rk3576.dtsi base > and pinctrl information in rk3576-pinctrl.dtsi. > > The other commits add DT bindings documentation for the devices that > already work with the current corresponding drivers. > > Note that as is, the rockchip gpio driver needs the gpio nodes > to be children of the pinctrl node, even though this is deprecated. > > [...] Applied, thanks! [1/9] dt-bindings: arm: rockchip: Add ArmSoM Sige 5 commit: 78dee7b6ef085c6a1becad536035bdd39557c9b0 [8/9] arm64: dts: rockchip: Add rk3576 SoC base DT commit: 4b9dc5d536b988fbd84e68e8d8ac420752b185b6 [9/9] arm64: dts: rockchip: Add rk3576-armsom-sige5 board commit: 54a18f63eb1aaf50cad17dd64076293f2817e1d5 changes: - added some lines between node - resortet regulator nodes - removed trailing whitespace from one line - drop clock-frequency from armsom sige5 rtc@51 - drop rockchip,grf from cru (lookup is done via compatible) - order gpu interrupts like expected in the binding - adjust mmc compatible to binding Best regards,