| Message ID | 20231205092229.19135-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | dt-bindings: samsung: continued - add specific compatibles for Tesla FSD Hi, | expand |
On Tue, 05 Dec 2023 10:22:24 +0100, Krzysztof Kozlowski wrote: > Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the > others it reuses several devices from older designs. Historically we > kept the old (block's) compatible only. This works fine and there is no > bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add Tesla FSD compatible specific to be used with an existing fallback. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 05 Dec 2023 10:22:26 +0100, Krzysztof Kozlowski wrote: > Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the > others it reuses several devices from older designs. Historically we > kept the old (block's) compatible only. This works fine and there is no > bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add Tesla FSD compatible specific to be used with an existing fallback. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 05 Dec 2023 10:22:28 +0100, Krzysztof Kozlowski wrote: > Tesla FSD is a derivative of Samsung Exynos SoC, thus just like the > others it reuses several devices from older designs. Historically we > kept the old (block's) compatible only. This works fine and there is no > bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add Tesla FSD compatible specific to be used with an existing fallback. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/watchdog/samsung-wdt.yaml | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 05 Dec 2023 10:22:23 +0100, Krzysztof Kozlowski wrote: > Merging > ======= > I propose to take entire patchset through my tree (Samsung SoC), because: > 1. I already took similar work this cycle: > https://lore.kernel.org/all/169997520487.6747.17671551558724027958.b4-ty@linaro.org/ > 2. Two new SoCs are coming (Google GS101 and ExynosAutov920) and they might > touch the same lines. It is reasonable for me to take the bindings for the new > SoCs, to have clean `make dtbs_check` on the new DTS. > 3. Having it together helps me to have clean `make dtbs_check` within my tree > on the existing DTS. > 4. No drivers are affected by this change. > > [...] Applied, thanks! [1/6] dt-bindings: i2c: exynos5: add specific compatible for Tesla FSD https://git.kernel.org/krzk/linux/c/7677fdbc036b93a882f660ca2484a6807e72f0be [2/6] dt-bindings: pwm: samsung: add specific compatible for Tesla FSD https://git.kernel.org/krzk/linux/c/edb32ec3cea79b518e6af841ecb01c839818f562 [3/6] dt-bindings: serial: samsung: add specific compatible for Tesla FSD https://git.kernel.org/krzk/linux/c/921f4f1db7f5bf6798349db8a4382c032f144b98 [4/6] dt-bindings: samsung: exynos-pmu: add specific compatible for Tesla FSD https://git.kernel.org/krzk/linux/c/54772f1d61cd99ea1ed0febd4187bf24ef63bccd [5/6] dt-bindings: watchdog: samsung: add specific compatible for Tesla FSD https://git.kernel.org/krzk/linux/c/bf1e24c5330af06b2f7f1a166a1011d8d48e8651 [6/6] arm64: dts: fsd: add specific compatibles for Tesla FSD https://git.kernel.org/krzk/linux/c/5f257922c5948c58669346d5cda371632108f266 Best regards,
Merging ======= I propose to take entire patchset through my tree (Samsung SoC), because: 1. I already took similar work this cycle: https://lore.kernel.org/all/169997520487.6747.17671551558724027958.b4-ty@linaro.org/ 2. Two new SoCs are coming (Google GS101 and ExynosAutov920) and they might touch the same lines. It is reasonable for me to take the bindings for the new SoCs, to have clean `make dtbs_check` on the new DTS. 3. Having it together helps me to have clean `make dtbs_check` within my tree on the existing DTS. 4. No drivers are affected by this change. If folks agree, please kindly Ack the patches. Description =========== See: https://lore.kernel.org/all/20231108104343.24192-1-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof Krzysztof Kozlowski (6): dt-bindings: i2c: exynos5: add specific compatible for Tesla FSD dt-bindings: pwm: samsung: add specific compatible for Tesla FSD dt-bindings: serial: samsung: add specific compatible for Tesla FSD dt-bindings: samsung: exynos-pmu: add specific compatible for Tesla FSD dt-bindings: watchdog: samsung: add specific compatible for Tesla FSD arm64: dts: fsd: add specific compatibles for Tesla FSD .../devicetree/bindings/i2c/i2c-exynos5.yaml | 1 + .../devicetree/bindings/pwm/pwm-samsung.yaml | 1 + .../bindings/serial/samsung_uart.yaml | 1 + .../bindings/soc/samsung/exynos-pmu.yaml | 1 + .../bindings/watchdog/samsung-wdt.yaml | 21 +++++++----- arch/arm64/boot/dts/tesla/fsd.dtsi | 32 +++++++++---------- 6 files changed, 33 insertions(+), 24 deletions(-)