| Message ID | 20220308193522.26696-1-henning.schild@siemens.com |
|---|---|
| Headers | show |
| Series | simatic-ipc additions to p2sb apl lake gpio | expand |
On Tue, Mar 08, 2022 at 08:35:20PM +0100, Henning Schild wrote: > This switches the simatic-ipc modules to using the p2sb interface > introduced by Andy with "platform/x86: introduce p2sb_bar() helper". > > It also switches to one apollo lake device to using gpio leds. > > I am kind of hoping Andy will take this on top and propose it in his > series. First of all, they are not applicable to my current version [1] of the series (it maybe something changed in the Simatic drivers upstream, because I have got conflicts there. For the record, I'm using Linux Next as a base. Second question is could it be possible to split first patch into three, or it has to be in one? [1]: https://gitlab.com/andy-shev/next/-/tree/topic/p2sb-next It would be nice if you can perform another round of testing. > Henning Schild (2): > simatic-ipc: convert to use common P2SB accessor > leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver > > drivers/leds/simple/Kconfig | 11 ++ > drivers/leds/simple/Makefile | 3 +- > drivers/leds/simple/simatic-ipc-leds-gpio.c | 108 ++++++++++++++++++ > drivers/leds/simple/simatic-ipc-leds.c | 77 +------------ > drivers/platform/x86/simatic-ipc.c | 43 +------ > drivers/watchdog/Kconfig | 1 + > drivers/watchdog/simatic-ipc-wdt.c | 15 +-- > .../platform_data/x86/simatic-ipc-base.h | 2 - > 8 files changed, 139 insertions(+), 121 deletions(-) > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c > > -- > 2.34.1 >
On Wed, May 04, 2022 at 05:19:51PM +0200, Henning Schild wrote: > Am Wed, 4 May 2022 15:51:01 +0300 > schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > > > On Tue, Mar 08, 2022 at 08:35:20PM +0100, Henning Schild wrote: > > > This switches the simatic-ipc modules to using the p2sb interface > > > introduced by Andy with "platform/x86: introduce p2sb_bar() helper". > > > > > > It also switches to one apollo lake device to using gpio leds. > > > > > > I am kind of hoping Andy will take this on top and propose it in his > > > series. > > > > First of all, they are not applicable to my current version [1] of > > the series (it maybe something changed in the Simatic drivers > > upstream, because I have got conflicts there. For the record, I'm > > using Linux Next as a base. > > That is possible, some sparse findings have been fixed lately. > > > Second question is could it be possible to split first patch into > > three, or it has to be in one? > > I assume one for leds one for wdt and finally drop stuff from platform, > and i will go with that assumption for a next round based on your tree > directly. > Can you explain why that will be useful? While it is kind of a > separation of concerns and subsystems ... it also kind of all belongs > together and needs to be merged in a rather strict order. > That is not really correct. It should be possible to split the patches and only remove simatic_ipc_get_membase0() after the other patches have been applied. On a side note, neither subject nor description of patch 1/2 mention that the patch touches both LED and watchdog code, which is at the very least bad style. Guenter > regards, > Henning > > > [1]: https://gitlab.com/andy-shev/next/-/tree/topic/p2sb-next > > It would be nice if you can perform another round of testing. > > > > > Henning Schild (2): > > > simatic-ipc: convert to use common P2SB accessor > > > leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver > > > > > > drivers/leds/simple/Kconfig | 11 ++ > > > drivers/leds/simple/Makefile | 3 +- > > > drivers/leds/simple/simatic-ipc-leds-gpio.c | 108 > > > ++++++++++++++++++ drivers/leds/simple/simatic-ipc-leds.c | > > > 77 +------------ drivers/platform/x86/simatic-ipc.c | > > > 43 +------ drivers/watchdog/Kconfig | 1 + > > > drivers/watchdog/simatic-ipc-wdt.c | 15 +-- > > > .../platform_data/x86/simatic-ipc-base.h | 2 - > > > 8 files changed, 139 insertions(+), 121 deletions(-) > > > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c > > > > > > -- > > > 2.34.1 > > > > > >
Am Wed, 4 May 2022 17:19:51 +0200 schrieb Henning Schild <henning.schild@siemens.com>: > Am Wed, 4 May 2022 15:51:01 +0300 > schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > > > On Tue, Mar 08, 2022 at 08:35:20PM +0100, Henning Schild wrote: > > > This switches the simatic-ipc modules to using the p2sb interface > > > introduced by Andy with "platform/x86: introduce p2sb_bar() > > > helper". > > > > > > It also switches to one apollo lake device to using gpio leds. > > > > > > I am kind of hoping Andy will take this on top and propose it in > > > his series. > > > > First of all, they are not applicable to my current version [1] of > > the series (it maybe something changed in the Simatic drivers > > upstream, because I have got conflicts there. For the record, I'm > > using Linux Next as a base. > > That is possible, some sparse findings have been fixed lately. > > > Second question is could it be possible to split first patch into > > three, or it has to be in one? > > I assume one for leds one for wdt and finally drop stuff from > platform, and i will go with that assumption for a next round based > on your tree directly. > Can you explain why that will be useful? While it is kind of a > separation of concerns and subsystems ... it also kind of all belongs > together and needs to be merged in a rather strict order. > > regards, > Henning > > > [1]: https://gitlab.com/andy-shev/next/-/tree/topic/p2sb-next > > It would be nice if you can perform another round of testing. Just got around to testing this with my patches on top. My stuff will need some more work before i can send again. Is this a rebasing branch? With efc7d77ea372 ("EDAC, pnd2: convert to use common P2SB accessor") I am seeing problems while booting ... things do work but still error messages which probably should not be there. [ 2.215715] gpio gpiochip0: (apollolake-pinctrl.0): not an immutable chip, please consider fixing it! [ 2.217506] broxton-pinctrl apollolake-pinctrl.1: Failed to attach ACPI GPIO chip [ 2.217542] gpio gpiochip1: (apollolake-pinctrl.1): not an immutable chip, please consider fixing it! [ 2.217771] i801_smbus 0000:00:1f.1: Failed to enable SMBus PCI device (-22) [ 2.217788] i801_smbus: probe of 0000:00:1f.1 failed with error -22 [ 2.221460] broxton-pinctrl apollolake-pinctrl.2: Failed to attach ACPI GPIO chip [ 2.221482] gpio gpiochip2: (apollolake-pinctrl.2): not an immutable chip, please consider fixing it! [ 2.222010] broxton-pinctrl apollolake-pinctrl.3: Failed to attach ACPI GPIO chip [ 2.222023] gpio gpiochip3: (apollolake-pinctrl.3): not an immutable chip, please consider fixing it! regards, Henning > > > Henning Schild (2): > > > simatic-ipc: convert to use common P2SB accessor > > > leds: simatic-ipc-leds-gpio: add GPIO version of Siemens driver > > > > > > drivers/leds/simple/Kconfig | 11 ++ > > > drivers/leds/simple/Makefile | 3 +- > > > drivers/leds/simple/simatic-ipc-leds-gpio.c | 108 > > > ++++++++++++++++++ drivers/leds/simple/simatic-ipc-leds.c | > > > 77 +------------ drivers/platform/x86/simatic-ipc.c | > > > 43 +------ drivers/watchdog/Kconfig | 1 + > > > drivers/watchdog/simatic-ipc-wdt.c | 15 +-- > > > .../platform_data/x86/simatic-ipc-base.h | 2 - > > > 8 files changed, 139 insertions(+), 121 deletions(-) > > > create mode 100644 drivers/leds/simple/simatic-ipc-leds-gpio.c > > > > > > -- > > > 2.34.1 > > > > > >
On Tue, May 10, 2022 at 05:30:53PM +0200, Henning Schild wrote: > Am Wed, 4 May 2022 17:19:51 +0200 > schrieb Henning Schild <henning.schild@siemens.com>: > > Am Wed, 4 May 2022 15:51:01 +0300 > > schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > > > On Tue, Mar 08, 2022 at 08:35:20PM +0100, Henning Schild wrote: ... > > > [1]: https://gitlab.com/andy-shev/next/-/tree/topic/p2sb-next > > > It would be nice if you can perform another round of testing. > > Just got around to testing this with my patches on top. My stuff will > need some more work before i can send again. > > Is this a rebasing branch? > With efc7d77ea372 ("EDAC, pnd2: convert to use common P2SB accessor") It's rebased over and over. I just pushed the same version I have sent as v5. > I am seeing problems while booting ... things do work but still error > messages which probably should not be there. It's okay. This is not related to my stuff, it's a new series from Marc which enables that (harmless) warning. > [ 2.217506] broxton-pinctrl apollolake-pinctrl.1: Failed to attach ACPI GPIO chip > [ 2.217542] gpio gpiochip1: (apollolake-pinctrl.1): not an immutable chip, please consider fixing it! > [ 2.217771] i801_smbus 0000:00:1f.1: Failed to enable SMBus PCI device (-22) > [ 2.217788] i801_smbus: probe of 0000:00:1f.1 failed with error -22 > [ 2.221460] broxton-pinctrl apollolake-pinctrl.2: Failed to attach ACPI GPIO chip > [ 2.221482] gpio gpiochip2: (apollolake-pinctrl.2): not an immutable chip, please consider fixing it! > [ 2.222010] broxton-pinctrl apollolake-pinctrl.3: Failed to attach ACPI GPIO chip > [ 2.222023] gpio gpiochip3: (apollolake-pinctrl.3): not an immutable > chip, please consider fixing it!