From patchwork Tue May 13 09:07:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chen, Jay" X-Patchwork-Id: 890887 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013048.outbound.protection.outlook.com [52.101.127.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB2A31E991A; Tue, 13 May 2025 09:07:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747127227; cv=fail; b=SmWqjFACmDIkuvi8oVQWxGRzxsyo+NQQCumX4yEOgNtOQyrqGiwa4PQN1ZuHxN4aaN250hlXEU6udireAzscffp6LBDv9PU+5Vj9xz3J+ZLWPOEZXd6VnpaFuVVu92765wbNnF2/paQJxHH+YQmTExb2N4H4RT0GbIWCIT5IvyA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747127227; c=relaxed/simple; bh=1KvQ/VdWheTCl9zo4hpsLTZE3C4pG4dO8ZF27SR4i2w=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version; b=YR/AkAV0aDV2Bzu/igIue/6vGgW6F2pJHaFPPxvZQs6Xb7qjLNHFExaZi9T2iC/CwNk1sHOC3nbLXlNiO+2ZwuOrZdm6w67A9K2GhgF4qST2AalbciB7JUTKQqDxnk9ab1vgkVJsR7/z4kkIvZlper7oXDWLrunS99mnJOm19HI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com; spf=pass smtp.mailfrom=siemens.com; dkim=pass (2048-bit key) header.d=siemens.com header.i=@siemens.com header.b=AxCD/wSy; arc=fail smtp.client-ip=52.101.127.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=siemens.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=siemens.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=siemens.com header.i=@siemens.com header.b="AxCD/wSy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e+dFl3b6PReyhOsCR6jtEoLaD+D5teRG4d5+XmEo93VPhN4ook8iz27N0sxYwWdlKaypKirZjUcYWwPqtvLVBRhFo4ymiP7InpAUXJiW7/OXBXoADZg4l8Tw/0a6xBtdBNQ6ULjMz6HPTq1XaJ+vBdmzN8THIuZrKXtyHntAi1DYgLyGZT+vdi5bfHZkSe3HTVK33JsO9DfRzLlrcJm14eJ7Qo1pyavcZMgkUCRy9NkEo4BDkcrrcL0oExr/rgW7yw473UGNcExfwHte9/tr4kjyDi9Ov9t5faZTpLMtgF+DYEHfgm+Qs6KB2uomK5cVEa+Dgc7IbUKoQVqusub/Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1KvQ/VdWheTCl9zo4hpsLTZE3C4pG4dO8ZF27SR4i2w=; b=vnCGS1l6kjvlEaqnY2i1ztcYoM8f0cXjTIYKqtjpWBYuwG01pJIKtUB5f3nEIrGyPuKzPDgeqKY1V0Xt5GjwUJNVYS7YX0ziYAwBUPSi88TFGMpEFEZNuN9Xe9Vsy/al/33IKvK5TWYv9ly4UPoFVurnQ5G9RC2o9knkgj0TefnE2IivpWqIZeSGvsMYyPbbCYPwG0zeq7DCqDeuvMJXeuPJoHbaECOUlgwA7I/y9Y1W8GeUj8H/n/s8zE5AcnTujWqbbB/vbo33/1oEbZEQw4UwYf8e+ZVWhVGb9O08GOZroyI0pfiUvcw6Qvs4pvVGAc6sQE4bFL0MUQIGSHB4yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1KvQ/VdWheTCl9zo4hpsLTZE3C4pG4dO8ZF27SR4i2w=; b=AxCD/wSyHto3tAiCWKwT1WNCHZO5Te8cvXHbP2gcFJT+qCSYV9E3qaVgVDvAfo/kYo3RD8SX1XkfqPEF/KMw+HBZV0h5NKmz1LfXezpp0FTlfv8I/Mi6npqP/m+cQ9VkzbgWMNRxvolg6+QeIRUlwdxpgTK9V60D0g/08tWWzxxR8uM1O/SE/F8AFF21BWZu+YWtZWE5AO4nscq18ItxLXPAcJXXeAzBNIzaTcHCvt3LTjsdTweltdembe44c4uJbqgt1lBJESrD/9rNuLHlzuVGQWZwGTz76k0/B/EwNy8KPRyiRAbJt+I9xmR00brkrqm6ih28xquu4I883S1jKQ== Received: from JH0PR06MB7294.apcprd06.prod.outlook.com (2603:1096:990:a1::6) by TYZPR06MB6698.apcprd06.prod.outlook.com (2603:1096:400:463::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.24; Tue, 13 May 2025 09:07:01 +0000 Received: from JH0PR06MB7294.apcprd06.prod.outlook.com ([fe80::6bd3:c327:c5c2:bbbe]) by JH0PR06MB7294.apcprd06.prod.outlook.com ([fe80::6bd3:c327:c5c2:bbbe%6]) with mapi id 15.20.8722.027; Tue, 13 May 2025 09:07:00 +0000 From: "Chen, Jay" To: "mathias.nyman@intel.com" , "gregkh@linuxfoundation.org" CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Shao, Tzi Yang" Subject: [PATCH] usb: xhci: Set avg_trb_len = 8 for EP0 during Address Device Thread-Topic: [PATCH] usb: xhci: Set avg_trb_len = 8 for EP0 during Address Device Thread-Index: AdvD5Kfvhxy5Vw0sQSyzmQpOxYTl4A== Date: Tue, 13 May 2025 09:07:00 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ActionId=acc53e72-aa49-441b-a4a4-b3f05e64b6f1; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_ContentBits=0; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Enabled=true; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Method=Standard; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_Name=restricted; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SetDate=2025-05-13T08:54:19Z; MSIP_Label_9d258917-277f-42cd-a3cd-14c4e9ee58bc_SiteId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: JH0PR06MB7294:EE_|TYZPR06MB6698:EE_ x-ms-office365-filtering-correlation-id: a354f989-f294-4366-43e8-08dd91fd855e x-ms-exchange-atpmessageproperties: SA x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?yfeiBReECp4y/7cj2ronG6NtyW4ZSKf?= =?utf-8?q?LDO3YGkVZOfr6LGfZ6hKnI+MK0PnujUk1Ir0jEpJHXZn4O11x1LbTfNx2glKU1HkR?= =?utf-8?q?ox4zCZ8hEC0hR9s7tLPgAkZOMHwr0mb7usiOSFiq53slCQ531KwX6/at/NSEDAaXF?= =?utf-8?q?h1xeu4lGbkWnZXCmQLG/SpDHXXvSQHt4e6OONm+Ym6088En3OTSEC0Ng3Fsg7FJaN?= =?utf-8?q?qo8LSJPYV43ddJlSKsvd4+Pi5EeoAGHDr7HhDelfb47y+RbW6w06kY6CBgVE4lpQa?= =?utf-8?q?bi//VyEe0liV3XXeTYxa7hde5FFbWjRlFT6S3Np8IYWJMixZGuDhiAdw6ukdpzMoN?= =?utf-8?q?gbxWPtcRQugaMUeC2boRPfBIFLh5mrAIIQbc57smrvgHI+hpxgvAYzmiEvUiNimgp?= =?utf-8?q?ipwTy9++AopIZnyV4Y+TgX6IRej+whrPBDhD31lHPMHqb6I4P0dEwAZPyVcxNGrI7?= =?utf-8?q?rKRrjBosKl0Ldyumog44yZx2m4i7GQbRuwhKIXD9I/5MiNIV8NWuU1QghWUN8vmS6?= =?utf-8?q?aJNE5V3XjD3XGgAsFrLmFjO/JgOrVk0N/ecgUwYOisyOKLxj5obZR9wEQkNyzdPSj?= =?utf-8?q?wjIIu1CK5gS01j3gk09ANYY5R5YezGROfYCkL2uWHPAMEVFVFyh2OR+0iw9I9YkZo?= =?utf-8?q?ZcHmn/XNFhfpNNC6XXJzxnV//e6UV7QvpbpmkWvlYq38LQZw64mVwGccrMcEZGHTO?= =?utf-8?q?84MDAY0KU/6d0iPQeJFV12xg9n8XVAs2Ht4IYygYo/cnkC4nnwO6cTbisth9bfF07?= =?utf-8?q?P+l64fQQVMtZCL8o0RPkLMLYdcYzf3Ep+qzqkU8E1WzVtzQiYonE13CiEvpMVXJhk?= =?utf-8?q?mGsYvHich3A/CTz19WjA7CQv6yQlchEzL+3nmVk2ebCaAN8NPPdOYVzgr5XAz1hjz?= =?utf-8?q?7zo4hcvheT+7IuAaecxN/9i3BDS8LkDloqsYa09R0oRvrCouoXZBP4IlE7zTto2B7?= =?utf-8?q?95Nc7U615tcUlHZ4u77Wpd7bSr6NVGUGWWi74A1n7ge0SU3ly0qWgACfMMKKEO0VO?= =?utf-8?q?yra9V2Cpa20KC8x91WIX7qGhquiZFPFeQUK5oyKl66sYBYZd1fFcalq9Q92Wbq2+p?= =?utf-8?q?N3VmBOA091MEegpA5DfFO0OVX9lBgTDruq7s4pEWo7+whzCVt9XA9XWcDvWt7LBGN?= =?utf-8?q?GfSvjpsL0sDFtCjwklbowDqWp657Zmrlr4QDSP61reLT4w3QZVH1R6b3ru8WQn4Y7?= =?utf-8?q?aTCV0p+gAXvoJtXCVhgk273vptmbDSI57PERttV0Ialo51NLL56kJugurHuBDnAFP?= =?utf-8?q?Hf1F0b29k/oBm4TMZJBzicwzb8xayg4EGCXxakV3upXBOopLUqsXRDsgLQlzax3tR?= =?utf-8?q?DjNy0eXs/cbm4agrerDBd89nlPSyBA0aOg0xbrZWycvePKIcSMfdlpI=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:JH0PR06MB7294.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?q99cPBEj+zJkfMRZnrOcR385Lt5q?= =?utf-8?q?0hqyDV2/qEFLQsEX6WvNvRhvHqDKgQxzJ8ZsqE/EMCvMgZL12/eywTpFDP9mcUtQ6?= =?utf-8?q?uwYC7hqhOVOXiM/6CWAXafXpun2phN6yhIR9SZPLCgtGwflckIhFVnSfH/uHjfeOO?= =?utf-8?q?zwztz/8gJexazdKoYlentR88doG+5fCWFkOhnR/PBTP1n0/ev8tFruIDj1NsI8Zi6?= =?utf-8?q?9Xq8eIMivEnAgEFVQ2zqVW/i7sH5SLm6cTy+a5F/cOaTOUOqId3/6FIZslViq5dnY?= =?utf-8?q?yXG0caQ4L9nnZbFScbHbUz7jMKqjYFmSGeSeC9h/P/xdI99dmQj304hQhFzeJjQZz?= =?utf-8?q?zhaPAYcNnvtDBZ1KqON1wz2+8ZfQW2eQYI73Giq/ZMxJOlfV2q9pUIL93qi3H4Lvd?= =?utf-8?q?mRCjvrZeiGPNGULK5EUtqwXLREHsN8SUYRZ02FCR4KrIG3tvh2vr16NxuxErssP3B?= =?utf-8?q?KtS1BZ7KDn4CgavYkLsvb7jRVeBFDJb0VntJzHMa4w6twUDHHiBVfrWB0FFgiET4V?= =?utf-8?q?IvSIvEXWIMYfqTIWrNJYZZd4x2ziiVzzrOdJLElOCUoGv6Mya+MjXUlMJdQe/XoFB?= =?utf-8?q?eQgP5BdNMgMDSJyTWYAqbareiYEAskRsgvN4okthHyfVL5DJEzEGF84S5Q/g5ydww?= =?utf-8?q?XMnAjTvOsVabw1u2SAYKgB1bATaI4cfsKw22E/URH0nVtzTssZ6QGQ1xOoY5QA5Ij?= =?utf-8?q?Utkm9d7JkD6iUNBoHRNLIaEWohh4j8lsXc6xLifrnXU50R0ROPUBXsnPaYqiRzFLm?= =?utf-8?q?eMRp7hrw/27Chyu5h0p9M8SbZliDJY7g3gQPjenRJoGUuc1y6ojdXg2xwYm7kMan5?= =?utf-8?q?d4aioYu5+jdTlstrCvT1RoN1n8G99GxibmyUH75t3UW0U+6seLD1T0eRqPrEBf9dV?= =?utf-8?q?CUew9+Xr7G4zZMlvisSwqHQEQ3T1RUWtJs3kfx08BpycSHohP2IS3OQRKE7oHc+fM?= =?utf-8?q?PAm50VqFtpvlC7H6hbA8R7NS9h+HgaWADmWR8yKPj+IU25/A+t/upTbT2e3skg9fd?= =?utf-8?q?Rh6tRxaMOOD6oYFLlaZuiTpZhJByFxvx9hEWroP7FnTqpppPpgZOgS6YcZV2nA/hC?= =?utf-8?q?pZDI+IlNyplgGlL6ektSKtG5VJWevQhzYyjuxKsNoJ0Hnv+/Zdz9c5FtDEYWOd+Y/?= =?utf-8?q?do/yYWngN7fvsLNzUWVOctcooQACpZW33mRrGaewLdWBSoUX7rISacj9NILWFfVxb?= =?utf-8?q?boxKHa0X8SSnb8wB5HqMw5mQXzgdR0i3Q3Z28YaDbHRyl/EDqDgcxSMHc2kUtJ5e+?= =?utf-8?q?4OEHIlP/tkiWue57OvvPgYxcro5mBcFUrs29p71qeK/euqwnfey6HS0ggicmtE2Iz?= =?utf-8?q?9h/wjxJpJTAzhe09crmw9HJORCPAWhjde/rn+dgJ9spJ/nqrgV9pyIeG/UrNLHYZB?= =?utf-8?q?+wT37cFzHM4mswcUKu3e040KNoTHjrBIr9m7mznQbdPOpsPi+KuE55P7gNs7WFbWd?= =?utf-8?q?kcGjtSMXNrxLmNberZfMWvClsoFfpb/wrYF4aUrObJ88T4CKKBB/kY3SDLfH8Kh6m?= =?utf-8?q?D6vk0KPLlEbT?= Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB7294.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a354f989-f294-4366-43e8-08dd91fd855e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2025 09:07:00.6499 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UXYmywwSX4mPi+qNbFPXjmvQ5dHacanB6Ztp9OBsvqylH1ZhzJwnOZZvFqV1g07W5fnTkG18mN4kZqpnpcNTpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6698 >From fef893bcf0add89795b85bcc1f6bdae537f1dabe Mon Sep 17 00:00:00 2001 From: "jay.chen" Date: Tue, 13 May 2025 15:03:44 +0800 Subject: [PATCH] usb: xhci: Set avg_trb_len = 8 for EP0 during Address Device Command According to the xHCI 1.2 spec (Section 6.2.3, p.454), the Average TRB Length (avg_trb_len) for control endpoints should be set to 8. Currently, during the Address Device Command, EP0's avg_trb_len remains 0, which may cause some xHCI hardware to reject the Input Context, resulting in device enumeration failures. In extreme cases, using a zero avg_trb_len in calculations may lead to division-by-zero errors and unexpected system crashes. This patch sets avg_trb_len to 8 for EP0 in xhci_setup_addressable_virt_dev(), ensuring compliance with the spec and improving compatibility across various host controller implementations. Link: https://bugzilla.kernel.org/show_bug.cgi?id=220033 Signed-off-by: jay.chen --- drivers/usb/host/xhci-mem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index d698095fc88d..fed9e9d1990c 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -1166,6 +1166,8 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud ep0_ctx->deq = cpu_to_le64(dev->eps[0].ring->first_seg->dma | dev->eps[0].ring->cycle_state); + ep0_ctx->tx_info |= cpu_to_le32(EP_AVG_TRB_LENGTH(8)); + trace_xhci_setup_addressable_virt_device(dev); /* Steps 7 and 8 were done in xhci_alloc_virt_device() */