From patchwork Sat May 17 19:19:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ze Huang X-Patchwork-Id: 891091 Received: from mail-m155101.qiye.163.com (mail-m155101.qiye.163.com [101.71.155.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30D2214A9F; Sat, 17 May 2025 19:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.101 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747509609; cv=none; b=qvpeWqbdgFdECCQHPGcqMt1y8h8ovEgn08TD+qHndbx9zLAuaB5qvuiOGJ2At6hau64Zvz5YvPu/KB8WNYLN1aaf2VTZomc7BVt62UxEfZMeqIR/YFx/uksEkIYb2oDpMXruOBJJTow7yQOF+riPVIl569gYncZ2rkRI+WsjvCY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747509609; c=relaxed/simple; bh=S63sEb2XMDH2IufyJOCLNyXFdeUsEcACDNXY1iQcTOY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SafAT6tFOY0FUl+pyVdL0E1Xq7Kh/RfwIjCTyRTq+3jTq6Hx27OntSQ9UMGREfkhsUxS7zu2AnAvthMUbzssbOyp6Kn08XlGweu32hhVmHrZ7K9PRN3vMNPwnyG64ADjgIvpOdoYjhLn9CxTUULLs8E6441vp+oY/MSgOorcNus= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=whut.edu.cn; spf=pass smtp.mailfrom=whut.edu.cn; arc=none smtp.client-ip=101.71.155.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=whut.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=whut.edu.cn Received: from [127.0.0.1] (gy-adaptive-ssl-proxy-3-entmail-virt135.gy.ntes [27.18.99.32]) by smtp.qiye.163.com (Hmail) with ESMTP id 15658ef44; Sun, 18 May 2025 03:19:57 +0800 (GMT+08:00) From: Ze Huang Date: Sun, 18 May 2025 03:19:20 +0800 Subject: [PATCH v3 2/3] usb: dwc3: add common driver to support flattened DT Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250518-b4-k1-dwc3-v3-v3-2-7609c8baa2a6@whut.edu.cn> References: <20250518-b4-k1-dwc3-v3-v3-0-7609c8baa2a6@whut.edu.cn> In-Reply-To: <20250518-b4-k1-dwc3-v3-v3-0-7609c8baa2a6@whut.edu.cn> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Thinh Nguyen , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Ze Huang X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1747509584; l=6868; i=huangze@whut.edu.cn; s=20250325; h=from:subject:message-id; bh=S63sEb2XMDH2IufyJOCLNyXFdeUsEcACDNXY1iQcTOY=; b=bpmW9B7S6vY7irbGdAwDPIpia4yX9K79lmuvHZ1md3NxlBs78PnsG9vOVyncFYfpDzBMOcO3G bFmAPaI0QBqAy2LJHG7EcZlCxNVfJZU1rXa4yAzj9HEdVm7NfaVNAr0 X-Developer-Key: i=huangze@whut.edu.cn; a=ed25519; pk=C3zfn/kH6oMJickaXBa8dxTZO68EBiD93F+tAenboRA= X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlCH0lNVh5PSk0aTkpDSUsdHlYeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlJTFVKQ1VCQlVISVlXWRYaDxIVHRRZQVlPS0hVSktJT09PS1VKS0tVS1kG X-HM-Tid: 0a96dfb0576103a1kunm15658ef44 X-HM-MType: 10 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MBg6NDo4FzExPioWDhoeLBMj FjpPCSNVSlVKTE9MTktCTUtPS0pNVTMWGhIXVRMOGhUcAR47DBMOD1UeHw5VGBVFWVdZEgtZQVlJ TFVKQ1VCQlVISVlXWQgBWUFDSEJONwY+ To support flattened dwc3 dt model and drop the glue layer, introduce the `dwc3-common` driver. This enables direct binding of the DWC3 core driver and offers an alternative to the existing glue driver `dwc3-of-simple`. Signed-off-by: Ze Huang --- drivers/usb/dwc3/Kconfig | 9 ++ drivers/usb/dwc3/Makefile | 1 + drivers/usb/dwc3/dwc3-common.c | 191 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 201 insertions(+) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 310d182e10b50b253d7e5a51674806e6ec442a2a..852f94f906e4f339dcbb562e1ce708409ba77b76 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -118,6 +118,15 @@ config USB_DWC3_OF_SIMPLE Currently supports Xilinx and Qualcomm DWC USB3 IP. Say 'Y' or 'M' if you have one such device. +config USB_DWC3_COMMON + tristate "DWC3 Platform common Driver" + depends on OF && COMMON_CLK + default USB_DWC3 + help + Support USB3 functionality in simple SoC integrations. + Currently supports SpacemiT DWC USB3 IP. + Say 'Y' or 'M' if you have one such device. + config USB_DWC3_ST tristate "STMicroelectronics Platforms" depends on (ARCH_STI || COMPILE_TEST) && OF diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile index 830e6c9e5fe073c1f662ce34b6a4a2da34c407a2..ad1b0705c4d464f19e79ed0c3c63d942446e4742 100644 --- a/drivers/usb/dwc3/Makefile +++ b/drivers/usb/dwc3/Makefile @@ -57,3 +57,4 @@ obj-$(CONFIG_USB_DWC3_IMX8MP) += dwc3-imx8mp.o obj-$(CONFIG_USB_DWC3_XILINX) += dwc3-xilinx.o obj-$(CONFIG_USB_DWC3_OCTEON) += dwc3-octeon.o obj-$(CONFIG_USB_DWC3_RTK) += dwc3-rtk.o +obj-$(CONFIG_USB_DWC3_COMMON) += dwc3-common.o diff --git a/drivers/usb/dwc3/dwc3-common.c b/drivers/usb/dwc3/dwc3-common.c new file mode 100644 index 0000000000000000000000000000000000000000..afd9a7bec14b68dfd4f2353d714041882660a1a4 --- /dev/null +++ b/drivers/usb/dwc3/dwc3-common.c @@ -0,0 +1,191 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * dwc3-common.c - DesignWare USB3 common driver + * + * Copyright (C) 2025 Ze Huang + * + * Inspired by dwc3-qcom.c and dwc3-of-simple.c + */ + +#include +#include +#include +#include +#include +#include +#include "glue.h" + +struct dwc3_common { + struct device *dev; + struct dwc3 dwc; + struct clk_bulk_data *clks; + int num_clocks; + struct reset_control *resets; +}; + +static int dwc3_common_probe(struct platform_device *pdev) +{ + struct dwc3_probe_data probe_data = {}; + struct device *dev = &pdev->dev; + struct dwc3_common *dwc3c; + struct resource *res; + int ret; + + dwc3c = devm_kzalloc(dev, sizeof(*dwc3c), GFP_KERNEL); + if (!dwc3c) + return -ENOMEM; + + dwc3c->dev = dev; + + platform_set_drvdata(pdev, dwc3c); + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(&pdev->dev, "missing memory resource\n"); + return -ENODEV; + } + + dwc3c->resets = of_reset_control_array_get_optional_exclusive(dev->of_node); + if (IS_ERR(dwc3c->resets)) + return dev_err_probe(dev, PTR_ERR(dwc3c->resets), "failed to get reset\n"); + + ret = reset_control_assert(dwc3c->resets); + if (ret) + return dev_err_probe(dev, ret, "failed to assert reset\n"); + + usleep_range(10, 1000); + + ret = reset_control_deassert(dwc3c->resets); + if (ret) { + dev_err(dev, "failed to deassert reset\n"); + goto reset_assert; + } + + ret = clk_bulk_get_all(dwc3c->dev, &dwc3c->clks); + if (ret < 0) { + dev_err(dev, "failed to get clocks\n"); + goto reset_assert; + } + + dwc3c->num_clocks = ret; + + ret = clk_bulk_prepare_enable(dwc3c->num_clocks, dwc3c->clks); + if (ret) { + dev_err(dev, "failed to enable clocks\n"); + goto reset_assert; + } + + dwc3c->dwc.dev = dev; + probe_data.dwc = &dwc3c->dwc; + probe_data.res = res; + probe_data.ignore_clocks_and_resets = true; + ret = dwc3_core_probe(&probe_data); + if (ret) { + dev_err(dev, "failed to register DWC3 Core\n"); + goto clk_disable; + } + + return 0; + +clk_disable: + clk_bulk_disable_unprepare(dwc3c->num_clocks, dwc3c->clks); + clk_bulk_put_all(dwc3c->num_clocks, dwc3c->clks); + +reset_assert: + reset_control_assert(dwc3c->resets); + + return ret; +} + +static void dwc3_common_remove(struct platform_device *pdev) +{ + struct dwc3_common *dwc3c = platform_get_drvdata(pdev); + + dwc3_core_remove(&dwc3c->dwc); + + clk_bulk_disable_unprepare(dwc3c->num_clocks, dwc3c->clks); + clk_bulk_put_all(dwc3c->num_clocks, dwc3c->clks); + + reset_control_assert(dwc3c->resets); +} + +#ifdef CONFIG_PM_SLEEP +static int dwc3_common_suspend(struct device *dev) +{ + struct dwc3_common *dwc3c = dev_get_drvdata(dev); + int ret; + + ret = dwc3_pm_suspend(&dwc3c->dwc); + if (ret) + return ret; + + clk_bulk_disable_unprepare(dwc3c->num_clocks, dwc3c->clks); + + return 0; +} + +static int dwc3_common_resume(struct device *dev) +{ + struct dwc3_common *dwc3c = dev_get_drvdata(dev); + int ret; + + ret = clk_bulk_prepare_enable(dwc3c->num_clocks, dwc3c->clks); + if (ret) + return ret; + + ret = dwc3_pm_resume(&dwc3c->dwc); + if (ret) + return ret; + + return 0; +} + +static int dwc3_common_runtime_suspend(struct device *dev) +{ + struct dwc3_common *dwc3c = dev_get_drvdata(dev); + + return dwc3_runtime_suspend(&dwc3c->dwc); +} + +static int dwc3_common_runtime_resume(struct device *dev) +{ + struct dwc3_common *dwc3c = dev_get_drvdata(dev); + + return dwc3_runtime_resume(&dwc3c->dwc); +} + +static int dwc3_common_runtime_idle(struct device *dev) +{ + struct dwc3_common *dwc3c = dev_get_drvdata(dev); + + return dwc3_runtime_idle(&dwc3c->dwc); +} + +static const struct dev_pm_ops dwc3_common_dev_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(dwc3_common_suspend, dwc3_common_resume) + RUNTIME_PM_OPS(dwc3_common_runtime_suspend, dwc3_common_runtime_resume, + dwc3_common_runtime_idle) +}; +#endif /* CONFIG_PM_SLEEP */ + +static const struct of_device_id dwc3_common_of_match[] = { + { .compatible = "spacemit,k1-dwc3", }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, dwc3_common_of_match); + +static struct platform_driver dwc3_common_driver = { + .probe = dwc3_common_probe, + .remove = dwc3_common_remove, + .driver = { + .name = "dwc3-common", + .of_match_table = dwc3_common_of_match, +#ifdef CONFIG_PM_SLEEP + .pm = &dwc3_common_dev_pm_ops, +#endif /* CONFIG_PM_SLEEP */ + }, +}; +module_platform_driver(dwc3_common_driver); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("DesignWare USB3 common driver");