From patchwork Thu Jan 9 22:06:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 856539 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A38FA204F8D for ; Thu, 9 Jan 2025 22:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736460424; cv=none; b=ksEI7RtrnHD114TBsXaRpvx40Ah7APwdXw9QkKweuZB1VEvtBE87RQs8qHsT5GcZKYQFH61o+XNA1W9q1R9FJVMXGxU/DpMbqc5s6745YVxdu1KfieLrn+Rvcu5JFmlLv77+UBknX5kX05sUWwAwsG2aMuZXM6Uya0oMwLtuyKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736460424; c=relaxed/simple; bh=691TqzGyV4dZ3erdSQoQB9mOFtSofyCtfYUX2KRcl7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=soMwgWK99WPbYXonlD4HzG0DaKIkrfuQjUW40DbOk/ueiHIk+SHt5AH2vjlNxTWnIL+4pqvlvi3sszssUKswH3zPHZitA5PNYzHc/wbY66P9s2zCUyveazkvafauK+QY4A9nzkmaPWyMZQSpHt/1SOZQFcPaGJIXF+PyliJJ2Dg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ka/E06Wv; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ka/E06Wv" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ef8c012913so1891913a91.3 for ; Thu, 09 Jan 2025 14:06:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736460419; x=1737065219; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z+eJFfeJOCQC8B0IGpcCvXtjQAJSXPizwns60bTTIB0=; b=Ka/E06WvW+bjCFRLzQPdo9V48dR9InspVUC76RFJK91tYEcYokZJ1RFUi2rX0D1rs/ bF1uQg8l8DFRENLDeU+UXWQrOiyUwOAMUmTYgO4WyRJwPaPjSHow7mwLalWC3Q11PvFL ZmKW40/+ApfjthZPx0+MVDXs+FHi1krhCTaM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736460419; x=1737065219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z+eJFfeJOCQC8B0IGpcCvXtjQAJSXPizwns60bTTIB0=; b=YjaPCwzPoiOMEfS0KLJ27ZhcFz05d0B9B+q9yOgJCxjsMz0Z8oQog52RrAY87RysI2 Du+VFIrGBszaHIJsjH0CwtVNZ1dvyfHku0VNI3CI7su9z0uuQHglVDdEXW6IBvawRdPM 24y0PGziKniGBSi2+93pKXE6OQ0xc27qVb4rR+c+lKd88ceNdv+bFBSZQBwbk1tS0dSv 9J1bcZ3i8VftEJuFDes3+Y9EXrfuam38AKHROvEGTftRKfE1f95gXFoRBGfRVAdi/RIQ vu+l4bhPeVhvKoReX8RKcgKeOB94eStimAr+jzaFW9UWYi3xsSVK/BHMT99rdIMRCOCW qKXQ== X-Forwarded-Encrypted: i=1; AJvYcCVl3+slClvTBG1Y75iOzPMSksxzAA3UFgPs/v1KUDX6vIoXhgKoZiUL4fk7Knnz5bqwRUGIpPW90G0=@vger.kernel.org X-Gm-Message-State: AOJu0YzdnF1XxT1BrLmzP/xMwUY5Qn5/c6BWxxoAwVPIGLXPRcSUNdpG i0kpynxzmrAzqKdpk5hiqD+TYnHFchT9+N6DbsPEiQK7G8KQG8mhedNm/QMThA== X-Gm-Gg: ASbGncvV3B2W0fwyeLxfTNEHul15l6uiPHXmddrFHdCxHJ5hOS1yOkJs8f0AZzzhRC8 upTJGfpFgm0njZbIn5mW+zmGj2ifjiRy0fKCq20iG9KLfffDA0ROoDUHvjVrOmiwcGK725a+r6F LyMf72ySoYO5tJ3eG/ALLHZ4K15WeF3ZrF7UoD7lM7YX/3xDAyPsXJ4nJCCv47rGghzVn8yXPQy W9TDNGJBrhNsVXSa5FY683LMstoP6x5VhwZNlMEc2HnD+lr+Rqr1QPHE5BMKprjr2Nl/6o4i7nH XaX1vUQqN3urV+E2YWmB X-Google-Smtp-Source: AGHT+IHzMYBCU9fhbsnYh9NWeAdMwj9Nwk1H7/x3TSzmEP5o6kwN3Jz62wlfhHKZZQXr7JP3SQG5ag== X-Received: by 2002:a17:90a:d64b:b0:2ee:8aa7:94a0 with SMTP id 98e67ed59e1d1-2f548f42490mr10734733a91.32.1736460419093; Thu, 09 Jan 2025 14:06:59 -0800 (PST) Received: from localhost (129.135.125.34.bc.googleusercontent.com. [34.125.135.129]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2f54a2ad2e4sm4177805a91.28.2025.01.09.14.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 14:06:58 -0800 (PST) From: Stephen Boyd To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Benson Leung , chrome-platform@lists.linux.dev, linux-usb@vger.kernel.org, Pavan Holla , Abhishek Pandit-Subedi , =?utf-8?q?=C5=81ukasz?= =?utf-8?q?_Bartosik?= Subject: [PATCH 1/2] usb: typec: cros-ec-ucsi: Add newlines to printk messages Date: Thu, 9 Jan 2025 14:06:52 -0800 Message-ID: <20250109220655.1677506-2-swboyd@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20250109220655.1677506-1-swboyd@chromium.org> References: <20250109220655.1677506-1-swboyd@chromium.org> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 These printks need newlines. Add them and convert to dev_err_probe() in cros_ucsi_probe() to simplify code. Cc: Pavan Holla Cc: Abhishek Pandit-Subedi Cc: Łukasz Bartosik Signed-off-by: Stephen Boyd --- drivers/usb/typec/ucsi/cros_ec_ucsi.c | 28 ++++++++++++--------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/ucsi/cros_ec_ucsi.c index db8324b71ee9..75646a8d55be 100644 --- a/drivers/usb/typec/ucsi/cros_ec_ucsi.c +++ b/drivers/usb/typec/ucsi/cros_ec_ucsi.c @@ -58,14 +58,14 @@ static int cros_ucsi_read(struct ucsi *ucsi, unsigned int offset, void *val, int ret; if (val_len > MAX_EC_DATA_SIZE) { - dev_err(udata->dev, "Can't read %zu bytes. Too big.", val_len); + dev_err(udata->dev, "Can't read %zu bytes. Too big.\n", val_len); return -EINVAL; } ret = cros_ec_cmd(udata->ec, 0, EC_CMD_UCSI_PPM_GET, &req, sizeof(req), val, val_len); if (ret < 0) { - dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_GET: error=%d", ret); + dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_GET: error=%d\n", ret); return ret; } return 0; @@ -99,7 +99,7 @@ static int cros_ucsi_async_control(struct ucsi *ucsi, u64 cmd) ret = cros_ec_cmd(udata->ec, 0, EC_CMD_UCSI_PPM_SET, req, sizeof(ec_buf), NULL, 0); if (ret < 0) { - dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_SET: error=%d", ret); + dev_warn(udata->dev, "Failed to send EC message UCSI_PPM_SET: error=%d\n", ret); return ret; } return 0; @@ -161,7 +161,7 @@ static void cros_ucsi_write_timeout(struct work_struct *work) if (cros_ucsi_read(udata->ucsi, UCSI_CCI, &cci, sizeof(cci))) { dev_err(udata->dev, - "Reading CCI failed; no write timeout recovery possible."); + "Reading CCI failed; no write timeout recovery possible.\n"); return; } @@ -173,7 +173,7 @@ static void cros_ucsi_write_timeout(struct work_struct *work) msecs_to_jiffies(WRITE_TMO_MS)); else dev_err(udata->dev, - "PPM unresponsive - too many write timeouts."); + "PPM unresponsive - too many write timeouts.\n"); return; } @@ -208,7 +208,7 @@ static int cros_ucsi_event(struct notifier_block *nb, if (!(host_event & PD_EVENT_PPM)) return NOTIFY_OK; - dev_dbg(udata->dev, "UCSI notification received"); + dev_dbg(udata->dev, "UCSI notification received\n"); flush_work(&udata->work); schedule_work(&udata->work); @@ -237,10 +237,8 @@ static int cros_ucsi_probe(struct platform_device *pdev) udata->dev = dev; udata->ec = ec_data->ec_dev; - if (!udata->ec) { - dev_err(dev, "couldn't find parent EC device"); - return -ENODEV; - } + if (!udata->ec) + return dev_err_probe(dev, -ENODEV, "couldn't find parent EC device\n"); platform_set_drvdata(pdev, udata); @@ -249,24 +247,22 @@ static int cros_ucsi_probe(struct platform_device *pdev) init_completion(&udata->complete); udata->ucsi = ucsi_create(dev, &cros_ucsi_ops); - if (IS_ERR(udata->ucsi)) { - dev_err(dev, "failed to allocate UCSI instance"); - return PTR_ERR(udata->ucsi); - } + if (IS_ERR(udata->ucsi)) + return dev_err_probe(dev, PTR_ERR(udata->ucsi), "failed to allocate UCSI instance\n"); ucsi_set_drvdata(udata->ucsi, udata); udata->nb.notifier_call = cros_ucsi_event; ret = cros_usbpd_register_notify(&udata->nb); if (ret) { - dev_err(dev, "failed to register notifier: error=%d", ret); + dev_err_probe(dev, ret, "failed to register notifier\n"); ucsi_destroy(udata->ucsi); return ret; } ret = ucsi_register(udata->ucsi); if (ret) { - dev_err(dev, "failed to register UCSI: error=%d", ret); + dev_err_probe(dev, ret, "failed to register UCSI\n"); cros_ucsi_destroy(udata); return ret; }