| Message ID | 20241206153813.v4.3.I6cff9d767b0f8ab6458d8940941e42c920902d49@changeid |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Thunderbolt and DP altmode support for cros-ec-typec | expand |
On Fri, Dec 06, 2024 at 03:38:14PM -0800, Abhishek Pandit-Subedi wrote: > Print the error reason for typec_altmode_enter so users can understand > why displayport failed to enter. > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > --- > > (no changes since v1) > > drivers/usb/typec/altmodes/displayport.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index 3245e03d59e6..e292780ec309 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -252,7 +252,8 @@ static void dp_altmode_work(struct work_struct *work) > case DP_STATE_ENTER: > ret = typec_altmode_enter(dp->alt, NULL); > if (ret && ret != -EBUSY) > - dev_err(&dp->alt->dev, "failed to enter mode\n"); > + dev_err(&dp->alt->dev, "failed to enter mode: %d\n", > + ret); One line is enough. > break; > case DP_STATE_ENTER_PRIME: > ret = typec_cable_altmode_enter(dp->alt, TYPEC_PLUG_SOP_P, NULL); thanks,
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c index 3245e03d59e6..e292780ec309 100644 --- a/drivers/usb/typec/altmodes/displayport.c +++ b/drivers/usb/typec/altmodes/displayport.c @@ -252,7 +252,8 @@ static void dp_altmode_work(struct work_struct *work) case DP_STATE_ENTER: ret = typec_altmode_enter(dp->alt, NULL); if (ret && ret != -EBUSY) - dev_err(&dp->alt->dev, "failed to enter mode\n"); + dev_err(&dp->alt->dev, "failed to enter mode: %d\n", + ret); break; case DP_STATE_ENTER_PRIME: ret = typec_cable_altmode_enter(dp->alt, TYPEC_PLUG_SOP_P, NULL);
Print the error reason for typec_altmode_enter so users can understand why displayport failed to enter. Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> --- (no changes since v1) drivers/usb/typec/altmodes/displayport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)