From patchwork Mon Aug 26 07:06:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lei Liu X-Patchwork-Id: 823033 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2075.outbound.protection.outlook.com [40.107.215.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C33A2770E5; Mon, 26 Aug 2024 07:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.215.75 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724656000; cv=fail; b=eZpDNtBkUaboWm3FcBsjk2QZ1j8c1+PBcwRqgGA8WIPplQ7undZ7wuiaVV6A7mF4z7Wz7KmbHmjDFROdK3fjAzdb/6BpakbWRA/HxflNpVqTa4ckJojS8m0SDL39KDALBanykMuomHuXID6BhStwamaKte9qK4A+7RQN3dIUiAI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724656000; c=relaxed/simple; bh=u0+n1GQwDE7rBJX44eooamoelPv0ctmTtYeBw6eHikI=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=q7OzkFDFoLGW53GA+4G1sf3PQGSxyOwTZdHf8DgvPBNVaUqJdZHCzJ60g+DRe0Fb+pr9V+30zgLQj/Q9hTFulgkdnmOFWGI1ub8+HswS1gLOsgP8uRx0fEfEfCpAUmP1rlyvggwTY7VAe2khMTuf8RnWyg2eLx635Wt2Nvc2uvQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=p5346Xhl; arc=fail smtp.client-ip=40.107.215.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="p5346Xhl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=koEFL6X/ynvCfoT60WytssfEQWhlTJvYKeg79KMW2wF5XYzn4+Qz5UHx7wLcHb3KvbkCx3avYNSDe+Hwz7PJmuYHowZ7YlkXULYLQ9c4MQZeaeTAALIToDHWV3DthXcM4IvaKM1u0Hny3ul8GXTxaooOMu68HnMvywos5xzormCRP/H7ADlaKaFx1yxqF5eq8vUSenW9UJVLJuG973ID+hxNwUh8lNwFYkgyVi2a0VZ80q8jILz7a/S2V4gyLP/QGqxVw+3/URWmtIO3PbspQ7bqWAJLiDrandlNNxXoMrAkMdZttXV/75mvvLDCOq7iscxaXI9/uPwW/V7W1BwxBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hCqA1B0nQSFfKg/8VT5mteK6iwf47eBKT6V7sKALC78=; b=W4a2NY/InC7OqOKn4/UJNx05cl4w5lKpNSsTh+qaeftIhe5VQJsYmlg4WaFMbcOin3tDlHv8sgs2I5FlGchMCKMNmQdA45S0FwJUrgG4JWtsFyx8jqPJXJy9l+zEqz6JJK4facaBPDDmzV0AP7FfMLeEohqSdkEX26ks03wo+Uogk2gM8kUDVx1hNvLXvPwoKKmFztJR9XU+8yjyzvdy0sm+nMlM3+Vs25HcxxC2Cx4A0ArRnsLgPqHpxuOPzB5QKFSM0t1jL7dnee/sfm02N4asIuKtLsDz+QBo7z1GXSq6hXo8bMWHh57wxv+xEsCz7bUAUcoMpkOb86ML1zI/7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hCqA1B0nQSFfKg/8VT5mteK6iwf47eBKT6V7sKALC78=; b=p5346XhlSaEaBDWUEUovMSGbsZnxk5bPyTB9V7csyiGEEd+UQdrs8InREaB7mKfAYLKVXao2RomOm8ITUV/jr29HE/hba8OBugaGAhFY2JSJIgRg3w2C6MZ3gfDRYd9x73rZYZSbfSB0PZmivX5j3Z2sx7MJoClzl+JE04wFl07pHeRKAIhlGrm+uqoCcAYYOPycxMX81hCqF5Ox2Zru3w0gV3t+Yu4biIvOhEvyVKX8R1rgsDKluxLLfdiGTU72fQkw8hWatl3A23oQkFQ+V8iSL/RO761J/HJlkzqSluygtlvXY+mW/9OVo8AfNRRupLiU3m17oO6OdadEXIF9RA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5624.apcprd06.prod.outlook.com (2603:1096:101:c8::14) by PUZPR06MB6055.apcprd06.prod.outlook.com (2603:1096:301:106::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.24; Mon, 26 Aug 2024 07:06:35 +0000 Received: from SEZPR06MB5624.apcprd06.prod.outlook.com ([fe80::e837:10e3:818e:bdfd]) by SEZPR06MB5624.apcprd06.prod.outlook.com ([fe80::e837:10e3:818e:bdfd%5]) with mapi id 15.20.7897.021; Mon, 26 Aug 2024 07:06:35 +0000 From: Lei Liu To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com, Lei Liu Subject: [PATCH v2 2/5] usb: pxa27x_udc: Use devm_clk_get_enabled() helpers Date: Mon, 26 Aug 2024 15:06:23 +0800 Message-Id: <20240826070624.1891-1-liulei.rjpt@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: TY2PR02CA0062.apcprd02.prod.outlook.com (2603:1096:404:e2::26) To SEZPR06MB5624.apcprd06.prod.outlook.com (2603:1096:101:c8::14) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5624:EE_|PUZPR06MB6055:EE_ X-MS-Office365-Filtering-Correlation-Id: 417bc7dd-8643-43d7-44e2-08dcc59d9f1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|52116014|38350700014|41080700001; X-Microsoft-Antispam-Message-Info: x1MAVraWJq7/Z9u6HhKz4CtTncCGPUZEBFga9khaWeM7/buGh5kvUt4Ew3CNSUnaHswHUNAVChX9a/hx5sPLZWZcns6/sU8xD7lhvpUU7t5L2QaPIvphXpuwuJRCaChqCW4z8Tnys8FRjKtFh832Q1PWDKISZBMaWj9yGrtDVeP06+yW9BvnaQ5L/H42gy+p9/1wpF5J5obnNTWI7TRQNsr2FqJLQjAj0P+U8kt/kLpi7B8+c6ISbyJickwjmJ5wlbcbc431xiZF0EN4FcMpUEoPAxfnJbsoO4wgJ8wrCjMiTBUATYtILoGAnAav/8QnPPDcLlmlj6DgHmOZbQl5xxJDnpRLg6Gw5hqLnrQO1yNvbVw/yl2+dFA7M/DggEnS9Y452yzoXBMzkf/T5ueh8UNB1a6mEWxo7OUUayODF4LdebgV7CBkpDlL5v/blXYSwg41qa5gKeJSThvIQow1xWJdoCkmak2KXL515/du545SH7qCDfgyEUhIk0ZkQQh5+9c4d+OSCb4JPQb0Jb4comCp45UhofQsqxSfQXqOdGS2zePXdrsVsm2kAs10thN2OBex3utfGO+C06o/UXMjWKqZemtNtd1GbMSmQbnCE1TnJzuDXr/LySkQitZm5sHDsvFtmK72b7g1Rh6GysU/P7MFGqHIa/vFIOC3xc0vbqJYN+g1WnlCPM6sBH5HpB/d6Q1t53KdvhPytmbHcOGBtC+j4awABqGPDlxYQhncY9PaCN9tRhGo+GRvZoBr90o12DrG5zIg4oxz5FXduHIfhq3vpYM5SJgJTIR2TZx7HYAqECu3NaJJJw9hVawg0SQPCuH/0ZZ5CH2ksTfWTLYst/p/J2Royy1PgZCGbtBNGQ+M2Zt9rVY4Z6hMnU1dBo4BuOrJfWST6TWRxq2USvcduHE0iD0uStKibvyP+wNdeQdO5xwmmefC9XlDak+ONm/9pVyBcQKL3k/le6JU6yCbODeHA8rygPUA4HBCkVAwCt2Xg3aCZO7HYXKsnZl/54ik8HapHSMaR3Adc7Z05zhvONijpA2sO8duc4tScN82ILvg3NN/u645/Xu4LoDsRIKt8q72u3RW5y61n6dZ5YSbyAJG6bDZC2iRiEqUyVE3rH95zYI0lnft4rI35ee4WUK57k8Qop3tht/5wT2cExHPOTC/Sf/+IQDOJz9m/Xjg5pb9nvzdIsdX/VUCeDKK/KM4O7zbu9GDV+JYxg0VDYXcPyiHf4DBEN2ONQheU4XQ5diuMJy6UBt8xTfu+mHCKhRQgP/DGHc356teFltNbK/CN5AphgF+wmEp2LYaO/nTU7BGBSrLXjAy2qOmEUxCcZ5FFdzFzkd+/AQdBfs3BXDcb3NnfzkoEW/Lyl/FEqQcwRzIfYfhr+zbFp4rUFTzQ6YxRt1UWRyhz4vtL2x/PV2Obna5yUf09x0tlu0OWnT1bUK4FbdpoLBaTOePFsGSI7S5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5624.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014)(41080700001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UZOphrMFMUV39/0e1/pEhfIcKoTKBg2IyO1g6wijOXT6YI98utt5MBiJhBq1EvslTWBN1duVkUfmgfic/eKYgAcyxL+8RRPaIJOz9+noUq2g4RrXnLLasc3xp6LouTCYhI6nD8SiAfVjRF4eVSu5sDFxRuNH58PSHhU334wNnhZTFCHqdnN0HFY316IfWcEaggnu+db3Qx1Mk0ztT9XfvZpFkSNAGQgZtMCamCG/1owUWlroN3u4LDH8tErmRPzQt7mzlqfExDyQChLBwhtqhmEdYEOS5F4ONwa3e/meYMnGouTG6GGw7l5rtGU+wNHkTUCTbqBXTIqtUkNa9VcQtMe+1bjt7ewpU5lWOBobOzEsiV9H5h+cDZocVC+QwEbSHFPK4CGWaRILmlU2cwMwJdzJUwdySbjid2l4DJxAow+U46zLm9Pa7uaSpgHu5TBpgjq3EwZPVwBLeJkCTJR55zN/KEENZ6k0h/f8nJds3K+6ATJ2/0z0zPROAlGE5BCvr6UgHxIxhcuydCrYocRa/QqyAYi9ELkbdtlliCYFAEXmA2ZuQFC7Cz0jAuhzz191lkWeUdSILdss1JwNsrzp09W1gdzCmMnlW0EjCZ0xg7BpuDPZs2+ZXA2HeU6xWVSw3Kb1YUGZpd2B5VNd2Fw8DNCIckrX+5FcUvyG8I0sx+CIch6LE88Fh9Wu2HXyFhtD/WdQf1R8MYQCGM7tHvuK0X3JpA3JuP/T3V2td/5jPSESJf7aw5vMFmm3WlPgpm6zZHVM5uWV4mjoKQ8IlHpVvu2kLarXfKu6g+LH92GpXHr5pg9eNtG6Gixnf6RSsNMu40vxTEQlaraW0bm2NSNbTUiPaA2xhdclw8AeWlc77E6TnzeA8yl81rdsa2DrFRwIvCh0Z0KK47Qh+q+fI65Ev+iHxhbRklL1+8aZC6e47uL0vCfmM8xeWjQrue8E0P9f0UJn8vtgtxs/Hg1hhKpjLctripbP/rIPRNJRIilgRDNOMBzCUfTyCIlba/Q5TVgmumxt+D346ugyeyJA+93q2F2ZhdCdpa1SnZB5yIzHLP+u44oc2x4tDhtjsnLA1s7hKLXih4+K4sd3S8QA+nfsJg10vIBzAzN9PMnedjGvbCAoTcRQWzY6Tc/oN5t5TfgNJGceO6whFg8Ccos8Ewx/e2Ot91WyJ8dQ5LU2ZKWLUOkRnOD9p01JLwT2VNoGfp9YR7Rv6ISA/4XEkQpsN1qMSzkqiRmOZSSNVhPUGSDxJENkBX9LcE5aVNWoLB6HtPXSQxLxx8f/F6KJCpuvwd7ObaXfsk0dEV8yfBECTvE7UZYtRRZ5mE8LeEzGY7dD8ySHsLuh54IVjkinx5KyBmHhY7z2FV6Xi98XtrGN+ZQy3aWhiY1NRnc/8H6UVRET0H1UCd2pSFBYPZkl9J/jWikxcnsfDQbQVfIIBLwrM47/HCkNBM+Lmups4KUhA6JE72dL0ZmhYZkj4pHRk+FoFGDridTqLfr3z4/pSganZJ4a+kqLtDwcIYQwLLjJ4ofjCaFmK4rmdRooRZFGpOgD4M++tW3fyj5XelVMu1dRGorYt0TzN5oa4FZvg7MsKtWNSocw X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 417bc7dd-8643-43d7-44e2-08dcc59d9f1f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5624.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2024 07:06:35.2841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uPsRQxGsz6CDOXwGJXbPmrl/e3i1dixRFs3lKyyRqwvJzh813r8fTe/MWqBrmHpd9QDzE476EcfH2PYmXwvDbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6055 The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids calls to clk_disable_unprepare(). --- v1 -> v2 Incorrect usage of clk_prepare_enable() should be corrected to devm_clk_get_enabled(). Signed-off-by: Lei Liu --- drivers/usb/gadget/udc/pxa27x_udc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 1a6317e4b2a3..0619507d187e 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2398,14 +2398,10 @@ static int pxa_udc_probe(struct platform_device *pdev) if (udc->gpiod) gpiod_direction_output(udc->gpiod, 0); - udc->clk = devm_clk_get(&pdev->dev, NULL); + udc->clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(udc->clk)) return PTR_ERR(udc->clk); - retval = clk_prepare(udc->clk); - if (retval) - return retval; - udc->vbus_sensed = 0; the_controller = udc;