From patchwork Thu Jun 6 21:02:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferry Toth X-Patchwork-Id: 802565 Received: from mailfilter02-out30.webhostingserver.nl (mailfilter02-out30.webhostingserver.nl [195.211.72.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 881EA13BC02 for ; Thu, 6 Jun 2024 21:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=195.211.72.193 ARC-Seal: i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717707996; cv=pass; b=PLy6CDszziHoq/mEAgW1oNwL0ahuQ9YhXC4ShF5keAy4HHzJM4QbbBb4+qaAByCZxRyplbaDK9WF8Xj/APJm3AfJwX8FupALJAPTjJVXrbqObvFoYZOquaRlBa+pUwYB6PSoDLw8ydoLOQHFUnLDhxkaq5WvE0zHBmD0Pa/6sWw= ARC-Message-Signature: i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717707996; c=relaxed/simple; bh=0LxJ/wU5deDOnAL0gaaMov0d5yoYltHA4deqIeDYEV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MVKP+1jUZbRsb0mPTcIOBtS42MXQi9XLdqptfO2NwgI/rqsMQ+mZaUca4YIT305PxtDiwUby9tS/+fOo3CVRfwfugVw+oyGRuNz2KqsfMpJxWbLW1YrLTdCtFi19X7ebhIAXXduY8ujUw7sn12a/+ZlFJT3LpLvWD00RNVFQQzQ= ARC-Authentication-Results: i=3; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=exalondelft.nl; spf=pass smtp.mailfrom=exalondelft.nl; dkim=pass (2048-bit key) header.d=exalondelft.nl header.i=@exalondelft.nl header.b=H/KoR+up; arc=pass smtp.client-ip=195.211.72.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=exalondelft.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=exalondelft.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=exalondelft.nl header.i=@exalondelft.nl header.b="H/KoR+up" ARC-Seal: i=2; a=rsa-sha256; t=1717707926; cv=pass; d=webhostingserver.nl; s=whs1; b=ytc3+nhwfR0gIiUH4+Wo+9bA43uPUy0NGMHS6MevCU3vBMEq0xNsecf1eVnwHBThBvlpBZ4LbZdGJ vie2rIMvW9C85LTvH5ap315Zn7GkIa2PRUsEBEzIAQucHahdU22e59nG1wF92xd7+YGtnLPWvkib86 lU4+ym9fk83904vUgHCdT9tSfWlwg3MUBd3Mrhbvcwo8CpFHJ+sNtM+s019E6ALppGwwidZwJmXETv BRHtTzliAAwXmdljx5amH6XSUFuu4wLMSIm6Ct58Y+olswp6hkiJWjLcUXTYBNiyQKhc4sViNC3O3w pZRSY/KTczXRWbdOOfuZ6QnZb4xa9ZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=webhostingserver.nl; s=whs1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:dkim-signature:from; bh=EKI97Lvf28y1ymmuneD6FlzohhD+JdA8V3mE6I22kuo=; b=QPtJGxhmNIb2iZqdl+26HdvxJ2TCDaJmokkzx7KGMRBKx8PoovBtZjavO/Vaw1uapXI4wOejmpyVM IMEONNRLIeEeuPVTc5ZEA46UgJr80ga22uSIFOxdJeX2is79q4JQ08TP6ECdPnC/Ort7asSaF8GWy9 5y2tR6p/MgtaMrvrvYMfdMp6sB4lnTarpe/UvzbMcKfSleihHODHm5b1eArCESSFqgnzzMJ+sTzS+X 36RD/SXCiOSNQWnLt6dLaXC+GrmrOe8U5nGfOZyvoDfCnHGcXFBuqcwP9kI62VZmMm1O+cLqlRlABx lWqp6FYvIHrJdpwgf5mKqZKLrCUdf9Q== ARC-Authentication-Results: i=2; mailfilter02.webhostingserver.nl; spf=pass smtp.mailfrom=exalondelft.nl smtp.remote-ip=141.138.168.154; dmarc=pass header.from=exalondelft.nl; arc=pass header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=exalondelft.nl; s=whs1; h=content-transfer-encoding:mime-version:references:in-reply-to:message-id:date: subject:cc:to:from:from; bh=EKI97Lvf28y1ymmuneD6FlzohhD+JdA8V3mE6I22kuo=; b=H/KoR+upqzVhSsBziv46qnRWLxKteKqoD69cbxyiXmqnQeZLVSmmKOt/CqaxJ0xCmRXIclxQOVrKp k8kNwzH40yd6Ql7vqhUVfY844hNzIvTlOp1HVN3w5ekkVDNjFq2t/WbvNYiLMBUeP+86j9fhHcSRWM Gam+drge0E2E8SqN1o2RNhNzVOBKEveTrEI/S+nfBFEd+OWyUIrQp+mm+va27UPCag1X3GjDtg0i7Z N9wh5EIuko3HVp5gJe2c0/k1crGZCdHT8ZOeipsMaTmmYBEIKCtVXzOHtnJvmnxhCbCVMYhMHvt8kB Yq0KKES9LYV3qNMR6yrO1iR+QmYcrsA== X-Halon-ID: 7db8a552-2448-11ef-ae5d-001a4a4cb922 Received: from s198.webhostingserver.nl (s198.webhostingserver.nl [141.138.168.154]) by mailfilter02.webhostingserver.nl (Halon) with ESMTPSA id 7db8a552-2448-11ef-ae5d-001a4a4cb922; Thu, 06 Jun 2024 23:05:23 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=webhostingserver.nl; s=whs1; t=1717707923; b=n4Iq1CG8ZkTaWny54ixSQz4ZXSLz1/qAkZp5pHu5f4pXmIsp4DLDMrNOOS/8Veudp29lGh6Wt2 R/fykgw1SotcsAdtbhlAPFOnziDLhTYYg+s8icb0v6QiWILB0Etq4qhdU/1IREZ/S/DSUO12wf n9txzLWaQHxsR/wUemyXzR8jLVPx8N4fxjT0xnSq4/DznTGUZeTiEA7fUD1yp5JpCrbZm5PNgb 3wROyzW5wpQvD67O9yVR9q4RDP4HhvIv4bRzo/V32fOtDw4DQqHVz5IYzkHrQNCp/rG+AbJ7JO wcv2TK+sd5k46JR8Z6CmmpuIuljrSmxeU9TuNj0NSGwQwA==; ARC-Authentication-Results: i=1; webhostingserver.nl; smtp.remote-ip=2a02:a466:68ed:1:d680:309e:9a32:ec62; iprev=pass (2a02-a466-68ed-1-d680-309e-9a32-ec62.fixed6.kpn.net) smtp.remote-ip=2a02:a466:68ed:1:d680:309e:9a32:ec62; auth=pass (PLAIN) smtp.auth=ferry.toth@elsinga.info; spf=softfail smtp.mailfrom=exalondelft.nl; dmarc=skipped header.from=exalondelft.nl; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=webhostingserver.nl; s=whs1; t=1717707923; bh=0LxJ/wU5deDOnAL0gaaMov0d5yoYltHA4deqIeDYEV0=; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From; b=qrRyC7X9UFxTh3HkMIBH3zLLHozLUpYJjUsgRamXw9wb128OwZeX0i/G3F84dqx3qbUYslrJIP BbQcq3jv9cJ+H9YkXlV4iaN2vUhVXdbDppOb7dZfoDGz4R4si90kCXmkwKhG0RbpsOb5JDYMYc 8lo7+L8V1RDB1I8Pe9i38PLRKvUo3rBj8mgHYDMmI/fbDQRHN93Otw5ej0yANCAbpQf4JWmznU viDM6WFDcI0ocXpStT5uGVUJ4CBc939IuxbY+3j0MPMsqykIA6SR7UliNGabGeL/Bmp5EcTNEK 2h4eXClXMB1jvRnGpyBWaZhcBB/eOvA/p59MKS2zLqrwEQ==; Authentication-Results: webhostingserver.nl; iprev=pass (2a02-a466-68ed-1-d680-309e-9a32-ec62.fixed6.kpn.net) smtp.remote-ip=2a02:a466:68ed:1:d680:309e:9a32:ec62; auth=pass (PLAIN) smtp.auth=ferry.toth@elsinga.info; spf=softfail smtp.mailfrom=exalondelft.nl; dmarc=skipped header.from=exalondelft.nl; arc=none Received: from 2a02-a466-68ed-1-d680-309e-9a32-ec62.fixed6.kpn.net ([2a02:a466:68ed:1:d680:309e:9a32:ec62] helo=submission) by s198.webhostingserver.nl with esmtpa (Exim 4.97.1) (envelope-from ) id 1sFKIV-0000000APHI-22yf; Thu, 06 Jun 2024 23:05:23 +0200 From: Ferry Toth To: Greg Kroah-Hartman , "Ricardo B. Marliere" , Kees Cook , Linyu Yuan , Justin Stitt , Ferry Toth , Richard Acayan , Hardik Gajjar , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , s.hauer@pengutronix.de, jonathanh@nvidia.com, paul@crapouillou.net, quic_eserrao@quicinc.com, erosca@de.adit-jv.com, regressions@leemhuis.info, Ferry Toth , stable@vger.kernel.org Subject: [PATCH v1 1/2] Revert "usb: gadget: u_ether: Re-attach netif device to mirror detachment" Date: Thu, 6 Jun 2024 23:02:31 +0200 Message-ID: <20240606210436.54100-2-ftoth@exalondelft.nl> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240606210436.54100-1-ftoth@exalondelft.nl> References: <20240606210436.54100-1-ftoth@exalondelft.nl> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ACL-Warn: Sender domain ( exalondelft.nl ) must match your domain name used in authenticated email user ( ferry.toth@elsinga.info ). X-ACL-Warn: From-header domain ( exalondelft.nl} ) must match your domain name used in authenticated email user ( ferry.toth@elsinga.info ) X-Antivirus-Scanner: Clean mail though you should still use an Antivirus This reverts commit 76c945730cdffb572c7767073cc6515fd3f646b4. Prerequisite revert for the reverting of the original commit f49449fbc21e. Fixes: 76c945730cdf ("usb: gadget: u_ether: Re-attach netif device to mirror detachment") Fixes: f49449fbc21e ("usb: gadget: u_ether: Replace netif_stop_queue with netif_device_detach") Reported-by: Ferry Toth Cc: stable@vger.kernel.org --- drivers/usb/gadget/function/u_ether.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c index 11dd0b9e847f..aa0511c3a62c 100644 --- a/drivers/usb/gadget/function/u_ether.c +++ b/drivers/usb/gadget/function/u_ether.c @@ -1163,8 +1163,6 @@ struct net_device *gether_connect(struct gether *link) if (netif_running(dev->net)) eth_start(dev, GFP_ATOMIC); - netif_device_attach(dev->net); - /* on error, disable any endpoints */ } else { (void) usb_ep_disable(link->out_ep);