From patchwork Wed May 31 08:55:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 688184 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34255C77B7C for ; Wed, 31 May 2023 08:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235172AbjEaI4J (ORCPT ); Wed, 31 May 2023 04:56:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234310AbjEaI4H (ORCPT ); Wed, 31 May 2023 04:56:07 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C64BE for ; Wed, 31 May 2023 01:56:02 -0700 (PDT) Received: from mail.ideasonboard.com (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 91EB77FC; Wed, 31 May 2023 10:55:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1685523339; bh=+T/dhEBOGXHWr4myrNXKuQOel0Aor+qSh/ChxsQWfg8=; h=From:To:Cc:Subject:Date:From; b=Titebr4JM0s8sOB+sF/KosrQiKhUeHx9SE18veNLCL8cYI1vsM/+YMhUmi443GjZK 9DaAeCIhbaMTJn4YkmbIDw1IQYJVrTNKGXxLmEqUD52XYebjyD9sMVbK5f1El/tn3X DGi3Y/lDeB8z895KUGJuzq0JntJYdWetuZDFANvE= From: Daniel Scally To: Thinh Nguyen , Greg Kroah-Hartman , linux-usb@vger.kernel.org Cc: torleiv@huddly.com, Daniel Scally Subject: [PATCH] usb: dwc3: gadget: Clear DWC3_EP_PENDING_REQUEST from non-0 endpoints Date: Wed, 31 May 2023 09:55:44 +0100 Message-Id: <20230531085544.253363-1-dan.scally@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The DWC3_EP_PENDING_REQUEST flag is set against an endpoint when there are no pending or started requests available. This flag is cleared on queuing to the endpoint for endpoint 0, but not for any other endpoints. This can exacerbate timing problems by allowing a queue to go ahead for an isochronous endpoint that should not be started, so clear the flag upon a successful dwc3_gadget_ep_queue(). Signed-off-by: Daniel Scally --- drivers/usb/dwc3/gadget.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 578804dc29ca..bc1d93c56d82 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1988,13 +1988,17 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req) */ if (usb_endpoint_xfer_isoc(dep->endpoint.desc)) { if (!(dep->flags & DWC3_EP_TRANSFER_STARTED)) { + int ret = 0; + if ((dep->flags & DWC3_EP_PENDING_REQUEST)) - return __dwc3_gadget_start_isoc(dep); + ret = __dwc3_gadget_start_isoc(dep); - return 0; + dep->flags &= ~DWC3_EP_PENDING_REQUEST; + return ret; } } + dep->flags &= ~DWC3_EP_PENDING_REQUEST; __dwc3_gadget_kick_transfer(dep); return 0;