From patchwork Wed May 24 10:47:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajat Khandelwal X-Patchwork-Id: 685591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D022AC77B7A for ; Wed, 24 May 2023 10:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234160AbjEXKtI (ORCPT ); Wed, 24 May 2023 06:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233961AbjEXKs6 (ORCPT ); Wed, 24 May 2023 06:48:58 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FA5298; Wed, 24 May 2023 03:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684925337; x=1716461337; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=fFQMtvVG7ki8pPGjTDT6bQARnkhhcTO/Zz59VEKkRBM=; b=WaIvyEGLCsWuta0acv1ErYg3X/8Jeisl6uFn0+AxizZ321YwdL+H7OjN LABF/1MAsZQJEKgLhnSz+OLnQKc7/L47zPUlaFeONUtT/jDIYaUlgJA/K WYgyefT/NruohD9Kb+FsiJn8K459AXdRFpbV04kgndr/jl3/k7JT4hjZ4 tWsUJ/HoYPXMwP7/AFGRN0KFPUVOEV3oVCDwAU4HHqOv1oopDZJnoB7E1 +8hqBejYkiQxep0jS35AH+vbMmZ1dByJAeSASdGCGHLHvWFfgdYDojnhC XEz+n9kRg5FkBGjeYaSTEYtXU6QBwkYB3P6FPT1TsNYrpLjK5matf4/y/ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="342989648" X-IronPort-AV: E=Sophos;i="6.00,189,1681196400"; d="scan'208";a="342989648" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 03:48:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="654760743" X-IronPort-AV: E=Sophos;i="6.00,189,1681196400"; d="scan'208";a="654760743" Received: from unknown (HELO rajath-NUC10i7FNH..) ([10.223.165.88]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 03:48:54 -0700 From: Rajat Khandelwal To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Rajat Khandelwal Subject: [PATCH v5] usb: typec: intel_pmc_mux: Expose IOM port status to debugfs Date: Wed, 24 May 2023 16:17:54 +0530 Message-Id: <20230524104754.4154013-1-rajat.khandelwal@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org IOM status has a crucial role during debugging to check the current state of the type-C port. There are ways to fetch the status, but all those require the IOM port status offset, which could change with platform. Make a debugfs directory for intel_pmc_mux and expose the status under it per port basis. Signed-off-by: Rajat Khandelwal Reviewed-by: Heikki Krogerus --- v5: Remove #ifdef macro for the dentry in struct pmc_usb v4: 1. Maintain a root directory for PMC module and incorporate devices under it 2. Add the debugfs module under '/sys/kernel/debug/usb' 3. Use the platform device 'pmc->dev' to assign the device's name v3: Allocate the debugfs directory name for the platform device with its ACPI dev name included v2: 1. Remove static declaration of the debugfs root for 'intel_pmc_mux' 2. Remove explicitly defined one-liner functions drivers/usb/typec/mux/intel_pmc_mux.c | 52 ++++++++++++++++++++++++++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c index 34e4188a40ff..4969f4a2d445 100644 --- a/drivers/usb/typec/mux/intel_pmc_mux.c +++ b/drivers/usb/typec/mux/intel_pmc_mux.c @@ -15,6 +15,8 @@ #include #include #include +#include +#include #include @@ -143,8 +145,12 @@ struct pmc_usb { struct acpi_device *iom_adev; void __iomem *iom_base; u32 iom_port_status_offset; + + struct dentry *dentry; }; +static struct dentry *pmc_mux_debugfs_root; + static void update_port_status(struct pmc_usb_port *port) { u8 port_num; @@ -639,6 +645,29 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc) return 0; } +static int port_iom_status_show(struct seq_file *s, void *unused) +{ + struct pmc_usb_port *port = s->private; + + update_port_status(port); + seq_printf(s, "0x%08x\n", port->iom_status); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(port_iom_status); + +static void pmc_mux_port_debugfs_init(struct pmc_usb_port *port) +{ + struct dentry *debugfs_dir; + char name[6]; + + snprintf(name, sizeof(name), "port%d", port->usb3_port - 1); + + debugfs_dir = debugfs_create_dir(name, port->pmc->dentry); + debugfs_create_file("iom_status", 0400, debugfs_dir, port, + &port_iom_status_fops); +} + static int pmc_usb_probe(struct platform_device *pdev) { struct fwnode_handle *fwnode = NULL; @@ -674,6 +703,8 @@ static int pmc_usb_probe(struct platform_device *pdev) if (ret) return ret; + pmc->dentry = debugfs_create_dir(dev_name(pmc->dev), pmc_mux_debugfs_root); + /* * For every physical USB connector (USB2 and USB3 combo) there is a * child ACPI device node under the PMC mux ACPI device object. @@ -688,6 +719,8 @@ static int pmc_usb_probe(struct platform_device *pdev) fwnode_handle_put(fwnode); goto err_remove_ports; } + + pmc_mux_port_debugfs_init(&pmc->port[i]); } platform_set_drvdata(pdev, pmc); @@ -703,6 +736,8 @@ static int pmc_usb_probe(struct platform_device *pdev) acpi_dev_put(pmc->iom_adev); + debugfs_remove(pmc->dentry); + return ret; } @@ -719,6 +754,8 @@ static int pmc_usb_remove(struct platform_device *pdev) acpi_dev_put(pmc->iom_adev); + debugfs_remove(pmc->dentry); + return 0; } @@ -737,7 +774,20 @@ static struct platform_driver pmc_usb_driver = { .remove = pmc_usb_remove, }; -module_platform_driver(pmc_usb_driver); +static int __init pmc_usb_init(void) +{ + pmc_mux_debugfs_root = debugfs_create_dir("intel_pmc_mux", usb_debug_root); + + return platform_driver_register(&pmc_usb_driver); +} +module_init(pmc_usb_init); + +static void __exit pmc_usb_exit(void) +{ + platform_driver_unregister(&pmc_usb_driver); + debugfs_remove(pmc_mux_debugfs_root); +} +module_exit(pmc_usb_exit); MODULE_AUTHOR("Heikki Krogerus "); MODULE_LICENSE("GPL v2");