| Message ID | 20230306103359.6591-4-hdegoede@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: ucsi: 3 bug fixes | expand |
On Mon, Mar 06, 2023 at 11:33:59AM +0100, Hans de Goede wrote: > Commit 130a96d698d7 ("usb: typec: ucsi: acpi: Increase command > completion timeout value") increased the timeout from 5 seconds > to 60 seconds due to issues related to alternate mode discovery. > > After the alternate mode discovery switch to polled mode > the timeout was reduced, but instead of being set back to > 5 seconds it was reduced to 1 second. > > This is causing problems when using a Lenovo ThinkPad X1 yoga gen7 > connected over Type-C to a LG 27UL850-W (charging DP over Type-C). > > When the monitor is already connected at boot the following error > is logged: "PPM init failed (-110)", /sys/class/typec is empty and > on unplugging the NULL pointer deref fixed earlier in this series > happens. > > When the monitor is connected after boot the following error > is logged instead: "GET_CONNECTOR_STATUS failed (-110)". > > Setting the timeout back to 5 seconds fixes both cases. > > Fixes: e08065069fc7 ("usb: typec: ucsi: acpi: Reduce the command completion timeout") > Cc: stable@vger.kernel.org > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/ucsi/ucsi_acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c > index ce0c8ef80c04..62206a6b8ea7 100644 > --- a/drivers/usb/typec/ucsi/ucsi_acpi.c > +++ b/drivers/usb/typec/ucsi/ucsi_acpi.c > @@ -78,7 +78,7 @@ static int ucsi_acpi_sync_write(struct ucsi *ucsi, unsigned int offset, > if (ret) > goto out_clear_bit; > > - if (!wait_for_completion_timeout(&ua->complete, HZ)) > + if (!wait_for_completion_timeout(&ua->complete, 5 * HZ)) > ret = -ETIMEDOUT; > > out_clear_bit: > -- > 2.39.1
diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c index ce0c8ef80c04..62206a6b8ea7 100644 --- a/drivers/usb/typec/ucsi/ucsi_acpi.c +++ b/drivers/usb/typec/ucsi/ucsi_acpi.c @@ -78,7 +78,7 @@ static int ucsi_acpi_sync_write(struct ucsi *ucsi, unsigned int offset, if (ret) goto out_clear_bit; - if (!wait_for_completion_timeout(&ua->complete, HZ)) + if (!wait_for_completion_timeout(&ua->complete, 5 * HZ)) ret = -ETIMEDOUT; out_clear_bit:
Commit 130a96d698d7 ("usb: typec: ucsi: acpi: Increase command completion timeout value") increased the timeout from 5 seconds to 60 seconds due to issues related to alternate mode discovery. After the alternate mode discovery switch to polled mode the timeout was reduced, but instead of being set back to 5 seconds it was reduced to 1 second. This is causing problems when using a Lenovo ThinkPad X1 yoga gen7 connected over Type-C to a LG 27UL850-W (charging DP over Type-C). When the monitor is already connected at boot the following error is logged: "PPM init failed (-110)", /sys/class/typec is empty and on unplugging the NULL pointer deref fixed earlier in this series happens. When the monitor is connected after boot the following error is logged instead: "GET_CONNECTOR_STATUS failed (-110)". Setting the timeout back to 5 seconds fixes both cases. Fixes: e08065069fc7 ("usb: typec: ucsi: acpi: Reduce the command completion timeout") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/usb/typec/ucsi/ucsi_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)