From patchwork Wed Mar 1 21:49:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 658085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EE8C7EE23 for ; Wed, 1 Mar 2023 21:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjCAVuQ (ORCPT ); Wed, 1 Mar 2023 16:50:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbjCAVuJ (ORCPT ); Wed, 1 Mar 2023 16:50:09 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B21A742BFF for ; Wed, 1 Mar 2023 13:50:01 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id w192-20020a25dfc9000000b009fe14931caaso1780435ybg.7 for ; Wed, 01 Mar 2023 13:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677707401; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=dxQv5waFu3xv0IisW1bjLsRrEXTjdfJSWFhFeoxtPOI=; b=N0u2emcPqt+w7HnP6S48oXIFPSC90k8hPUi9FBqczZs2DLe8JGmBZf1tTzSI/9AJH9 R3FeC2qBR0N/gzkaEhSFWOlLBGf99HsTk0r1gK3GpRCXRnpK5SiC0Yx225WQheq0SlzC gEYBGiYbZvVIaQntfs/IHBIlqcngYC0LYQFg5yIub0ACOUKSxh6/QjCCsPBWToMY8k2i OJ6IoUK5EckhAroQDcpi60bjmLR6gu2GB7HtnbPBOScP7J08EmqazMAPZfvRnAnp3bjp H0Bn3xnSH5bFiIwDSIR4cc5jzdqq4WJY3DUuQ7FpLxhP0MHcVbnjLTKsr9NYP2cE3X42 2Olw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707401; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dxQv5waFu3xv0IisW1bjLsRrEXTjdfJSWFhFeoxtPOI=; b=2nDjI4/u9Pym/neSsqoXD+op6xPUqGmVDvzon0dKilwINrnUSYoGXasyrfdDp2LKO+ tP++CCCmO9G6OYxEbJLnUdc3FnGc3WYGlCAEQMmrTGJYc3lOg/B74TV/voG2EbXKkd4n jFjyywDtdVKWtEVPDKwnph/fzPZ8jjIBF7QP8y/+5+WzkkA9qb00xRka4Uhn4zBDqeoq OSBPSNIaXdqg/mZbIu908pGgkl9klaGqQJ28Eb9bK7esxz9coTkv8Ss/ro8AKKxmpCXR OPffwG4OcDyvgl3lrQqAZ9p2nFu4o9WN3UVDRnBdNKYh8xrdngqIa29dD8qj652IE92c hToA== X-Gm-Message-State: AO0yUKUymMq57+IzdTh8dbQicRpjbrhQLqTjYwDs7eShf3rE5V+zCghw WSorqHgl3uhILUqSym4wyCOCBOdx78IrYew= X-Google-Smtp-Source: AK7set/xyvoFhdWMtePqqoxkiFKJ9A1bLedjGccifdYq3F7anLkOM2Yz4H0fTroMYl9LFY2P1BNgvnKva6FUsqQ= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:debf:1aed:5c45:c92]) (user=saravanak job=sendgmr) by 2002:a81:86c2:0:b0:536:e8b5:e7a5 with SMTP id w185-20020a8186c2000000b00536e8b5e7a5mr22ywf.239.1677707400820; Wed, 01 Mar 2023 13:50:00 -0800 (PST) Date: Wed, 1 Mar 2023 13:49:49 -0800 In-Reply-To: <20230301214952.2190757-1-saravanak@google.com> Message-Id: <20230301214952.2190757-3-saravanak@google.com> Mime-Version: 1.0 References: <20230301214952.2190757-1-saravanak@google.com> X-Mailer: git-send-email 2.39.2.722.g9855ee24e9-goog Subject: [PATCH v1 2/4] usb: typec: tipd: Remove use of fw_devlink_purge_absent_suppliers() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Heikki Krogerus , Guenter Roeck , Andy Shevchenko , Daniel Scally , Sakari Ailus , Len Brown Cc: Saravana Kannan , Yongqin Liu , Sumit Semwal , Martin Kepplinger , Amelie Delaunay , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan Cc: Martin Kepplinger Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tipd/core.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 485b90c13078..92401622bc4e 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -764,16 +764,7 @@ static int tps6598x_probe(struct i2c_client *client) if (ret < 0) goto err_clear_mask; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ fwnode = device_get_named_child_node(&client->dev, "connector"); - if (fwnode) - fw_devlink_purge_absent_suppliers(fwnode); tps->role_sw = fwnode_usb_role_switch_get(fwnode); if (IS_ERR(tps->role_sw)) {