diff mbox series

[V3,1/2] usb: gadget: u_ether: Improve print in gether_setup_name_default()

Message ID 20230119102547.26698-1-jonathanh@nvidia.com
State Superseded
Headers show
Series [V3,1/2] usb: gadget: u_ether: Improve print in gether_setup_name_default() | expand

Commit Message

Jon Hunter Jan. 19, 2023, 10:25 a.m. UTC 
The print in in gether_setup_name_default() does not provide any useful
information because a random MAC address will always be generated when
calling this function. Update the print to show MAC address that is
generated which is similar to other ethernet drivers.

Given that the strings 'self' and 'host' are static, we do not need to
pass these strings as arguments.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
V2 -> V3: Updated commit message
V1 -> V2: Added this patch

 drivers/usb/gadget/function/u_ether.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 8f12f3f8f6ee..be8e7b448933 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -845,13 +845,13 @@  struct net_device *gether_setup_name_default(const char *netname)
 	snprintf(net->name, sizeof(net->name), "%s%%d", netname);
 
 	eth_random_addr(dev->dev_mac);
-	pr_warn("using random %s ethernet address\n", "self");
+	pr_warn("using random self ethernet address %pM\n", dev->dev_mac);
 
 	/* by default we always have a random MAC address */
 	net->addr_assign_type = NET_ADDR_RANDOM;
 
 	eth_random_addr(dev->host_mac);
-	pr_warn("using random %s ethernet address\n", "host");
+	pr_warn("using random host ethernet address %pM\n", dev->host_mac);
 
 	net->netdev_ops = &eth_netdev_ops;