From patchwork Tue Dec 6 01:48:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Badhri Jagan Sridharan X-Patchwork-Id: 632895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA7E0C4708E for ; Tue, 6 Dec 2022 01:48:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbiLFBsb (ORCPT ); Mon, 5 Dec 2022 20:48:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232841AbiLFBs3 (ORCPT ); Mon, 5 Dec 2022 20:48:29 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 981C112AD8 for ; Mon, 5 Dec 2022 17:48:28 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id 203-20020a2502d4000000b006f94ab02400so14149844ybc.2 for ; Mon, 05 Dec 2022 17:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=h9DrD3oFPXDoavGOsF1ixpSGI6PcvOV3sQMSM7zsZrg=; b=RdFdqjT1CasRGFsal6IcoDbvQgLEosOjxsoko2VsgH4kjgAOigwIDFI+4IkQJtY/3F nrt34rDbkC7YcVrL07FlQz4JasK28jmX4s+cZlUfRWaaxo3nLmFNPfxajjATOSIXSTM+ Qz+chOizJeQXw4nT6wz3cG3i4M+6dfHJrqmZwR18HJVlFDXW5Ru+hAEtPTYBiq5UJNYz bUOTuD/HOEQimqSixqiiWEL8BfjQwFaNKQQYoC3K+/gbbPEG9ljXPbDWXKNZhj/MLFjn k63eCkQYjNmfxTjGHJUe85rdaCHClDkiCqAt7Ldze6jrnP7m1WUdHeE0gLm59hjzDUsF 5mng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h9DrD3oFPXDoavGOsF1ixpSGI6PcvOV3sQMSM7zsZrg=; b=l96X/QoqCXowiqda1I0EQYP2IKduXTbZm48kCXn4Owa95/XI7OIXKN5be+wtKesgVc UN93Wg8NwD+ASY0FhWt973QL0h/xxirtP26EyJD2IFoAo3bLascdKt94V9mSIx6V6LD2 Pd3oQqJypijCjakipzvJpPdnc5iidMXYCo9hGj2SObHf2GRS36v1GJXAWV71l3CSsveO 08Ky1dZWw/0broTpc1UBq6g8WZWgprzywcNUOyoCPL0rfqF4pfmNz968uIRZ2vWaUjU/ KSHJkvTZHoYlvnnreD8i4S257145Iy1OpCsOKZxw93ZHLRdWvbcgKVYYnhjuHTNXViso 4H9g== X-Gm-Message-State: ANoB5pme6GLXGIjzchKNaDFZge3Sd+9qvEo81V2zv+oSbsGBEICVchmY Xbiy3MxZGQkPFQP2IQJK2ZzJ/ReWZ3A= X-Google-Smtp-Source: AA0mqf6j1s8oGJwUmNbxz9xmVICZum+jc+gBkTaWIHzpeaJSWibYph1hLOUNmyG8AxJW9RIaJzDwv28JH6w= X-Received: from badhri.mtv.corp.google.com ([2620:15c:211:201:8c86:3c57:a044:cb9]) (user=badhri job=sendgmr) by 2002:a25:40d4:0:b0:6f0:118d:f77c with SMTP id n203-20020a2540d4000000b006f0118df77cmr57264697yba.205.1670291307918; Mon, 05 Dec 2022 17:48:27 -0800 (PST) Date: Mon, 5 Dec 2022 17:48:21 -0800 In-Reply-To: <20221206014822.4105421-1-badhri@google.com> Mime-Version: 1.0 References: <20221206014822.4105421-1-badhri@google.com> X-Mailer: git-send-email 2.39.0.rc0.267.gcb52ba06e7-goog Message-ID: <20221206014822.4105421-2-badhri@google.com> Subject: [PATCH v4 2/3] usb: typec: tcpci: Add callback for evaluating contaminant presence From: Badhri Jagan Sridharan To: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , Badhri Jagan Sridharan Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org This change adds callback to evaluate presence of contaminant in the TCPCI layer. Signed-off-by: Badhri Jagan Sridharan --- Changes since v3: * None Changes since v2: * Added tcpci_is_potential_contaminant to offload * disconnect_while_debounce logic --- drivers/usb/typec/tcpm/tcpci.c | 20 ++++++++++++++++++++ include/linux/usb/tcpci.h | 13 +++++++++++++ 2 files changed, 33 insertions(+) diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c index fe781a38dc82..2aadf785970f 100644 --- a/drivers/usb/typec/tcpm/tcpci.c +++ b/drivers/usb/typec/tcpm/tcpci.c @@ -403,6 +403,24 @@ static void tcpci_frs_sourcing_vbus(struct tcpc_dev *dev) tcpci->data->frs_sourcing_vbus(tcpci, tcpci->data); } +static bool tcpci_is_potential_contaminant(struct tcpc_dev *dev, enum tcpm_state current_state) +{ + struct tcpci *tcpci = tcpc_to_tcpci(dev); + + if (tcpci->data->is_potential_contaminant) + return tcpci->data->is_potential_contaminant(tcpci, tcpci->data, current_state); + + return false; +} + +static void tcpci_check_contaminant(struct tcpc_dev *dev) +{ + struct tcpci *tcpci = tcpc_to_tcpci(dev); + + if (tcpci->data->check_contaminant) + tcpci->data->check_contaminant(tcpci, tcpci->data); +} + static int tcpci_set_bist_data(struct tcpc_dev *tcpc, bool enable) { struct tcpci *tcpci = tcpc_to_tcpci(tcpc); @@ -777,6 +795,8 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data) tcpci->tcpc.enable_frs = tcpci_enable_frs; tcpci->tcpc.frs_sourcing_vbus = tcpci_frs_sourcing_vbus; tcpci->tcpc.set_partner_usb_comm_capable = tcpci_set_partner_usb_comm_capable; + tcpci->tcpc.is_potential_contaminant = tcpci_is_potential_contaminant; + tcpci->tcpc.check_contaminant = tcpci_check_contaminant; if (tcpci->data->auto_discharge_disconnect) { tcpci->tcpc.enable_auto_vbus_discharge = tcpci_enable_auto_vbus_discharge; diff --git a/include/linux/usb/tcpci.h b/include/linux/usb/tcpci.h index 17657451c762..548e85fdc7fa 100644 --- a/include/linux/usb/tcpci.h +++ b/include/linux/usb/tcpci.h @@ -188,6 +188,16 @@ struct tcpci; * Optional; The USB Communications Capable bit indicates if port * partner is capable of communication over the USB data lines * (e.g. D+/- or SS Tx/Rx). Called to notify the status of the bit. + * @check_contaminant: + * Optional; The callback is invoked when chiplevel drivers indicated + * that the USB port needs to be checked for contaminant presence. + * Chip level drivers are expected to check for contaminant and call + * tcpm_clean_port when the port is clean to put the port back into + * toggling state. + * @is_potential_contaminant: + * Optional; TCPM invokes the callback for every TCPM state machine + * transition. Chiplevel drivers can monitor the state machine + * transitions to flag for potential contaminant presence. */ struct tcpci_data { struct regmap *regmap; @@ -204,6 +214,9 @@ struct tcpci_data { void (*frs_sourcing_vbus)(struct tcpci *tcpci, struct tcpci_data *data); void (*set_partner_usb_comm_capable)(struct tcpci *tcpci, struct tcpci_data *data, bool capable); + void (*check_contaminant)(struct tcpci *tcpci, struct tcpci_data *data); + bool (*is_potential_contaminant)(struct tcpci *tcpci, struct tcpci_data *data, + enum tcpm_state current_state); }; struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data);