From patchwork Sun Nov 27 14:52:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 629149 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46E3C4332F for ; Sun, 27 Nov 2022 14:52:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiK0Owh (ORCPT ); Sun, 27 Nov 2022 09:52:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbiK0Owe (ORCPT ); Sun, 27 Nov 2022 09:52:34 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A161089; Sun, 27 Nov 2022 06:52:32 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5E83D21B2D; Sun, 27 Nov 2022 14:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669560751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uGCmWgHRCB1XEw4nEtRb3Itymxy+KuQ10BXGquguuj0=; b=iu71He1gjh3KuhXknf6MZr57jbZpPyCd7AKGTl/YqXjoOb6Y42lOpxkfOSVdwJbuFG3POW GCHj1XRVjk+R4eSMhIdklSxG1THciX/kgoSuUoSdWSb0DxcOur98i/EeU6rTFxnLf4XVfq 63FDaU+PmycaDDmtsZW1sdLq73s3xYQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669560751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uGCmWgHRCB1XEw4nEtRb3Itymxy+KuQ10BXGquguuj0=; b=ec8gXkjDlh1plvqoiV+rjr15h69FYpn9gNhiyF3pSTRsa3m4ovVrVJ0ZpwQgHPxPbWmP1D vjsQGRcOXbQOoxAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3265A134CE; Sun, 27 Nov 2022 14:52:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 91+2Cq95g2O5SQAAMHmgww (envelope-from ); Sun, 27 Nov 2022 14:52:31 +0000 Date: Sun, 27 Nov 2022 15:52:30 +0100 From: Jean Delvare To: linux-usb@vger.kernel.org Cc: LKML , Matthias Kaehlcke , Greg Kroah-Hartman Subject: [PATCH] usb: misc: onboard_usb_hub: Drop obsolete dependency on COMPILE_TEST Message-ID: <20221127155230.144886b7@endymion.delvare> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues. Signed-off-by: Jean Delvare Cc: Matthias Kaehlcke Cc: Greg Kroah-Hartman --- drivers/usb/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-6.0.orig/drivers/usb/misc/Kconfig +++ linux-6.0/drivers/usb/misc/Kconfig @@ -298,7 +298,7 @@ config BRCM_USB_PINMAP config USB_ONBOARD_HUB tristate "Onboard USB hub support" - depends on OF || COMPILE_TEST + depends on OF help Say Y here if you want to support discrete onboard USB hubs that don't require an additional control bus for initialization, but