| Message ID | 20221108163001.18454-1-davide.tronchin.94@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] USB: serial: option: remove old LARA-R6 PID | expand |
On 11/8/2022 23:29, Davide Tronchin wrote: > The LARA-R6 module old PID (defined as: UBLOX_PRODUCT_R6XX > 0x90fa) has been removed since is no longer used by the > current u-blox LARA-R6 product. Was it never sold into the market? No current user of it which with this patch would be without driver support for it? /Lars
On 11/8/2022 23:29, Davide Tronchin wrote: > The LARA-R6 module old PID (defined as: UBLOX_PRODUCT_R6XX > 0x90fa) has been removed since is no longer used by the > current u-blox LARA-R6 product. UBlox is not the only company reselling these dongles/cards, a quick google of "vid_05c6&pid_90fa&mi_00" shows that another two resellers has Win drivers for it, GosuncnWelink and Meig. You are now removing the linux driver support that a customer of them currently have. If you are a UBlox employee/representative then I suggest that you tell UBlox that reselling dongles/cards with Qualcomms vid:pid is a bad idea. Qualcomm can provide UBlox with software to personalize the product with UBlox own vid:pid. thanks /Lars
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 697683e3fbff..068c65228d4d 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -240,7 +240,6 @@ static void option_instat_callback(struct urb *urb); #define QUECTEL_PRODUCT_UC15 0x9090 /* These u-blox products use Qualcomm's vendor ID */ #define UBLOX_PRODUCT_R410M 0x90b2 -#define UBLOX_PRODUCT_R6XX 0x90fa /* These Yuga products use Qualcomm's vendor ID */ #define YUGA_PRODUCT_CLM920_NC5 0x9625 @@ -1124,8 +1123,6 @@ static const struct usb_device_id option_ids[] = { /* u-blox products using Qualcomm vendor ID */ { USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R410M), .driver_info = RSVD(1) | RSVD(3) }, - { USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R6XX), - .driver_info = RSVD(3) }, /* Quectel products using Quectel vendor ID */ { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21, 0xff, 0xff, 0xff), .driver_info = NUMEP2 },
The LARA-R6 module old PID (defined as: UBLOX_PRODUCT_R6XX 0x90fa) has been removed since is no longer used by the current u-blox LARA-R6 product. The USB composition has been changed by u-blox to meet new requirements (3 serial ports over USB). Signed-off-by: Davide Tronchin <davide.tronchin.94@gmail.com> --- V3 -> V4: as requested, the patch has been split to 3 sub-patches. Fix comment format. V2 -> V3: added this section to tracking changes with previous versions. Added some explanations about the RSVD(4) in the description session. Added reservation to port 4 of VID:PID 0x05C6:0x908B to meet other companies QMI net interface implementation. V1 -> V2: define UBLOX_PRODUCT_LARA_R6 0x908b has been deleted together with the previosly provided definition of USB_DEVICE since the PID is used by another vendor. The LARA-L6 patch part is the same of the previosly provided one. drivers/usb/serial/option.c | 3 --- 1 file changed, 3 deletions(-)