| Message ID | 20220625084913.603556-4-gabriel@gvisoc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] staging: Thunderbolt: ctl.c: Fixed 2 literal style coding issues | expand |
On Sat, 2022-06-25 at 18:49 +1000, Gabriel Viso Carrera wrote: > Fixed a couple of comment aligment & formatting coding style issues. trivia: > diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c [] > @@ -402,11 +403,11 @@ static bool tb_ctl_handle_event(struct tb_ctl *ctl, enum tb_cfg_pkg_type type, > static void tb_ctl_rx_submit(struct ctl_pkg *pkg) > { > tb_ring_rx(pkg->ctl->rx, &pkg->frame); /* > - * We ignore failures during stop. > - * All rx packets are referenced > - * from ctl->rx_packets, so we do > - * not loose them. > - */ > + * We ignore failures during stop. > + * All rx packets are referenced > + * from ctl->rx_packets, so we do > + * not loose them. > + */ I'd indent this only 1 level and put it before the call (and fix the loose/lose typo) { /* We ignore failures during stop. * All rx packets are referenced from ctl->rx_packets, * so we do not lose them. */ tb_ring_rx(pkg->ctl->rx, &pkg->frame); }
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c index 6c973fdf7b36..5c6c62867b9c 100644 --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -276,7 +276,8 @@ static void tb_cfg_print_error(struct tb_ctl *ctl, switch (res->tb_error) { case TB_CFG_ERROR_PORT_NOT_CONNECTED: /* Port is not connected. This can happen during surprise - * removal. Do not warn. */ + * removal. Do not warn. + */ return; case TB_CFG_ERROR_INVALID_CONFIG_SPACE: /* @@ -402,11 +403,11 @@ static bool tb_ctl_handle_event(struct tb_ctl *ctl, enum tb_cfg_pkg_type type, static void tb_ctl_rx_submit(struct ctl_pkg *pkg) { tb_ring_rx(pkg->ctl->rx, &pkg->frame); /* - * We ignore failures during stop. - * All rx packets are referenced - * from ctl->rx_packets, so we do - * not loose them. - */ + * We ignore failures during stop. + * All rx packets are referenced + * from ctl->rx_packets, so we do + * not loose them. + */ } static int tb_async_error(const struct ctl_pkg *pkg)
Fixed a couple of comment aligment & formatting coding style issues. Signed-off-by: Gabriel Viso Carrera <gabriel@gvisoc.com> --- drivers/thunderbolt/ctl.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)