| Message ID | 20220407074945.74449-2-sven@svenschwermer.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/2] net: usb: cdc_ether: Add Fibocom L610 modem | expand |
On Thu, Apr 07, 2022 at 09:49:45AM +0200, sven@svenschwermer.de wrote: > From: Sven Schwermer <sven.schwermer@disruptive-technologies.com> My comments on patch 1/2 apply here too. > +GTUSBMODE: 31 > -------------- > T: Bus=03 Lev=01 Prnt=01 Port=06 Cnt=04 Dev#= 99 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=2cb7 ProdID=0106 Rev= 0.00 > S: Manufacturer=Fibocom MA510 Modem > S: Product=Fibocom MA510 Modem > S: SerialNumber=55e2695b > C:* #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=500mA > A: FirstIf#= 3 IfCount= 2 Cls=02(comm.) Sub=00 Prot=00 > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=option > E: Ad=82(I) Atr=03(Int.) MxPS= 64 Ivl=2ms > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=option > E: Ad=84(I) Atr=03(Int.) MxPS= 64 Ivl=2ms > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 3 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=06 Prot=00 Driver=cdc_ether > E: Ad=86(I) Atr=03(Int.) MxPS= 64 Ivl=2ms > I: If#= 4 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether > I:* If#= 4 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether > E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > +GTUSBMODE: 32 > -------------- > T: Bus=03 Lev=01 Prnt=01 Port=06 Cnt=04 Dev#=100 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=2cb7 ProdID=010a Rev= 0.00 > S: Manufacturer=Fibocom MA510 Modem > S: Product=Fibocom MA510 Modem > S: SerialNumber=55e2695b > C:* #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=500mA > A: FirstIf#= 2 IfCount= 2 Cls=02(comm.) Sub=00 Prot=00 > I:* If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=option > E: Ad=81(I) Atr=03(Int.) MxPS= 64 Ivl=2ms > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=fe Prot=ff Driver=option > E: Ad=83(I) Atr=03(Int.) MxPS= 64 Ivl=2ms > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=06 Prot=00 Driver=cdc_ether > E: Ad=85(I) Atr=03(Int.) MxPS= 64 Ivl=2ms > I: If#= 3 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether > I:* If#= 3 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether > E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > Signed-off-by: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > --- > drivers/usb/serial/option.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 75b62e08b82f..01a12c5d469f 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -2118,6 +2118,10 @@ static const struct usb_device_id option_ids[] = { > .driver_info = RSVD(4) | RSVD(5) }, > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0105, 0xff), /* Fibocom NL678 series */ > .driver_info = RSVD(6) }, > + { USB_DEVICE(0x2cb7, 0x0106), /* Fibocom MA510 (+GTUSBMODE=31) */ > + .driver_info = RSVD(3) | RSVD(4) }, > + { USB_DEVICE(0x2cb7, 0x010a), /* Fibocom MA510 (+GTUSBMODE=32) */ > + .driver_info = RSVD(2) | RSVD(3) }, Please use USB_DEVICE_INTERFACE_CLASS() for both entries. > { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */ > { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */ > { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */ Johan
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 75b62e08b82f..01a12c5d469f 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -2118,6 +2118,10 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(4) | RSVD(5) }, { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0105, 0xff), /* Fibocom NL678 series */ .driver_info = RSVD(6) }, + { USB_DEVICE(0x2cb7, 0x0106), /* Fibocom MA510 (+GTUSBMODE=31) */ + .driver_info = RSVD(3) | RSVD(4) }, + { USB_DEVICE(0x2cb7, 0x010a), /* Fibocom MA510 (+GTUSBMODE=32) */ + .driver_info = RSVD(2) | RSVD(3) }, { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0xff, 0x30) }, /* Fibocom FG150 Diag */ { USB_DEVICE_AND_INTERFACE_INFO(0x2cb7, 0x010b, 0xff, 0, 0) }, /* Fibocom FG150 AT */ { USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a0, 0xff) }, /* Fibocom NL668-AM/NL652-EU (laptop MBIM) */