From patchwork Mon Sep 27 12:38:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 514685 Delivered-To: patch@linaro.org Received: by 2002:a17:906:f46:0:0:0:0 with SMTP id h6csp3897468ejj; Mon, 27 Sep 2021 05:38:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzs2icfFtfFtbAabdChrzncgmuqmrqX/RQSMe2i0cOilBgptrW1bam0tF//q8ZtGM+k34lV X-Received: by 2002:a17:906:71c6:: with SMTP id i6mr5967438ejk.344.1632746318161; Mon, 27 Sep 2021 05:38:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632746318; cv=none; d=google.com; s=arc-20160816; b=K0hPFNj4gl61Xd1cI6SQbKI8WBAl5Jg5NOC/5XMJs6qvWVs/2BpvVaUEG7CpzxiW+e JcDkX9IJez8WQtb3Ox6tBwnuPqBP4YA4bRmgk76OecJsSIOp0/OLXPPGB1c34aKryGQk QnovFqxakcQI7qtaSzTYmxM1vVzIODkVs8TgyDd5eNsKf6wb6OTGPK5HIBU0+z3Ik+ZR kt4U5fdqFexPmfZ4wynmcO97tXGnXn1ixdFwBSRzQZ+al7QC2S/hud8ep0FqVH0ZPX92 tTekLoCMzttc7n/O9GOZAbAdWyrqFAG4S0jr21/Gb207X5UKUJiT6iuN058Kc0QCToUl SVqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=J1hGVbDPTYJyCrSgItRZcPz+Xakat5SgIxiAQtlLIxk=; b=B0h48n64k6mWRTTCWBqs9CmB3SpS2hcsnwiO4Gura52fHbRHQRH5Q5xYJy8BapAJBm l48nhaP9KvhEI7dAVJbwpEl+jIyP+UJBvejJYOPQw5ekqP1Jyv9rc1tLfBviHbjAgfrM WnlVlKYm6DZqQMXIQPG4g75BCUFkX1dh04GhdJ6htE2WDMu7pIF8Mdt5pf2d9qDdVJOA yYa06ZocdwH4HxIkk5oapGcTpYq0DLZuZbVuKZMYjzEk6Dax1GuM+ECouXI3Ocek7Su3 nvup6CBSyKl0ZSAT9UC/MwC+8YkcgH65EUX6juQrcfxnUWz09NO8wt2barm7NhXZ+bqh IBUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OKrYssl0; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id os28si11214194ejb.559.2021.09.27.05.38.37; Mon, 27 Sep 2021 05:38:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OKrYssl0; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234361AbhI0MkO (ORCPT + 4 others); Mon, 27 Sep 2021 08:40:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:57672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234337AbhI0MkM (ORCPT ); Mon, 27 Sep 2021 08:40:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E18A60FF2; Mon, 27 Sep 2021 12:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632746314; bh=e+bNLTCuq7rd5GH4BwuiLOjI8vpmkyfEg4ZBAUITB4k=; h=From:To:Cc:Subject:Date:From; b=OKrYssl09h3Pv6UhJfR5x+oAeOwNOTHdwJLafsN/xxC9MyBlraGZMJrDuBCsOmjrw WwfOgbvBy/WAvs6bSqFP/8o3e3hKm1ED8SpYSB0EKYkqelrvINKXIqEiX4F8UXI00z ro9rZRfIGcrJxro4iABlc+13sXCM8m2q+waYrZwauksbInTmtnmzD0qJ48cXZb+hk0 Is5FE7ETemZMvq4rrYHVC1EZ9pUDkgUbcFum+l1TvjUud+McuHesPhp7FDXP0nlUcr weVHvENc0q53WERk/A2TLH8aatlAPUfSJiI1BVBCX/agB763oe0puwUjKftqAMXb0E 2DhZ0O6ColWyg== From: Arnd Bergmann To: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Felipe Balbi , Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers Cc: Arnd Bergmann , Rikard Falkeborn , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH] [RFC] usb: gadget: avoid unusual inline assembly Date: Mon, 27 Sep 2021 14:38:20 +0200 Message-Id: <20210927123830.1278953-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Arnd Bergmann clang does not understand the "mrc%?" syntax: drivers/usb/gadget/udc/pxa25x_udc.c:2330:11: error: invalid % escape in inline assembly string I don't understand it either, but removing the %? here gets it to build. This is probably wrong and someone else should do a proper patch. Any suggestions? Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/pxa25x_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2 diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index a09ec1d826b2..52cdfd8212d6 100644 --- a/drivers/usb/gadget/udc/pxa25x_udc.c +++ b/drivers/usb/gadget/udc/pxa25x_udc.c @@ -2325,7 +2325,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev) pr_info("%s: version %s\n", driver_name, DRIVER_VERSION); /* insist on Intel/ARM/XScale */ - asm("mrc%? p15, 0, %0, c0, c0" : "=r" (chiprev)); + asm("mrc p15, 0, %0, c0, c0" : "=r" (chiprev)); if ((chiprev & CP15R0_VENDOR_MASK) != CP15R0_XSCALE_VALUE) { pr_err("%s: not XScale!\n", driver_name); return -ENODEV;