From patchwork Thu Aug 19 18:09:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Miguel Silva X-Patchwork-Id: 499760 Delivered-To: patch@linaro.org Received: by 2002:a02:6f15:0:0:0:0:0 with SMTP id x21csp772686jab; Thu, 19 Aug 2021 11:09:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEopD/x35f6VyBF5j0viT/5vqtq4zSiIUDw/Mm5S1Si03ZOWtOWMpjqA7GI1bBsoxttAJF X-Received: by 2002:a02:1083:: with SMTP id 125mr13866836jay.34.1629396597865; Thu, 19 Aug 2021 11:09:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629396597; cv=none; d=google.com; s=arc-20160816; b=GCjRWf30TTNZaXX2fftfRTQGHB33jhtd3gU5aOm3oap9wivgEk/Dr0eK9xfIA41si2 1p+NLoz9o1G5B9EbZnQfxBee8a66PEL05q+bhQMHen+/Q+AtAHwL3qD8QX6rLyuUoZn2 K8QUXTkgc8h52ILRyvfN7GbVAmATj2FsPtgv9y1YUdS4bFnJYKtKM8vAUcpByFnJXR9T L2AneDnllwu6gH5v3IYpinkNHrGH4qDOAvI1X7kpSXw9rgX1Qox62/4Fu1wE9hpR36Y9 MsKaGNrYFhQbZBPCYCvAt5xSf5kwytQ4n3ZsijuNylPNy1OKIAHT3hyEEjpzg1I5wRN0 TiMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kIhATUwU3sUQYA4q+gJG6oepV84++lZlrfSYVpZi/Vs=; b=QuuMDVWaTSSxvlqoojT30UHBNo4xyMrZdHZyl20TympTt7Gte85Lkl7/lDi8FKilp9 mzMqpUCrP09QKQxPCfqDmt5I1czifDJ16M6q0HEJx3lXVS7Pf57DP4P3OWLQ3IIRuWDu gDUcB6TOMKwi2ywLJbOc3CVPql9XrIzXORLsNiPQI0pJwbe818TlsQwHs9FIDUabY7Oz D0MOOzEcnri9j+yMeRSZk9N348hGD72A2Au/CljXQruuMI3s0sd7Ptel1hcOaFLS9AAi CczIYC/y47gvfMbbjHU8IQFKBoGZqBtB92lStcu99glhOUKUNUqeGqGHjuxyEahxPesj gM2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PLoEyfbF; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si3606755ioe.21.2021.08.19.11.09.57; Thu, 19 Aug 2021 11:09:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PLoEyfbF; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234280AbhHSSKb (ORCPT + 4 others); Thu, 19 Aug 2021 14:10:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbhHSSKa (ORCPT ); Thu, 19 Aug 2021 14:10:30 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46DECC061575 for ; Thu, 19 Aug 2021 11:09:54 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id g138so4344548wmg.4 for ; Thu, 19 Aug 2021 11:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kIhATUwU3sUQYA4q+gJG6oepV84++lZlrfSYVpZi/Vs=; b=PLoEyfbFNDueucBTSH5khGQEwCDcfGBRfIgUqzg14x8DgeVgU3k+CX+70c0MxLdFFE Y4Z6YDTWPrzIw65gTljM1rv+oTz00eGTmLWlA7pPrqxBdnlQsIEtVz0dB75JQRiCSNNP n7tfNmXz45GkVHP8ibapyqgcWoCQX5sBiKI8X4jm6sInMk5k0vzGsOtL7OVEmPa1zxNj cTQbOTJc7+27Ef+9WuRFk8XBIAQDoTqZ/7BSBBWVIsfnT7HX9I7TRcTURCg+SXtZFH4E q9C02z6EVunOf/Ai/tpugr513MlsF1OlNAOGj+D8sD5f9pjJndz1j+XSWuuJxfpHyrEX wg/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kIhATUwU3sUQYA4q+gJG6oepV84++lZlrfSYVpZi/Vs=; b=SYClS6kLCSQtxjOMVRUJGKH61hykvUQNWW4GeZfk5vw5XROHcHY0tQ2Ccpo5NwyKOg rVRcElQaDMlICRHktLD8ih0VV5t07Aea5w8H3vxMwqRC/nCJa3E1oK2TZWEv5Jtkt0qk 5wkQiNzeRxdO1NhcjkYuNFMPkTZb9SEEHpJ5LIrS+cmD0KSN2mZ2y9+Z6Lcf9g2570WX EsMPUSVxRp2RTTXLtX+VpwmBmOLBFqB7M9HgpCxwh0upLxzEUOqrK4fzIz5y/xN1GJHM /T/dlpjJd54hv9ApNRPqAeAnbfhLpObLxFt/rWEY5WrxsY7IkEeZBS0ae20PHyEEH1wd 1pKg== X-Gm-Message-State: AOAM531PT4BxZLu0lq/mMxlef5nBXWjtuPaWG5oWT6nBUTJvXPoPO/tA ohQPzz1nztX+SUp9vq6AR+7ozQ== X-Received: by 2002:a05:600c:3591:: with SMTP id p17mr15373wmq.134.1629396592911; Thu, 19 Aug 2021 11:09:52 -0700 (PDT) Received: from arch-thunder.local (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id h16sm3625668wre.52.2021.08.19.11.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 11:09:52 -0700 (PDT) From: Rui Miguel Silva To: Greg Kroah-Hartman , Alan Stern Cc: linux-usb@vger.kernel.org, Rui Miguel Silva Subject: [PATCH 3/5] usb: isp1760: do not reset retval Date: Thu, 19 Aug 2021 19:09:27 +0100 Message-Id: <20210819180929.1327349-4-rui.silva@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210819180929.1327349-1-rui.silva@linaro.org> References: <20210819180929.1327349-1-rui.silva@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org We do not really need to reset retval before get used bellow. This will avoid the clang-analyzer warning: drivers/usb/isp1760/isp1760-hcd.c:1919:2: warning: Value stored to 'retval' is never read [clang-analyzer-deadcode.DeadStores] retval = 0; Signed-off-by: Rui Miguel Silva --- drivers/usb/isp1760/isp1760-hcd.c | 1 - 1 file changed, 1 deletion(-) -- 2.33.0 diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c index 5c947a1eae49..aed2714ce0cf 100644 --- a/drivers/usb/isp1760/isp1760-hcd.c +++ b/drivers/usb/isp1760/isp1760-hcd.c @@ -1919,7 +1919,6 @@ static int isp1760_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, if (list_empty(&new_qtds)) return -ENOMEM; - retval = 0; spin_lock_irqsave(&priv->lock, spinflags); if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)) {