From patchwork Mon Mar 22 21:11:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 406420 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9967C433E3 for ; Mon, 22 Mar 2021 21:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CBCF619A4 for ; Mon, 22 Mar 2021 21:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231748AbhCVVMT (ORCPT ); Mon, 22 Mar 2021 17:12:19 -0400 Received: from mga01.intel.com ([192.55.52.88]:5132 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbhCVVLr (ORCPT ); Mon, 22 Mar 2021 17:11:47 -0400 IronPort-SDR: lq+mZuGXpe7I/XgDGC0jUFWJKimD1xjTfv5kWHbsA+YxsAXD0jQ34sZQlykEuJBjG2MGHV1fOS nsCXyYgejRGg== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="210424058" X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="210424058" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 14:11:47 -0700 IronPort-SDR: 2Oa3bjkD7NcBddGdIwiMO200ixVuKTIHtCHhg0Y6oOIIfX6Z0gKKTlFeL0A3ovt/fAiDpmZPoF AcH8gVpRLg3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="451871773" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 22 Mar 2021 14:11:41 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2C1CC11F; Mon, 22 Mar 2021 23:11:54 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Felipe Balbi , Greg Kroah-Hartman , Linus Walleij Subject: [PATCH v1 1/6] usb: gadget: pch_udc: Drop unneeded cpu_to_le32() call Date: Mon, 22 Mar 2021 23:11:44 +0200 Message-Id: <20210322211149.6658-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Either way ~0 will be in the correct byte order, hence drop unneeded cpu_to_le32() call. Moreover, it makes sparse happy, otherwise it complains: pch_udc.c:1813:27: warning: incorrect type in assignment (different base types) pch_udc.c:1813:27: expected unsigned int [usertype] dataptr pch_udc.c:1813:27: got restricted __le32 [usertype] Fixes: f646cf94520e ("USB device driver of Topcliff PCH") Signed-off-by: Andy Shevchenko --- drivers/usb/gadget/udc/pch_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c index a3c1fc924268..2e2dca391007 100644 --- a/drivers/usb/gadget/udc/pch_udc.c +++ b/drivers/usb/gadget/udc/pch_udc.c @@ -1756,7 +1756,7 @@ static struct usb_request *pch_udc_alloc_request(struct usb_ep *usbep, } /* prevent from using desc. - set HOST BUSY */ dma_desc->status |= PCH_UDC_BS_HST_BSY; - dma_desc->dataptr = cpu_to_le32(DMA_ADDR_INVALID); + dma_desc->dataptr = DMA_ADDR_INVALID; req->td_data = dma_desc; req->td_data_last = dma_desc; req->chain_len = 1;